From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B490C54EE9 for ; Tue, 27 Sep 2022 20:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bz1YRMeYOzLszk1+wMBFlzsyk+Jcy2HbdQ2NpkeJRVc=; b=U/xYBjnGViBcRD AvTKclh7RAQRmkqwiyFNKRYUcMLuGCGE4fRT9srXtNOsSI8VwhhGe1JQxARZpewwOJH7qZCx9YlCP BpuM3/bnz31JMX8VqsZ3SZMSl2HG7znYP1qWZDWCy6jEuqZHMCx1ups0+1qG9baevKhaI/CP1deyl ap5Xxd+h6KEYEl0SEGK7eLd4J/tICsixW2ZYpTN3WHDYqgKnck+D5PlJ67z2nY2R3E2A621gZDw86 zTj43K+HNdbbGiDbYo/Gw5ZEd4vTsQQAMQD9X19zkKsXsy44TagJFhO9VymNc2QV4iY4uRIPMXtWY +3NhYYoe3kUaOn8Ur9cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odHF8-00CYp5-IS; Tue, 27 Sep 2022 20:31:50 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odHF5-00CYly-CA for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 20:31:48 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id CA1C684CB8; Tue, 27 Sep 2022 22:31:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1664310702; bh=K6bz3IB/lxpoayhVETbBciCpy1+waCaLL8iDdDdqOG0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ilu771/4LcVoSY2WJfe5mt9CSlqf3UkrYp/nW9g6t08YpnYxpx/W4A54rj4Cg0UwP 1+k1djVFMp3QEF1TLqw5myovt2OK1PizWSOo7MwDopkKhStI347I7Rvd7LbvrG/y5Z Pb3joR9mDEdGOJjFmcrO/eXIqy/J02F4hqXaZifr0aXhYRGmodRCvvgX9DE53l+Iac hkJ9hfjhkG2DH5CQsx4vMCarF5ZjGDzGinD0N2FlmwiMoV0O15JGlehlmH/OtCI4C0 K+EQ89voW8dtvyW0glC7LIvxicZno1KBZk+XV+rxPhm4GP/y1PtAO6fIQTSYGKGCMs xsN/Pbb82ZEnw== Message-ID: Date: Tue, 27 Sep 2022 22:31:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] arm64: dts: imx8mm: Model PMIC to SNVS RTC clock path on Data Modul i.MX8M Mini eDM SBC Content-Language: en-US To: Tim Harvey Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , NXP Linux Team , Peng Fan , Shawn Guo References: <20220924174603.458956-1-marex@denx.de> <0bb82751-a611-e8cd-54bd-e0d04b709133@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_133147_591629_261CB68E X-CRM114-Status: GOOD ( 22.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/27/22 22:23, Tim Harvey wrote: > On Tue, Sep 27, 2022 at 1:10 PM Marek Vasut wrote: >> >> On 9/27/22 21:43, Tim Harvey wrote: >> >> Tim, >> >>> Marek, >>> >>> The modeling here makes sense, but I tried this on the boards I have >>> with the rohm,bd71847 and it did not bump the clk_enable_count for >>> clk-32k-out and thus drivers/clk/clk-bd718x7.c still disables the >>> clock. Is something else required to make that happen? >> >> The only thing I can think of is, do you have SNVS_RTC driver enabled >> and compiled in, just like the PMIC, or are they maybe modules ? >> >> You can always try and add a printk() into the snvs rtc driver and see >> whether the clk_get there doesn't fail for some reason, and what the >> error code is. > > Marek, Tim, > Thanks! I did 'not' have CONFIG_RTC_DRV_SNVS enabled in this test case > and as soon as I enable that it does bump the count and enable the > clock. We actually have a separate watchdog on our boards so I > typically disable the SNVS one to avoid the confusion of having two > watchdogs for our users. I tried adding 'clocks = <&pmic>' to the wdog > node and disalbing the RTC_DRV_SNVS again but it fails to enable that > clock. I believe the 32 kHz fed into the SNVS RTC are mandatory, they must be supplied to the MX8M otherwise the SoC hangs. So whatever supplies the RTC_XTALI on your board should be connected to the SNVS RTC node clock and the SNVS RTC should be enabled. > Also I wonder if your patch deserves a 'Fixes: acb01032e11a5 ("arm64: > defconfig: Enable clock driver for ROHM BD718x7 PMIC")' tag? No, since the current board DT without this patch is not really broken. Without the clock parts in the PMIC node, the PMIC just supplies 32 kHz clock and does not disable those clock, because Linux is not even aware of them, so everything works just fine even if the PMIC driver is enabled. This could potentially by a Fixes for this specific board DT, but I am don't think it's worth it either. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel