From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
lgirdwood@gmail.com, ranjani.sridharan@linux.intel.com,
kai.vehmanen@linux.intel.com, daniel.baluta@nxp.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
joe@perches.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v2 -next] ASoC: SOF: Intel: Fix unused variable warning
Date: Thu, 7 May 2020 09:27:15 -0500 [thread overview]
Message-ID: <d3641489-e3c2-e525-567a-d0348c1eab4e@linux.intel.com> (raw)
In-Reply-To: <20200507072735.16588-1-yuehaibing@huawei.com>
On 5/7/20 2:27 AM, YueHaibing wrote:
> When CONFIG_SND_SOC_SOF_BAYTRAIL is not set, gcc warns:
>
> sound/soc/sof/intel/byt.c:85:41: warning: ‘cht_debugfs’ defined but not used [-Wunused-const-variable=]
> static const struct snd_sof_debugfs_map cht_debugfs[] = {
> ^~~~~~~~~~~
> Move the variable inside #ifdef
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the patch.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
next prev parent reply other threads:[~2020-05-07 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 3:19 [PATCH -next] ASoC: SOF: Intel: Mark cht_debugfs as __maybe_unused YueHaibing
2020-05-07 3:19 ` YueHaibing
2020-05-07 3:39 ` Joe Perches
2020-05-07 3:39 ` Joe Perches
2020-05-07 7:27 ` [PATCH v2 -next] ASoC: SOF: Intel: Fix unused variable warning YueHaibing
2020-05-07 7:27 ` YueHaibing
2020-05-07 14:27 ` Pierre-Louis Bossart [this message]
2020-05-08 10:28 ` Mark Brown
2020-05-08 10:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3641489-e3c2-e525-567a-d0348c1eab4e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=joe@perches.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.