From: Lance Yang <lance.yang@linux.dev>
To: Leon Hwang <leon.hwang@linux.dev>
Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, david@redhat.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com
Subject: Re: [PATCH mm-new 1/1] mm/khugepaged: Factor out common logic in [scan,alloc]_sleep_millisecs_store()
Date: Tue, 21 Oct 2025 10:14:56 +0800 [thread overview]
Message-ID: <d36c0e8d-386b-444c-bd6c-ec9439778e96@linux.dev> (raw)
In-Reply-To: <20251020115350.8175-1-leon.hwang@linux.dev>
On 2025/10/20 19:53, Leon Hwang wrote:
> Both scan_sleep_millisecs_store() and alloc_sleep_millisecs_store()
> perform the same operations: parse the input value, update their
> respective sleep interval, reset khugepaged_sleep_expire, and wake up
> the khugepaged thread.
>
> Factor out this duplicated logic into a helper function
> __sleep_millisecs_store(), and simplify both store functions.
Thanks, less is more ;)
>
> No functional change intended.
>
> Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
> ---
After tweaking as Lorenzo suggested, LGTM.
Reviewed-by: Lance Yang <lance.yang@linux.dev>
prev parent reply other threads:[~2025-10-21 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 11:53 [PATCH mm-new 1/1] mm/khugepaged: Factor out common logic in [scan,alloc]_sleep_millisecs_store() Leon Hwang
2025-10-20 13:53 ` Lorenzo Stoakes
2025-10-20 15:32 ` Leon Hwang
2025-10-20 20:01 ` Zi Yan
2025-10-21 2:14 ` Lance Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d36c0e8d-386b-444c-bd6c-ec9439778e96@linux.dev \
--to=lance.yang@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.