All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series
Date: Sat, 18 Nov 2017 11:24:21 +0100	[thread overview]
Message-ID: <d36e6c31-e059-662d-e739-e72de9b5c8a7@gmail.com> (raw)
In-Reply-To: <SG2PR06MB11658C652DD8C9FF4406E7178A2F0@SG2PR06MB1165.apcprd06.prod.outlook.com>

On 11/17/2017 08:56 PM, Chris Brandt wrote:
> Thanks for the review.
> 
> On Friday, November 17, 2017, Marek Vasut wrote:
>>> +#ifndef RZA_USB
>>
>> This should be turned into Kconfig entry, some CONFIG_...
> 
> So you want RZA_USB in Kconfig, but is it OK if it is automatically 
> selected when an RZ/A device is selected?

That's fine. I (well, the u-boot maintainers in general) want to move to
Kconfig and drop the ad-hoc configuration with macros defined in
include/configs/ at some point.

> For example:
> 
> config R7S72100
> 	bool
> 	select CONFIG_RZA_USB
> 
> Thanks,
> Chris
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2017-11-18 10:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 21:21 [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series Chris Brandt
2017-11-17 19:15 ` Marek Vasut
2017-11-17 19:56   ` Chris Brandt
2017-11-18 10:24     ` Marek Vasut [this message]
2017-11-27 17:27   ` Chris Brandt
2017-11-28  3:06     ` Marek Vasut
2017-11-28 12:07       ` Chris Brandt
2017-11-29  2:54         ` Marek Vasut
2017-11-29 15:28           ` Chris Brandt
2017-11-30  0:16             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d36e6c31-e059-662d-e739-e72de9b5c8a7@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.