From: Daniel Scally <djrscally@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: acpi_device_notify() binding devices that don't seem like they should be bound
Date: Thu, 10 Dec 2020 16:07:56 +0000 [thread overview]
Message-ID: <d3758b6a-7661-03b7-5a67-1fcb82253fb7@gmail.com> (raw)
In-Reply-To: <CAJZ5v0inSq27Zpq=K4df=wypnSdyk5u1P-06wXiVG_vE2ZvDCQ@mail.gmail.com>
On 10/12/2020 16:05, Rafael J. Wysocki wrote:
> All the adevs with matching _ADR also have both _STA and _HID
> unfortunately. Sorry; let me stop half-arsing this and show you
> something useful:
>
> [ 0.219953] acpi_find_child_device(PNP0A08:00, 0x00, false)
> [ 0.220818] INT3472:00: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> [ 0.220821] INT3472:01: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> [ 0.220870] INT3472:02: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> [ 0.220892] INT3472:03: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> [ 0.220916] INT3472:04: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> [ 0.220941] INT3472:05: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> [ 0.220965] INT3472:06: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> [ 0.220990] INT3472:07: _STA 0x00, _ADR=0x00000000, _HID=INT3472
> These will be ignored with -ENODEV.
>
>> [ 0.221038] INT3472:08: _STA 0x0f, _ADR=0x00000000, _HID=INT3472
> For this acpi_find_child_device() will return FIND_CHILD_MIN_SCORE if
> I'm not mistaken.
It does - this is the one that binds, being the first.
>> [ 0.221051] OVTI5648:00: _STA 0x0f, _ADR=0x00000000, _HID=OVTI5648
>> [ 0.221061] INT3472:09: _STA 0x0f, _ADR=0x00000000, _HID=INT3472
>> [ 0.221070] OVTI2680:00: _STA 0x0f, _ADR=0x00000000, _HID=OVTI2680
> As well as for the three above.
>
>> [ 0.221079] INT3471:00: _STA 0x00, _ADR=0x00000000, _HID=INT3471
>> [ 0.221105] INT33BE:00: _STA 0x00, _ADR=0x00000000, _HID=INT33BE
>> [ 0.221130] INT3471:01: _STA 0x00, _ADR=0x00000000, _HID=INT3471
>> [ 0.221156] INT33BE:01: _STA 0x00, _ADR=0x00000000, _HID=INT33BE
> And the rest will be ignored.
>
>> That's the debug output I included for each adev that's assessed as a
>> child of PNP0A08:00. _STA, _ADR and _HID present for all, _ADR 0x00 for
>> all, _STA 0x0f for the 2 sensors and their PMIC's and 0x00 for the rest.
>> The same situation holds on both of my devices.
> So in fact we don't want to have an ACPI companion for (PNP0A08:00,
> 0x00, false).
Yeah, I think that's right
> This is a hostbridge special case and let me think about this for a while.
Sure - thanks very much for your help.
next prev parent reply other threads:[~2020-12-10 16:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 0:00 acpi_device_notify() binding devices that don't seem like they should be bound Daniel Scally
2020-12-08 23:48 ` Daniel Scally
2020-12-09 9:54 ` Daniel Scally
2020-12-09 15:43 ` Rafael J. Wysocki
2020-12-09 16:20 ` Daniel Scally
2020-12-09 16:53 ` Rafael J. Wysocki
2020-12-10 0:06 ` Daniel Scally
2020-12-10 13:53 ` Rafael J. Wysocki
2020-12-10 15:02 ` Daniel Scally
2020-12-10 16:05 ` Rafael J. Wysocki
2020-12-10 16:07 ` Daniel Scally [this message]
2020-12-10 16:59 ` Rafael J. Wysocki
2020-12-10 22:46 ` Daniel Scally
2020-12-11 16:58 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3758b6a-7661-03b7-5a67-1fcb82253fb7@gmail.com \
--to=djrscally@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.