From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED1CC433E0 for ; Tue, 9 Mar 2021 02:23:55 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD3B96527B for ; Tue, 9 Mar 2021 02:23:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD3B96527B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 70D0A4015F; Tue, 9 Mar 2021 02:23:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vGSj283tBvIT; Tue, 9 Mar 2021 02:23:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTP id 291AC40159; Tue, 9 Mar 2021 02:23:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E99D9C000B; Tue, 9 Mar 2021 02:23:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id C09EBC0001 for ; Tue, 9 Mar 2021 02:23:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AFA9B6058F for ; Tue, 9 Mar 2021 02:23:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MsA85k2H5VRj for ; Tue, 9 Mar 2021 02:23:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0B1DB605A2 for ; Tue, 9 Mar 2021 02:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615256629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a6wFttvigZ3krFK2Ucp4xgtYD3Ea0xR4Fa2rCnzkxiI=; b=flKabHBYlZ4D1eLRFiSVIuHag/hsT2ji931+3x30Cg0Fni3O+w0HdQrrEHrBAIED3Hhf09 mQRI4yWZa299Q7nOazuMweOvdguFLmiJuIiVg4qAbOX44CQpMREl1PyOEFFiNJGSTOAwar gd7+mYtkED7yA/yGLsV28krn0la3dio= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-k_UuP8RgN_63zyLo9g98Lw-1; Mon, 08 Mar 2021 21:23:45 -0500 X-MC-Unique: k_UuP8RgN_63zyLo9g98Lw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9666A1842142; Tue, 9 Mar 2021 02:23:44 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-202.pek2.redhat.com [10.72.13.202]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEBA560C04; Tue, 9 Mar 2021 02:23:35 +0000 (UTC) Subject: Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA To: Zhu Lingshan , mst@redhat.com, lulu@redhat.com References: <20210308083525.382514-1-lingshan.zhu@intel.com> <20210308083525.382514-3-lingshan.zhu@intel.com> From: Jason Wang Message-ID: Date: Tue, 9 Mar 2021 10:23:34 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210308083525.382514-3-lingshan.zhu@intel.com> Content-Language: en-GB X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Ck9uIDIwMjEvMy84IDQ6MzUg5LiL5Y2ILCBaaHUgTGluZ3NoYW4gd3JvdGU6Cj4gVGhpcyBjb21t aXQgZW5hYmxlZCBJbnRlbCBGUEdBIFNtYXJ0TklDIEM1MDAwWC1QTCB2aXJ0aW8tbmV0Cj4gZm9y IHZEUEEKPgo+IFNpZ25lZC1vZmYtYnk6IFpodSBMaW5nc2hhbiA8bGluZ3NoYW4uemh1QGludGVs LmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9iYXNlLmggfCA1ICsrKysr Cj4gICBkcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfbWFpbi5jIHwgNSArKysrKwo+ICAgMiBmaWxl cyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92ZHBh L2lmY3ZmL2lmY3ZmX2Jhc2UuaCBiL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9iYXNlLmgKPiBp bmRleCA2NDY5NmQ2M2ZlMDcuLjc1ZDlhODA1MjAzOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Zk cGEvaWZjdmYvaWZjdmZfYmFzZS5oCj4gKysrIGIvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX2Jh c2UuaAo+IEBAIC0yMyw2ICsyMywxMSBAQAo+ICAgI2RlZmluZSBJRkNWRl9TVUJTWVNfVkVORE9S X0lECTB4ODA4Ngo+ICAgI2RlZmluZSBJRkNWRl9TVUJTWVNfREVWSUNFX0lECTB4MDAxQQo+ICAg Cj4gKyNkZWZpbmUgQzUwMDBYX1BMX1ZFTkRPUl9JRAkJMHgxQUY0Cj4gKyNkZWZpbmUgQzUwMDBY X1BMX0RFVklDRV9JRAkJMHgxMDAwCj4gKyNkZWZpbmUgQzUwMDBYX1BMX1NVQlNZU19WRU5ET1Jf SUQJMHg4MDg2Cj4gKyNkZWZpbmUgQzUwMDBYX1BMX1NVQlNZU19ERVZJQ0VfSUQJMHgwMDAxCgoK SSBqdXN0IG5vdGljZSB0aGF0IHRoZSBkZXZpY2UgaXMgYSB0cmFuc3RpdGlvbmFsIG9uZS4gQW55 IHJlYXNvbiBmb3IgCmRvaW5nIHRoaXM/CgpOb3RlIHRoYXQgSUZDVkYgaXMgYSBtb2RlbiBkZXZp Y2UgYW55aG93ICgweDEwNDEpLiBTdXBwb3J0aW5nIGxlZ2FjeSAKZHJpdmUgbWF5IGJyaW5nIG1h bnkgaXNzdWVzIChlLmcgdGhlIGRlZmluaXRpb24gaXMgbm9uLW5vbWFydGl2ZSkuIE9uZSAKZXhh bXBsZSBpcyB0aGUgc3VwcG9ydCBvZiBWSVJUSU9fRl9JT01NVV9QTEFURk9STSwgbGVnYWN5IGRy aXZlciBtYXkgCmFzc3VtZSB0aGUgZGV2aWNlIGNhbiBieXBhc3MgSU9NTVUuCgpUaGFua3MKCgo+ ICsKPiAgICNkZWZpbmUgSUZDVkZfU1VQUE9SVEVEX0ZFQVRVUkVTIFwKPiAgIAkJKCgxVUxMIDw8 IFZJUlRJT19ORVRfRl9NQUMpCQkJfCBcCj4gICAJCSAoMVVMTCA8PCBWSVJUSU9fRl9BTllfTEFZ T1VUKQkJCXwgXAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfbWFpbi5j IGIvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX21haW4uYwo+IGluZGV4IGU1MDFlZTA3ZGUxNy4u MjZhMmRhYjdjYTY2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9tYWlu LmMKPiArKysgYi9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfbWFpbi5jCj4gQEAgLTQ4NCw2ICs0 ODQsMTEgQEAgc3RhdGljIHN0cnVjdCBwY2lfZGV2aWNlX2lkIGlmY3ZmX3BjaV9pZHNbXSA9IHsK PiAgIAkJSUZDVkZfREVWSUNFX0lELAo+ICAgCQlJRkNWRl9TVUJTWVNfVkVORE9SX0lELAo+ICAg CQlJRkNWRl9TVUJTWVNfREVWSUNFX0lEKSB9LAo+ICsJeyBQQ0lfREVWSUNFX1NVQihDNTAwMFhf UExfVkVORE9SX0lELAo+ICsJCQkgQzUwMDBYX1BMX0RFVklDRV9JRCwKPiArCQkJIEM1MDAwWF9Q TF9TVUJTWVNfVkVORE9SX0lELAo+ICsJCQkgQzUwMDBYX1BMX1NVQlNZU19ERVZJQ0VfSUQpIH0s Cj4gKwo+ICAgCXsgMCB9LAo+ICAgfTsKPiAgIE1PRFVMRV9ERVZJQ0VfVEFCTEUocGNpLCBpZmN2 Zl9wY2lfaWRzKTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51 eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1h bi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18AF5C433DB for ; Tue, 9 Mar 2021 02:24:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E362265287 for ; Tue, 9 Mar 2021 02:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230417AbhCICYC (ORCPT ); Mon, 8 Mar 2021 21:24:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41833 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230397AbhCICXu (ORCPT ); Mon, 8 Mar 2021 21:23:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615256629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a6wFttvigZ3krFK2Ucp4xgtYD3Ea0xR4Fa2rCnzkxiI=; b=flKabHBYlZ4D1eLRFiSVIuHag/hsT2ji931+3x30Cg0Fni3O+w0HdQrrEHrBAIED3Hhf09 mQRI4yWZa299Q7nOazuMweOvdguFLmiJuIiVg4qAbOX44CQpMREl1PyOEFFiNJGSTOAwar gd7+mYtkED7yA/yGLsV28krn0la3dio= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-k_UuP8RgN_63zyLo9g98Lw-1; Mon, 08 Mar 2021 21:23:45 -0500 X-MC-Unique: k_UuP8RgN_63zyLo9g98Lw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9666A1842142; Tue, 9 Mar 2021 02:23:44 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-202.pek2.redhat.com [10.72.13.202]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEBA560C04; Tue, 9 Mar 2021 02:23:35 +0000 (UTC) Subject: Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA To: Zhu Lingshan , mst@redhat.com, lulu@redhat.com Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210308083525.382514-1-lingshan.zhu@intel.com> <20210308083525.382514-3-lingshan.zhu@intel.com> From: Jason Wang Message-ID: Date: Tue, 9 Mar 2021 10:23:34 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210308083525.382514-3-lingshan.zhu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021/3/8 4:35 下午, Zhu Lingshan wrote: > This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net > for vDPA > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_base.h | 5 +++++ > drivers/vdpa/ifcvf/ifcvf_main.c | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h > index 64696d63fe07..75d9a8052039 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_base.h > +++ b/drivers/vdpa/ifcvf/ifcvf_base.h > @@ -23,6 +23,11 @@ > #define IFCVF_SUBSYS_VENDOR_ID 0x8086 > #define IFCVF_SUBSYS_DEVICE_ID 0x001A > > +#define C5000X_PL_VENDOR_ID 0x1AF4 > +#define C5000X_PL_DEVICE_ID 0x1000 > +#define C5000X_PL_SUBSYS_VENDOR_ID 0x8086 > +#define C5000X_PL_SUBSYS_DEVICE_ID 0x0001 I just notice that the device is a transtitional one. Any reason for doing this? Note that IFCVF is a moden device anyhow (0x1041). Supporting legacy drive may bring many issues (e.g the definition is non-nomartive). One example is the support of VIRTIO_F_IOMMU_PLATFORM, legacy driver may assume the device can bypass IOMMU. Thanks > + > #define IFCVF_SUPPORTED_FEATURES \ > ((1ULL << VIRTIO_NET_F_MAC) | \ > (1ULL << VIRTIO_F_ANY_LAYOUT) | \ > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c > index e501ee07de17..26a2dab7ca66 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -484,6 +484,11 @@ static struct pci_device_id ifcvf_pci_ids[] = { > IFCVF_DEVICE_ID, > IFCVF_SUBSYS_VENDOR_ID, > IFCVF_SUBSYS_DEVICE_ID) }, > + { PCI_DEVICE_SUB(C5000X_PL_VENDOR_ID, > + C5000X_PL_DEVICE_ID, > + C5000X_PL_SUBSYS_VENDOR_ID, > + C5000X_PL_SUBSYS_DEVICE_ID) }, > + > { 0 }, > }; > MODULE_DEVICE_TABLE(pci, ifcvf_pci_ids);