From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 729D4C4167B for ; Wed, 6 Dec 2023 18:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8B4IzqxQM6tYoU563hEGYDJJZYhKwdkDIP/8Q8qIW4E=; b=A2jITfANg1gL0l TYdvojoTdyQnN8+E44Z4sm5+gBclbCWVksmEvVzn5E1xtTTu/3h5pi95gx3Gd0k/fdzD1sCcCQ9eM rroHHWN5QAowYTEPSkQWg91ardEIIQ2JYhGeQ9hRUtqj0lNpZWeJS6G32BAyqxjFie8LFdqnhUE5p xfdwbra00sffFn8GJAWEHA8gn0esUwNp7oibpBP5CSRaONMS8p+Xhd02pXaj6aWm0e2viOn59H5Ps A5bjLyxmfr59JMHC+jdy9FDPOUOrl8sHMk9wGscXoCmbocpSJJgH7AAeT/Ui5tmMHUwB9FLXd8BS7 Cd6RzHZZmFn4cUF6hFUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAwbj-00B1wr-2r; Wed, 06 Dec 2023 18:26:51 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAwbg-00B1w0-1R; Wed, 06 Dec 2023 18:26:50 +0000 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-35d72bc5cf2so47295ab.1; Wed, 06 Dec 2023 10:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701887203; x=1702492003; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/ZySKQCUH2RPxJ6tJdSkxJbwaT6/swy656+RmrGV9Kg=; b=QxSXUy8bR8G0ixy6hzxruLvwRAUqHkX78O1DiwiRBNg6IgIwemNRp4/xj8VymNh8i3 2bDuM33wHv/PIrTiyY79WWtddItqdUayX21kcnoWcdX4TxGbRyy62x+ep8dsbOG3YjDn nSfV5BKuZzPEekY+cE1Ctt2vR1hBiU9gqWGdJHpHiPfochixtMGBTwWUXV4er3YU4tVn aDLM6/IO3xF+OEU1Fc8xIjMTLZP5Is2gIuBSYN3I6wAc3maeGPMmEoosYgw1GVerz/GL yk99HV8ftCkv2mlDdhkfb/fPbdqrppFZhz7LpKVPe+m4lhAwsiJ13w5QAOBsMqWVetYp fYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701887203; x=1702492003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ZySKQCUH2RPxJ6tJdSkxJbwaT6/swy656+RmrGV9Kg=; b=ej+P+67JcW3REkVT7lpJv64PEvh7bQjMoJNDfWiiFSafSIMiA0Yt/EV/wOrmuhC/ci gm7CzRDc7HLGHq9J/uM5w9LZX+MsK85zKvd21JnwXWRFkmSCNdF4OBSwuOf0wxw5mCya kBFOzvPlEbtI8bGdXat3AgDe3dGQRUOqmWZoXRGuzGBRqELZWI43lU8aX0buCW8YA69D ffezPBAIQ8vxPdYGz732hQfYtCKTofa8AyuqYN7zKAse/EPmiPkcIxuSNUHlprTiICCn occ8RxkvYwDb4+/JdlrRFwTpxmiDWyby0gBIKKzc2umJn2QkV8ZqATsytGk4j1v1Nd1B MYLg== X-Gm-Message-State: AOJu0YwNoZSx0ad0RPE1tEqjlZRFI0flJCv+58icyaHcsc3sdKwRCUeq XkBWdH5zAT31KCr7CXfv4pM= X-Google-Smtp-Source: AGHT+IE6PzZN0GIbW9nhkBhrktDqmhUZc6UrKi9VtszWP0ZuOdttejlhzjzvWT7tR5TZYs8u772HPA== X-Received: by 2002:a05:6e02:12a2:b0:35d:6aa4:d5d8 with SMTP id f2-20020a056e0212a200b0035d6aa4d5d8mr1673892ilr.37.1701887203568; Wed, 06 Dec 2023 10:26:43 -0800 (PST) Received: from ?IPV6:2001:470:42c4:101:3fb7:1e39:b284:286f? ([2001:470:42c4:101:3fb7:1e39:b284:286f]) by smtp.gmail.com with ESMTPSA id j29-20020a02cb1d000000b00468f1305e4esm84031jap.21.2023.12.06.10.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 10:26:43 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 11:26:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RESEND PATCH] arm64: dts: rockchip: Add PCIe pinctrls to Turing RK1 Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Rob Herring Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Daniel_Kukie=c5=82a?= , Sven Rademakers , Joshua Riek References: <20231205202900.4617-1-CFSworks@gmail.com> <3331042.e9J7NaK4W3@diego> From: Sam Edwards In-Reply-To: <3331042.e9J7NaK4W3@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_102648_489914_A7FF594C X-CRM114-Status: GOOD ( 21.90 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org CgpPbiAxMi82LzIzIDA3OjU1LCBIZWlrbyBTdMO8Ym5lciB3cm90ZToKPiBBbSBEaWVuc3RhZywg NS4gRGV6ZW1iZXIgMjAyMywgMjE6Mjg6NTkgQ0VUIHNjaHJpZWIgU2FtIEVkd2FyZHM6Cj4+IFRo ZSBSSzM1ODggUENJZSAzLjAgY29udHJvbGxlciBzZWVtcyB0byBoYXZlIHVucHJlZGljdGFibGUg YmVoYXZpb3Igd2hlbgo+PiBubyBDTEtSRVEvUEVSU1QvV0FLRSBwaW5zIGFyZSBjb25maWd1cmVk IGluIHRoZSBwaW5tdXguIEluIHBhcnRpY3VsYXIsIGl0Cj4+IHdpbGwgc29tZXRpbWVzICh2YXJ5 aW5nIGJldHdlZW4gc3BlY2lmaWMgUkszNTg4IGNoaXBzLCBub3Qgb3ZlciB0aW1lKSBzaHV0Cj4+ IG9mZiB0aGUgREJJIGJsb2NrLCBhbmQgcmVhZHMgdG8gdGhpcyByYW5nZSB3aWxsIGluc3RlYWQg c3RhbGwKPj4gaW5kZWZpbml0ZWx5Lgo+Pgo+PiBXaGVuIHRoaXMgaGFwcGVucywgaXQgd2lsbCBw cmV2ZW50IExpbnV4IGZyb20gYm9vdGluZyBhbHRvZ2V0aGVyLiBUaGUKPj4gUENJZSBkcml2ZXIg d2lsbCBzdGFsbCB0aGUgQ1BVIGNvcmUgb25jZSBpdCBhdHRlbXB0cyB0byByZWFkIHRoZSB2ZXJz aW9uCj4+IGluZm9ybWF0aW9uIGZyb20gdGhlIERCSSByYW5nZS4KPj4KPj4gRml4IHRoaXMgYm9v dCBoYW5nIGJ5IGFkZGluZyB0aGUgY29ycmVjdCBwaW5jdHJsIGNvbmZpZ3VyYXRpb24gdG8gdGhl Cj4+IFBDSWUgMy4wIGRldmljZSBub2RlLCB3aGljaCBpcyB0aGUgcHJvcGVyIHRoaW5nIHRvIGRv IGFueXdheS4gV2hpbGUKPj4gd2UncmUgYXQgaXQsIGFsc28gYWRkIHRoZSBuZWNlc3NhcnkgY29u ZmlndXJhdGlvbiB0byB0aGUgUENJZSAyLjAgbm9kZSwKPj4gd2hpY2ggbWF5IG9yIG1heSBub3Qg Zml4IHRoZSBlcXVpdmFsZW50IHByb2JsZW0gb3ZlciB0aGVyZSAtLSBidXQgaXMgdGhlCj4+IHBy b3BlciB0aGluZyB0byBkbyBhbnl3YXkuIDopCj4+Cj4+IEZpeGVzOiAyODA2YTY5ZjNmZWY2ICgi YXJtNjQ6IGR0czogcm9ja2NoaXA6IEFkZCBUdXJpbmcgUksxIFNvTSBzdXBwb3J0IikKPj4gU2ln bmVkLW9mZi1ieTogU2FtIEVkd2FyZHMgPENGU3dvcmtzQGdtYWlsLmNvbT4KPj4gLS0tCj4+ICAg Li4uL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC10dXJpbmctcmsxLmR0c2kgfCAxNCAr Ky0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEyIGRl bGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1ODgtdHVyaW5nLXJrMS5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9y azM1ODgtdHVyaW5nLXJrMS5kdHNpCj4+IGluZGV4IDk1NzBiMzRhY2EyZS4uMTI5ZjE0ZGJkNDJm IDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC10dXJp bmctcmsxLmR0c2kKPj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODgt dHVyaW5nLXJrMS5kdHNpCj4+IEBAIC0yMTQsNyArMjE0LDcgQEAgcmdtaWlfcGh5OiBldGhlcm5l dC1waHlAMSB7Cj4+ICAgJnBjaWUyeDFsMSB7Cj4+ICAgCWxpbnV4LHBjaS1kb21haW4gPSA8MT47 Cj4+ICAgCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4+IC0JcGluY3RybC0wID0gPCZwY2ll Ml9yZXNldD47Cj4+ICsJcGluY3RybC0wID0gPCZwY2llMzB4MW0xX3BpbnM+Owo+PiAgIAlyZXNl dC1ncGlvcyA9IDwmZ3BpbzQgUktfUEEyIEdQSU9fQUNUSVZFX0hJR0g+Owo+PiAgIAlzdGF0dXMg PSAib2theSI7Cj4+ICAgfTsKPj4gQEAgLTIyNiw3ICsyMjYsNyBAQCAmcGNpZTMwcGh5IHsKPj4g ICAmcGNpZTN4NCB7Cj4+ICAgCWxpbnV4LHBjaS1kb21haW4gPSA8MD47Cj4+ICAgCXBpbmN0cmwt bmFtZXMgPSAiZGVmYXVsdCI7Cj4+IC0JcGluY3RybC0wID0gPCZwY2llM19yZXNldD47Cj4+ICsJ cGluY3RybC0wID0gPCZwY2llMzB4NG0xX3BpbnM+OwoKSGkgSGVpa28sCgo+IAo+IGFsc28sIHdo eSBhcmUgeW91IHRocm93aW5nIG91dCB0aGUgcGluY3RybCBmb3IgdGhlIHJlc2V0IHBpbi4KPiBU aGF0IHNlZW1zIG5vdCByZWxhdGVkIHRvIHRoZSByZWd1bGFyIHBpbnMgYW5kIHlvdSBjb3VsZCBp bnN0ZWFkIGp1c3QgZG8KPiAKPiArCXBpbmN0cmwtMCA9IDwmcGNpZTMweDRtMV9waW5zPiwgPCZw Y2llM19yZXNldD47CgpUaGUgcGNpZTMweDRtMV9waW5zIGRlZiBkb2VzIGluY2x1ZGUgcGlubXV4 aW5nIGA0IFJLX1BCNmAgdG8gdGhlIERXIApjb250cm9sbGVyIGFscmVhZHkuIFRoZSB2MiBwYXRj aCBzaG91bGQgcHJvYmFibHkgaW5zdGVhZCByZW1vdmUgdGhlIApyZXNldC1ncGlvcyBwcm9wZXJ0 eSwgc2luY2UgYW4gb3V0LW9mLWJhbmQgR1BJTyByZXNldCBpcyBub3QgbmVlZGVkIHdoZW4gCnRo ZSBjb250cm9sbGVyIGNhbiBkbyBpdC4KCkknbSBzdGlsbCBsb29raW5nIGludG8gdGhlIHN0b3J5 IHdpdGggdGhlIFBDSWUgMi4wIHBpbnMsIHNpbmNlIDIuMHgxJ3MgClBFUlNUIyBpcyBkZWZpbml0 ZWx5IDRBMi4gSSdsbCBhc2sgYXJvdW5kIGFuZCB0cnkgdG8gZmluZCBvdXQgd2hlcmUgdGhlIApj b3JyZXNwb25kaW5nIENMS1JFUSMgaXMgZ29pbmcuCgo+IAo+IFRoYW5rcwo+IEhlaWtvCgpMaWtl d2lzZSwKU2FtCgo+IAo+PiAgIAlyZXNldC1ncGlvcyA9IDwmZ3BpbzQgUktfUEI2IEdQSU9fQUNU SVZFX0hJR0g+Owo+PiAgIAl2cGNpZTN2My1zdXBwbHkgPSA8JnZjYzN2M19wY2llMzA+Owo+PiAg IAlzdGF0dXMgPSAib2theSI7Cj4+IEBAIC0yNDUsMTcgKzI0NSw3IEBAIGh5bTg1NjNfaW50OiBo eW04NTYzLWludCB7Cj4+ICAgCQl9Owo+PiAgIAl9Owo+PiAgIAo+PiAtCXBjaWUyIHsKPj4gLQkJ cGNpZTJfcmVzZXQ6IHBjaWUyLXJlc2V0IHsKPj4gLQkJCXJvY2tjaGlwLHBpbnMgPSA8NCBSS19Q QTIgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4+IC0JCX07Cj4+IC0JfTsKPj4gLQo+ PiAgIAlwY2llMyB7Cj4+IC0JCXBjaWUzX3Jlc2V0OiBwY2llMy1yZXNldCB7Cj4+IC0JCQlyb2Nr Y2hpcCxwaW5zID0gPDQgUktfUEI2IFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX25vbmU+Owo+PiAt CQl9Owo+PiAtCj4+ICAgCQl2Y2MzdjNfcGNpZTMwX2VuOiBwY2llMy1yZWcgewo+PiAgIAkJCXJv Y2tjaGlwLHBpbnMgPSA8MiBSS19QQzUgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4+ ICAgCQl9Owo+Pgo+IAo+IAo+IAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlw QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 901E2C4167B for ; Wed, 6 Dec 2023 18:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jE1YDvOem8Hrrkl3/a1Rld5t0/SnZA8DMUdP5lSDTAw=; b=tdi/ihIVXePwWU MJfAUO+MP+Ri2pJB51Vlvb7fxQXdbK8LXcugJfU4fwWkHgcpPKoB4TLjqK6mP7KuHnBQcDWs59QVq bACO+KZxuckSBsvwoFlKZwnNw4ut9HDrjuWd19bTFI7ZrYaN4+lDFd95oCMiOL0WHXVdkPppx0iBQ 6+THxG8+443nvXR+k+HHo6GKR30dTsuUj2TlXcfT2YnnZo9zmvEWlvyLyKxO5B+eCH+obqzIlRweO aRigl7basV/+RhW4rAiVYI7f753n6okgdq07s00Jz5CVmNE44nH17EzjtSowS1Xh55Q+SAtzm7qUO 0HSDmr5tnyfNQYV4MBsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAwbk-00B1wx-0r; Wed, 06 Dec 2023 18:26:52 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAwbg-00B1w0-1R; Wed, 06 Dec 2023 18:26:50 +0000 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-35d72bc5cf2so47295ab.1; Wed, 06 Dec 2023 10:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701887203; x=1702492003; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/ZySKQCUH2RPxJ6tJdSkxJbwaT6/swy656+RmrGV9Kg=; b=QxSXUy8bR8G0ixy6hzxruLvwRAUqHkX78O1DiwiRBNg6IgIwemNRp4/xj8VymNh8i3 2bDuM33wHv/PIrTiyY79WWtddItqdUayX21kcnoWcdX4TxGbRyy62x+ep8dsbOG3YjDn nSfV5BKuZzPEekY+cE1Ctt2vR1hBiU9gqWGdJHpHiPfochixtMGBTwWUXV4er3YU4tVn aDLM6/IO3xF+OEU1Fc8xIjMTLZP5Is2gIuBSYN3I6wAc3maeGPMmEoosYgw1GVerz/GL yk99HV8ftCkv2mlDdhkfb/fPbdqrppFZhz7LpKVPe+m4lhAwsiJ13w5QAOBsMqWVetYp fYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701887203; x=1702492003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ZySKQCUH2RPxJ6tJdSkxJbwaT6/swy656+RmrGV9Kg=; b=ej+P+67JcW3REkVT7lpJv64PEvh7bQjMoJNDfWiiFSafSIMiA0Yt/EV/wOrmuhC/ci gm7CzRDc7HLGHq9J/uM5w9LZX+MsK85zKvd21JnwXWRFkmSCNdF4OBSwuOf0wxw5mCya kBFOzvPlEbtI8bGdXat3AgDe3dGQRUOqmWZoXRGuzGBRqELZWI43lU8aX0buCW8YA69D ffezPBAIQ8vxPdYGz732hQfYtCKTofa8AyuqYN7zKAse/EPmiPkcIxuSNUHlprTiICCn occ8RxkvYwDb4+/JdlrRFwTpxmiDWyby0gBIKKzc2umJn2QkV8ZqATsytGk4j1v1Nd1B MYLg== X-Gm-Message-State: AOJu0YwNoZSx0ad0RPE1tEqjlZRFI0flJCv+58icyaHcsc3sdKwRCUeq XkBWdH5zAT31KCr7CXfv4pM= X-Google-Smtp-Source: AGHT+IE6PzZN0GIbW9nhkBhrktDqmhUZc6UrKi9VtszWP0ZuOdttejlhzjzvWT7tR5TZYs8u772HPA== X-Received: by 2002:a05:6e02:12a2:b0:35d:6aa4:d5d8 with SMTP id f2-20020a056e0212a200b0035d6aa4d5d8mr1673892ilr.37.1701887203568; Wed, 06 Dec 2023 10:26:43 -0800 (PST) Received: from ?IPV6:2001:470:42c4:101:3fb7:1e39:b284:286f? ([2001:470:42c4:101:3fb7:1e39:b284:286f]) by smtp.gmail.com with ESMTPSA id j29-20020a02cb1d000000b00468f1305e4esm84031jap.21.2023.12.06.10.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 10:26:43 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 11:26:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RESEND PATCH] arm64: dts: rockchip: Add PCIe pinctrls to Turing RK1 Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Rob Herring Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Daniel_Kukie=c5=82a?= , Sven Rademakers , Joshua Riek References: <20231205202900.4617-1-CFSworks@gmail.com> <3331042.e9J7NaK4W3@diego> From: Sam Edwards In-Reply-To: <3331042.e9J7NaK4W3@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_102648_489914_A7FF594C X-CRM114-Status: GOOD ( 21.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxMi82LzIzIDA3OjU1LCBIZWlrbyBTdMO8Ym5lciB3cm90ZToKPiBBbSBEaWVuc3RhZywg NS4gRGV6ZW1iZXIgMjAyMywgMjE6Mjg6NTkgQ0VUIHNjaHJpZWIgU2FtIEVkd2FyZHM6Cj4+IFRo ZSBSSzM1ODggUENJZSAzLjAgY29udHJvbGxlciBzZWVtcyB0byBoYXZlIHVucHJlZGljdGFibGUg YmVoYXZpb3Igd2hlbgo+PiBubyBDTEtSRVEvUEVSU1QvV0FLRSBwaW5zIGFyZSBjb25maWd1cmVk IGluIHRoZSBwaW5tdXguIEluIHBhcnRpY3VsYXIsIGl0Cj4+IHdpbGwgc29tZXRpbWVzICh2YXJ5 aW5nIGJldHdlZW4gc3BlY2lmaWMgUkszNTg4IGNoaXBzLCBub3Qgb3ZlciB0aW1lKSBzaHV0Cj4+ IG9mZiB0aGUgREJJIGJsb2NrLCBhbmQgcmVhZHMgdG8gdGhpcyByYW5nZSB3aWxsIGluc3RlYWQg c3RhbGwKPj4gaW5kZWZpbml0ZWx5Lgo+Pgo+PiBXaGVuIHRoaXMgaGFwcGVucywgaXQgd2lsbCBw cmV2ZW50IExpbnV4IGZyb20gYm9vdGluZyBhbHRvZ2V0aGVyLiBUaGUKPj4gUENJZSBkcml2ZXIg d2lsbCBzdGFsbCB0aGUgQ1BVIGNvcmUgb25jZSBpdCBhdHRlbXB0cyB0byByZWFkIHRoZSB2ZXJz aW9uCj4+IGluZm9ybWF0aW9uIGZyb20gdGhlIERCSSByYW5nZS4KPj4KPj4gRml4IHRoaXMgYm9v dCBoYW5nIGJ5IGFkZGluZyB0aGUgY29ycmVjdCBwaW5jdHJsIGNvbmZpZ3VyYXRpb24gdG8gdGhl Cj4+IFBDSWUgMy4wIGRldmljZSBub2RlLCB3aGljaCBpcyB0aGUgcHJvcGVyIHRoaW5nIHRvIGRv IGFueXdheS4gV2hpbGUKPj4gd2UncmUgYXQgaXQsIGFsc28gYWRkIHRoZSBuZWNlc3NhcnkgY29u ZmlndXJhdGlvbiB0byB0aGUgUENJZSAyLjAgbm9kZSwKPj4gd2hpY2ggbWF5IG9yIG1heSBub3Qg Zml4IHRoZSBlcXVpdmFsZW50IHByb2JsZW0gb3ZlciB0aGVyZSAtLSBidXQgaXMgdGhlCj4+IHBy b3BlciB0aGluZyB0byBkbyBhbnl3YXkuIDopCj4+Cj4+IEZpeGVzOiAyODA2YTY5ZjNmZWY2ICgi YXJtNjQ6IGR0czogcm9ja2NoaXA6IEFkZCBUdXJpbmcgUksxIFNvTSBzdXBwb3J0IikKPj4gU2ln bmVkLW9mZi1ieTogU2FtIEVkd2FyZHMgPENGU3dvcmtzQGdtYWlsLmNvbT4KPj4gLS0tCj4+ICAg Li4uL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC10dXJpbmctcmsxLmR0c2kgfCAxNCAr Ky0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEyIGRl bGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1ODgtdHVyaW5nLXJrMS5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9y azM1ODgtdHVyaW5nLXJrMS5kdHNpCj4+IGluZGV4IDk1NzBiMzRhY2EyZS4uMTI5ZjE0ZGJkNDJm IDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU4OC10dXJp bmctcmsxLmR0c2kKPj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODgt dHVyaW5nLXJrMS5kdHNpCj4+IEBAIC0yMTQsNyArMjE0LDcgQEAgcmdtaWlfcGh5OiBldGhlcm5l dC1waHlAMSB7Cj4+ICAgJnBjaWUyeDFsMSB7Cj4+ICAgCWxpbnV4LHBjaS1kb21haW4gPSA8MT47 Cj4+ICAgCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4+IC0JcGluY3RybC0wID0gPCZwY2ll Ml9yZXNldD47Cj4+ICsJcGluY3RybC0wID0gPCZwY2llMzB4MW0xX3BpbnM+Owo+PiAgIAlyZXNl dC1ncGlvcyA9IDwmZ3BpbzQgUktfUEEyIEdQSU9fQUNUSVZFX0hJR0g+Owo+PiAgIAlzdGF0dXMg PSAib2theSI7Cj4+ICAgfTsKPj4gQEAgLTIyNiw3ICsyMjYsNyBAQCAmcGNpZTMwcGh5IHsKPj4g ICAmcGNpZTN4NCB7Cj4+ICAgCWxpbnV4LHBjaS1kb21haW4gPSA8MD47Cj4+ICAgCXBpbmN0cmwt bmFtZXMgPSAiZGVmYXVsdCI7Cj4+IC0JcGluY3RybC0wID0gPCZwY2llM19yZXNldD47Cj4+ICsJ cGluY3RybC0wID0gPCZwY2llMzB4NG0xX3BpbnM+OwoKSGkgSGVpa28sCgo+IAo+IGFsc28sIHdo eSBhcmUgeW91IHRocm93aW5nIG91dCB0aGUgcGluY3RybCBmb3IgdGhlIHJlc2V0IHBpbi4KPiBU aGF0IHNlZW1zIG5vdCByZWxhdGVkIHRvIHRoZSByZWd1bGFyIHBpbnMgYW5kIHlvdSBjb3VsZCBp bnN0ZWFkIGp1c3QgZG8KPiAKPiArCXBpbmN0cmwtMCA9IDwmcGNpZTMweDRtMV9waW5zPiwgPCZw Y2llM19yZXNldD47CgpUaGUgcGNpZTMweDRtMV9waW5zIGRlZiBkb2VzIGluY2x1ZGUgcGlubXV4 aW5nIGA0IFJLX1BCNmAgdG8gdGhlIERXIApjb250cm9sbGVyIGFscmVhZHkuIFRoZSB2MiBwYXRj aCBzaG91bGQgcHJvYmFibHkgaW5zdGVhZCByZW1vdmUgdGhlIApyZXNldC1ncGlvcyBwcm9wZXJ0 eSwgc2luY2UgYW4gb3V0LW9mLWJhbmQgR1BJTyByZXNldCBpcyBub3QgbmVlZGVkIHdoZW4gCnRo ZSBjb250cm9sbGVyIGNhbiBkbyBpdC4KCkknbSBzdGlsbCBsb29raW5nIGludG8gdGhlIHN0b3J5 IHdpdGggdGhlIFBDSWUgMi4wIHBpbnMsIHNpbmNlIDIuMHgxJ3MgClBFUlNUIyBpcyBkZWZpbml0 ZWx5IDRBMi4gSSdsbCBhc2sgYXJvdW5kIGFuZCB0cnkgdG8gZmluZCBvdXQgd2hlcmUgdGhlIApj b3JyZXNwb25kaW5nIENMS1JFUSMgaXMgZ29pbmcuCgo+IAo+IFRoYW5rcwo+IEhlaWtvCgpMaWtl d2lzZSwKU2FtCgo+IAo+PiAgIAlyZXNldC1ncGlvcyA9IDwmZ3BpbzQgUktfUEI2IEdQSU9fQUNU SVZFX0hJR0g+Owo+PiAgIAl2cGNpZTN2My1zdXBwbHkgPSA8JnZjYzN2M19wY2llMzA+Owo+PiAg IAlzdGF0dXMgPSAib2theSI7Cj4+IEBAIC0yNDUsMTcgKzI0NSw3IEBAIGh5bTg1NjNfaW50OiBo eW04NTYzLWludCB7Cj4+ICAgCQl9Owo+PiAgIAl9Owo+PiAgIAo+PiAtCXBjaWUyIHsKPj4gLQkJ cGNpZTJfcmVzZXQ6IHBjaWUyLXJlc2V0IHsKPj4gLQkJCXJvY2tjaGlwLHBpbnMgPSA8NCBSS19Q QTIgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4+IC0JCX07Cj4+IC0JfTsKPj4gLQo+ PiAgIAlwY2llMyB7Cj4+IC0JCXBjaWUzX3Jlc2V0OiBwY2llMy1yZXNldCB7Cj4+IC0JCQlyb2Nr Y2hpcCxwaW5zID0gPDQgUktfUEI2IFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX25vbmU+Owo+PiAt CQl9Owo+PiAtCj4+ICAgCQl2Y2MzdjNfcGNpZTMwX2VuOiBwY2llMy1yZWcgewo+PiAgIAkJCXJv Y2tjaGlwLHBpbnMgPSA8MiBSS19QQzUgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4+ ICAgCQl9Owo+Pgo+IAo+IAo+IAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TKb/E3hC" Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C773122; Wed, 6 Dec 2023 10:26:44 -0800 (PST) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7b6e9f335dcso2390239f.1; Wed, 06 Dec 2023 10:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701887203; x=1702492003; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/ZySKQCUH2RPxJ6tJdSkxJbwaT6/swy656+RmrGV9Kg=; b=TKb/E3hCKNvdTGEVHRBSH3EGiwRrO1Li5kThVkzbUz3rY1/r3Txc+UbB5zVWfjaSLB kngPK1ZRnb2Fyut7Lu+C1o3hDEdN/WFKiwXjm0qLSZZ8IraaAeoZKzad+NKRH9+kM9zV CvCHo0UYHF/esnxovM5YloNrlyynJJmDXWfZ+vQbWsPFtpVEEwfo9axt77yS4w6y3dcN GYThyfpbBvPjZMgmb7X5UMzP6qbo9N6eIs/o24b/w4jJQ3wDBuV++DAnfOUqL0YlLoqd f+7hgAvBaAYgzm1NF3v75gWjkGTJjFPJX0htoz88D0fepLejbJLiiPgY6+AfhIx0OnpR b/Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701887203; x=1702492003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ZySKQCUH2RPxJ6tJdSkxJbwaT6/swy656+RmrGV9Kg=; b=EbfYjoCtFj8MkWc1a6/sMaTscLqgEJ2SfeQJDFkJpQKpb/knWbAm6kemyxoBOejnET o1i2WDlke6MRyyacztXmIbCnf+6nxjuJCHG0cT2r/QBAhNR1kMvR/A744DjKgLS2q4NP YRfQBJns7watvIzbT3G30pz4LYF4nzcmTMtXi7LLq37ZefL9i9FBLq7Vz9melB6LoBAT OCGWM5mNav3G6ZclJGsRWTDjI8kY2vP8sA9nj+D6416q4WFewLuN4KUNmgFTTv4HvqzM 9ur211F0OvfGEOct+YxZQueo6IVnD1OGRzS/wTRUd2tj/OTLbetLGS8lzqYDVwRcNeqq affQ== X-Gm-Message-State: AOJu0Yy9wH9f6nK94rX4pPJLFTPuHaXL+ZWoDLAfsuzMCm5e8qMa10wU JcvDZX6VtIZ07IIBDf9F1Po= X-Google-Smtp-Source: AGHT+IE6PzZN0GIbW9nhkBhrktDqmhUZc6UrKi9VtszWP0ZuOdttejlhzjzvWT7tR5TZYs8u772HPA== X-Received: by 2002:a05:6e02:12a2:b0:35d:6aa4:d5d8 with SMTP id f2-20020a056e0212a200b0035d6aa4d5d8mr1673892ilr.37.1701887203568; Wed, 06 Dec 2023 10:26:43 -0800 (PST) Received: from ?IPV6:2001:470:42c4:101:3fb7:1e39:b284:286f? ([2001:470:42c4:101:3fb7:1e39:b284:286f]) by smtp.gmail.com with ESMTPSA id j29-20020a02cb1d000000b00468f1305e4esm84031jap.21.2023.12.06.10.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 10:26:43 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 11:26:40 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RESEND PATCH] arm64: dts: rockchip: Add PCIe pinctrls to Turing RK1 Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Rob Herring Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Daniel_Kukie=c5=82a?= , Sven Rademakers , Joshua Riek References: <20231205202900.4617-1-CFSworks@gmail.com> <3331042.e9J7NaK4W3@diego> From: Sam Edwards In-Reply-To: <3331042.e9J7NaK4W3@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/6/23 07:55, Heiko Stübner wrote: > Am Dienstag, 5. Dezember 2023, 21:28:59 CET schrieb Sam Edwards: >> The RK3588 PCIe 3.0 controller seems to have unpredictable behavior when >> no CLKREQ/PERST/WAKE pins are configured in the pinmux. In particular, it >> will sometimes (varying between specific RK3588 chips, not over time) shut >> off the DBI block, and reads to this range will instead stall >> indefinitely. >> >> When this happens, it will prevent Linux from booting altogether. The >> PCIe driver will stall the CPU core once it attempts to read the version >> information from the DBI range. >> >> Fix this boot hang by adding the correct pinctrl configuration to the >> PCIe 3.0 device node, which is the proper thing to do anyway. While >> we're at it, also add the necessary configuration to the PCIe 2.0 node, >> which may or may not fix the equivalent problem over there -- but is the >> proper thing to do anyway. :) >> >> Fixes: 2806a69f3fef6 ("arm64: dts: rockchip: Add Turing RK1 SoM support") >> Signed-off-by: Sam Edwards >> --- >> .../arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi | 14 ++------------ >> 1 file changed, 2 insertions(+), 12 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi >> index 9570b34aca2e..129f14dbd42f 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi >> @@ -214,7 +214,7 @@ rgmii_phy: ethernet-phy@1 { >> &pcie2x1l1 { >> linux,pci-domain = <1>; >> pinctrl-names = "default"; >> - pinctrl-0 = <&pcie2_reset>; >> + pinctrl-0 = <&pcie30x1m1_pins>; >> reset-gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>; >> status = "okay"; >> }; >> @@ -226,7 +226,7 @@ &pcie30phy { >> &pcie3x4 { >> linux,pci-domain = <0>; >> pinctrl-names = "default"; >> - pinctrl-0 = <&pcie3_reset>; >> + pinctrl-0 = <&pcie30x4m1_pins>; Hi Heiko, > > also, why are you throwing out the pinctrl for the reset pin. > That seems not related to the regular pins and you could instead just do > > + pinctrl-0 = <&pcie30x4m1_pins>, <&pcie3_reset>; The pcie30x4m1_pins def does include pinmuxing `4 RK_PB6` to the DW controller already. The v2 patch should probably instead remove the reset-gpios property, since an out-of-band GPIO reset is not needed when the controller can do it. I'm still looking into the story with the PCIe 2.0 pins, since 2.0x1's PERST# is definitely 4A2. I'll ask around and try to find out where the corresponding CLKREQ# is going. > > Thanks > Heiko Likewise, Sam > >> reset-gpios = <&gpio4 RK_PB6 GPIO_ACTIVE_HIGH>; >> vpcie3v3-supply = <&vcc3v3_pcie30>; >> status = "okay"; >> @@ -245,17 +245,7 @@ hym8563_int: hym8563-int { >> }; >> }; >> >> - pcie2 { >> - pcie2_reset: pcie2-reset { >> - rockchip,pins = <4 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>; >> - }; >> - }; >> - >> pcie3 { >> - pcie3_reset: pcie3-reset { >> - rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; >> - }; >> - >> vcc3v3_pcie30_en: pcie3-reg { >> rockchip,pins = <2 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>; >> }; >> > > > >