From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ranjani Sridharan Subject: Re: [PATCH 16/28] ASoC: soc-core: initialize rtd->list Date: Mon, 05 Aug 2019 22:00:05 -0700 Message-ID: References: <871rxz3x7e.wl-kuninori.morimoto.gx@renesas.com> <87ef1z2ife.wl-kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 10883F800F4 for ; Tue, 6 Aug 2019 07:00:08 +0200 (CEST) In-Reply-To: <87ef1z2ife.wl-kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Kuninori Morimoto , Mark Brown Cc: Linux-ALSA List-Id: alsa-devel@alsa-project.org On Tue, 2019-08-06 at 10:29 +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > No one initialize rtd->list, so far. > Let's do it. Morimoto-san, I dont think this is needed. The rtd->list is not meant to be a list but rather just as a member of the card->rtd_list. So no need to initialize. Thanks, Ranjani > > Signed-off-by: Kuninori Morimoto > --- > sound/soc/soc-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 2536ba4..2347b58 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -354,6 +354,7 @@ static struct snd_soc_pcm_runtime > *soc_new_pcm_runtime( > if (!rtd) > return NULL; > > + INIT_LIST_HEAD(&rtd->list); > INIT_LIST_HEAD(&rtd->component_list); > rtd->card = card; > rtd->dai_link = dai_link;