From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2372C61D97 for ; Thu, 23 Nov 2023 16:29:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1C2110E76E; Thu, 23 Nov 2023 16:29:58 +0000 (UTC) Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id 637C810E76E for ; Thu, 23 Nov 2023 16:29:57 +0000 (UTC) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700756995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvZq7up+PPvAW4sGoG6+g/5iaMGk3fIhaBZ9sHchUQc=; b=Q6vOvRswfZc7dJeYZkIP0jS8oUTNG3/pt6Sq/97jrBqjIVRqHFSUZqptOfPyzwIi5cc9Dc tClFVBPLfMQ+YV1hZdb9+vpSwfE5nqjGezk5hJaDJMIZDsWv5oxMMrGMrn9x/9JLthu0M/ FbXZQRTGhgNX7mtSjcAtZsBc4HeyXpw= Date: Fri, 24 Nov 2023 00:29:49 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib Content-Language: en-US To: Dmitry Baryshkov References: <20231114150130.497915-1-sui.jingfeng@linux.dev> <20231114150130.497915-9-sui.jingfeng@linux.dev> <79301d04-c0cb-4740-8a6d-27a889b65daf@linux.dev> <121163c9-0d56-47ad-a12e-e67390fef2b4@linux.dev> <00ba2245-0e48-4b21-bcd4-29dfb728e408@linux.dev> <963d7722-738f-4e46-bfb7-131027ca5341@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Sui Jingfeng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Phong LE , Maxime Ripard , Thomas Zimmermann , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2023/11/24 00:06, Dmitry Baryshkov wrote: > On Thu, 23 Nov 2023 at 17:41, Sui Jingfeng wrote: >> Hi, >> >> >> On 2023/11/23 16:08, Dmitry Baryshkov wrote: >>>> The semantics of DRM_BRIDGE_ATTACH_NO_CONNECTOR flag are implement-defined, >>> No, they are not. Semantics are pretty simple: do not create the >>> drm_connector instance. Pass the flag to the next bridge in the chain. >> >> Then, my problem is that do we allow create a drm_connector instance in drm bridge >> driver nowadays? > Yes, if there is no DRM_BRIDGE_ATTACH_NO_CONNECTOR. But that's deprecated IMO. Then can you read the code in bridge/ti-tfp410.c please? The tfp410_attach() function will create drm_connector instance manually if the conditional (flags == 0) is true. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64545C61D97 for ; Thu, 23 Nov 2023 16:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbjKWQ3y (ORCPT ); Thu, 23 Nov 2023 11:29:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjKWQ3v (ORCPT ); Thu, 23 Nov 2023 11:29:51 -0500 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [IPv6:2001:41d0:203:375::b3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7A7310D5 for ; Thu, 23 Nov 2023 08:29:57 -0800 (PST) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700756995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvZq7up+PPvAW4sGoG6+g/5iaMGk3fIhaBZ9sHchUQc=; b=Q6vOvRswfZc7dJeYZkIP0jS8oUTNG3/pt6Sq/97jrBqjIVRqHFSUZqptOfPyzwIi5cc9Dc tClFVBPLfMQ+YV1hZdb9+vpSwfE5nqjGezk5hJaDJMIZDsWv5oxMMrGMrn9x/9JLthu0M/ FbXZQRTGhgNX7mtSjcAtZsBc4HeyXpw= Date: Fri, 24 Nov 2023 00:29:49 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib Content-Language: en-US To: Dmitry Baryshkov Cc: Phong LE , Neil Armstrong , Maxime Ripard , Sui Jingfeng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , Thomas Zimmermann References: <20231114150130.497915-1-sui.jingfeng@linux.dev> <20231114150130.497915-9-sui.jingfeng@linux.dev> <79301d04-c0cb-4740-8a6d-27a889b65daf@linux.dev> <121163c9-0d56-47ad-a12e-e67390fef2b4@linux.dev> <00ba2245-0e48-4b21-bcd4-29dfb728e408@linux.dev> <963d7722-738f-4e46-bfb7-131027ca5341@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2023/11/24 00:06, Dmitry Baryshkov wrote: > On Thu, 23 Nov 2023 at 17:41, Sui Jingfeng wrote: >> Hi, >> >> >> On 2023/11/23 16:08, Dmitry Baryshkov wrote: >>>> The semantics of DRM_BRIDGE_ATTACH_NO_CONNECTOR flag are implement-defined, >>> No, they are not. Semantics are pretty simple: do not create the >>> drm_connector instance. Pass the flag to the next bridge in the chain. >> >> Then, my problem is that do we allow create a drm_connector instance in drm bridge >> driver nowadays? > Yes, if there is no DRM_BRIDGE_ATTACH_NO_CONNECTOR. But that's deprecated IMO. Then can you read the code in bridge/ti-tfp410.c please? The tfp410_attach() function will create drm_connector instance manually if the conditional (flags == 0) is true.