From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57C6FC43458 for ; Wed, 1 Jul 2026 14:48:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1350065.1607646 (Exim 4.92) (envelope-from ) id 1wewEG-0001VM-7D; Wed, 01 Jul 2026 14:47:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350065.1607646; Wed, 01 Jul 2026 14:47:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewEG-0001VF-3L; Wed, 01 Jul 2026 14:47:56 +0000 Received: by outflank-mailman (input) for mailman id 1350065; Wed, 01 Jul 2026 14:47:54 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewEE-0001V9-M4 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:47:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewEE-004ARY-2x for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:47:54 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a452890-bab6-0a2a0a5309dd-0a2a4507e8e2-14 for ; Wed, 01 Jul 2026 16:47:54 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a452899-9c8e-0a2a45070019-d155802ec593-3 for ; Wed, 01 Jul 2026 16:47:54 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4924593f45dso6460585e9.1 for ; Wed, 01 Jul 2026 07:47:53 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2bc5sm84365595e9.5.2026.07.01.07.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 07:47:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782917273; x=1783522073; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5H9FOEbTGuPSoUgzC/ynnLScGlyG4PkeuQTpFvOsYGs=; b=N/UxYgEL+JoCAYj/5G8LUkWxpQSzl9wbLYZQEt6mK8qzc6TvyDtAhkXGE6C94GefQD SYKVfBbXMifkbAhxYMbDqrtRvHCXsNb9Ec2PJZf+shu7pAjxaRYL+zrZfk1xb/aTPGLX XdJqn/+LFndJ45U3ao/QHjKznPZAPeiudrk4yjQUJ4D3JPYOkKP/u9p0awKYVShD0YFC /QXRIfQl0fY5as4i7Sh8ZO/3LzO7lbPJMGEO3tCu3jI+TSj8a5s8Cs31z5Fb7J0HC/M6 BmvZxQ7x+65GCMO0IjVgy/HKPUYhSKHZ5iDktFfNhKKlBfODn3/BED1f4q9KButC/8kV FSQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782917273; x=1783522073; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5H9FOEbTGuPSoUgzC/ynnLScGlyG4PkeuQTpFvOsYGs=; b=eMaTG86YEP6gANfUR75d6ETBIhvTiznsjBCZy66OuZ6YbBPpF19PXvMMHPRSjkag7Z fO3cMSOmdb7Ov2pCEu+IEw1QBUEqAX5bZ1XRZtmut0YQ8hJ8KrpuTUmbqLpQGALEuHU9 4nucRgdCCoj2JNjPWuEi/SQlMkPr1gI52Y8F8ytkKE3kbKXmKdGvGQNV0Migr26DYRG8 HXIPJ8yVINda+/ujK3/7vDt7umN/tDfMfVBr4uwbMPUaoVNnhQf2nrJntfvk9oeUZkQt mF4d/xtkAu2FaS2NpOL2cVCvreyjwigKPZ9yLuhzoragCCmHpl6pV1xcy+TqcfnxNKbd A6EQ== X-Gm-Message-State: AOJu0YycWKNFN1xxGjYv2CpxadBzZTY9OxIHO4cLcUqpsS69hH89nhqF to0cEJJo7Tp5SOwJ0weu/XSQIQGY3NeYVijHl8C+wyEtildFbGp4OSd66jTwhgJ8R1ipbDV6uct kw/Kzqg== X-Gm-Gg: AfdE7cmaKJK9uAux0wiCKUBb663gAOsQVb1amVctd5fJtg3EbbB18rur05eqG1WN3K0 gdcQaH29cnKcQ/N5DdlDKbJPFY9LlPUdHq9EvtJBPXzwxCPMRpf4JX/rHKQSOI1K+AXdjiKutZX pTzg7RJT5yQr9oOLEao72pCpfkbynR06jfQzGBpF9cL5L0SlZc5Dc1XueZi4FebHdF1Ekwr4Y7Y dD7r5Vdilh8Fl6NJT5OC7x9EVNHbw7Tv9S6daSappVOlKQlC6pRyJGQGG9rQ13e9lXiRcny3ril FZVWFTYennKPbVVH9Cbq/+fo0vqmDuhTzwrqyIE4vBr9gqjpUbrhAHgNGeGxACEZYk3UgLbq/V5 rtbqOzYPXx/cVF0YYfGha3dXMGZqwsYe0UUoq5CVI4xs+L/sjmuus9ODLl6DP5Buo5gUohT8eR2 9utbE/sloRHvLoAx/KGnYCdjcuuOqxucFlw0IlGZJDQ1O1UfH2CfDGQCWntFO7ocKetu6zlEAOm 3wv4/o5y46++0A= X-Received: by 2002:a05:600d:644f:10b0:493:bc4a:d5f4 with SMTP id 5b1f17b1804b1-493c2bb226bmr23916745e9.38.1782917273336; Wed, 01 Jul 2026 07:47:53 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 16:47:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/2] libxc: drop size parameter from xc_flask_context_to_sid() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony PERARD , Juergen Gross , Daniel Smith , Marek Marczykowski References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1782917274-7D92225E-99338FD6/0/0 X-purgate-type: clean X-purgate-size: 3695 Nul-terminated strings are passed in all cases, so the strlen() can very well be invoked by the function itself. In preparation for a hypervisor change also include the nul terminator in the size calculation. Signed-off-by: Jan Beulich Acked-by: Marek Marczykowski-Górecki --- Ideally libxl_flask_context_to_sid() would follow suit, but aiui doing so would break its (stable) API. Of course the casts in xc_flask_access() are suspicious. --- v2: Avoid assert() use in libxl. --- a/tools/helpers/init-xenstore-domain.c +++ b/tools/helpers/init-xenstore-domain.c @@ -108,7 +108,7 @@ static int build(xc_interface *xch) if ( flask ) { - rv = xc_flask_context_to_sid(xch, flask, strlen(flask), &config.ssidref); + rv = xc_flask_context_to_sid(xch, flask, &config.ssidref); if ( rv ) { fprintf(stderr, "xc_flask_context_to_sid failed\n"); --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2372,7 +2372,7 @@ long xc_sharing_used_frames(xc_interface /*** End sharing interface ***/ int xc_flask_load(xc_interface *xc_handle, char *buf, uint32_t size); -int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t size, uint32_t *sid); +int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t *sid); int xc_flask_sid_to_context(xc_interface *xc_handle, int sid, char *buf, uint32_t size); int xc_flask_getenforce(xc_interface *xc_handle); int xc_flask_setenforce(xc_interface *xc_handle, int mode); --- a/tools/libs/ctrl/xc_flask.c +++ b/tools/libs/ctrl/xc_flask.c @@ -83,10 +83,11 @@ int xc_flask_load(xc_interface *xch, cha return err; } -int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t size, uint32_t *sid) +int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t *sid) { int err; struct xen_flask_op op = {}; + size_t size = strlen(buf) + 1; DECLARE_HYPERCALL_BOUNCE(buf, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); if ( xc_hypercall_bounce_pre(xch, buf) ) @@ -249,7 +250,7 @@ static int xc_flask_add(xc_interface *xc int err; struct xen_flask_op op = {}; - err = xc_flask_context_to_sid(xch, scontext, strlen(scontext), &sid); + err = xc_flask_context_to_sid(xch, scontext, &sid); if ( err ) return err; @@ -325,10 +326,10 @@ int xc_flask_access(xc_interface *xch, c struct xen_flask_op op = {}; int err; - err = xc_flask_context_to_sid(xch, (char*)scon, strlen(scon), &op.u.access.ssid); + err = xc_flask_context_to_sid(xch, (char*)scon, &op.u.access.ssid); if ( err ) return err; - err = xc_flask_context_to_sid(xch, (char*)tcon, strlen(tcon), &op.u.access.tsid); + err = xc_flask_context_to_sid(xch, (char*)tcon, &op.u.access.tsid); if ( err ) return err; --- a/tools/libs/light/libxl_flask.c +++ b/tools/libs/light/libxl_flask.c @@ -21,7 +21,10 @@ int libxl_flask_context_to_sid(libxl_ctx { int rc; - rc = xc_flask_context_to_sid(ctx->xch, buf, len, ssidref); + if (len != strlen(buf)) + return ERROR_INVAL; + + rc = xc_flask_context_to_sid(ctx->xch, buf, ssidref); return rc; } --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -1754,7 +1754,7 @@ static PyObject *pyflask_context_to_sid( return PyErr_SetFromErrno(xc_error_obj); } - ret = xc_flask_context_to_sid(xc_handle, ctx, strlen(ctx), &sid); + ret = xc_flask_context_to_sid(xc_handle, ctx, &sid); xc_interface_close(xc_handle);