All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Salyzyn <salyzyn@android.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net,
	len.brown@intel.com, linux-pm@vger.kernel.org,
	a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
	linux-rtc@vger.kernel.org, prarit@redhat.com,
	andy.shevchenko@gmail.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH 4/4] time: rtc-lib: Add CONFIG_RTC_SHOW_TIME_RTC
Date: Thu, 20 Jul 2017 10:52:39 -0700	[thread overview]
Message-ID: <d3dce8d2-145a-d4ff-39cc-3b11e59ec921@android.com> (raw)
In-Reply-To: <20170720082620.GB14149@amd>

On 07/20/2017 01:26 AM, Pavel Machek wrote:
>> +#if defined(CONFIG_RTC_SHOW_TIME_RTC)
>> +	{
>> +		struct rtc_time tm;
>> +
>> +		rtc_time64_to_tm(ts.tv_sec, &tm);
>> +		pr_info("%s %d-%02d-%02d %02d:%02d:%02d.%09lu UTC\n",
>> +			prefix_msg ? prefix_msg : "Time:",
>> +			tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday,
>> +			tm.tm_hour, tm.tm_min, tm.tm_sec, ts.tv_nsec);
>> +	}
>> +#else
>
> This was NAKed before. Are you even listening, or are you trying to
> flood us with enough mail so that someone applies your patches by
> mistake?
> 									Pavel

It was NAKed in the group, I put it aside in its own patch to keep from 
throwing out the baby with the bathwater. Was hoping that a private 
CONFIG_RTC_SHOW_TIME_RTC would be acceptable.

I guess not, topic is dead. A refresh is being tested that addresses 
many of the other concerns.

-- Mark

      reply	other threads:[~2017-07-20 17:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19 19:50 [PATCH 4/4] time: rtc-lib: Add CONFIG_RTC_SHOW_TIME_RTC Mark Salyzyn
2017-07-20  8:26 ` Pavel Machek
2017-07-20 17:52   ` Mark Salyzyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3dce8d2-145a-d4ff-39cc-3b11e59ec921@android.com \
    --to=salyzyn@android.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=prarit@redhat.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.