Re: [PATCH 3/3] ARM: dts: marvell: add support for D-Link DNS-320L

[Krzysztof Kozlowski <krzk@kernel.org>]

On 01/07/2024 15:29, Krzysztof Kozlowski wrote:
> 
>>
>>> It does not look like you tested the DTS against bindings. Please run
>>> `make dtbs_check W=1` (see
>>> Documentation/devicetree/bindings/writing-schema.rst or
>>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>>> for instructions).
>>
>> I suspect that is not going to be easy to interpret. kirkwood is very
>> old, much older than the YAML descriptions. DT descriptions of this
>> age were considered correct if the kernel understood them, and the
>> kernel is much more flexible than the YAML bindings. As a result,
>> there are going to be a huge number of warnings, and it will take a
>> lot of skill to pick out real warning which can be fixed from the
>> noise. Also, nobody really cares, because these devices have been out
>> of production for a decade. Nobody is going to clean up the DT files.
> 
> One can just read the binding. Is there address/size cells?
> 
> That's true that you need cleaned up platform to make efficient use of
> the tools, but one can test one particular schema which would print just
> limited amount of bindings.

BTW, I'll fix up few trivial things in Kirkwood and Orion files.

Best regards,
Krzysztof