From: rojay@codeaurora.org
To: Wolfram Sang <wsa@kernel.org>
Cc: swboyd@chromium.org, dianders@chromium.org,
saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org,
mka@chromium.org, akashast@codeaurora.org,
msavaliy@qti.qualcomm.com, skakit@codeaurora.org,
pyarlaga@codeaurora.org, rnayak@codeaurora.org,
agross@kernel.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, sumit.semwal@linaro.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH V7 2/2] i2c: i2c-qcom-geni: Add shutdown callback for i2c
Date: Fri, 08 Jan 2021 15:26:46 +0530 [thread overview]
Message-ID: <d3e53aabf39e888d8184faa2981f7837@codeaurora.org> (raw)
In-Reply-To: <20210105152747.GB1842@ninjato>
Hi Wolfram,
On 2021-01-05 20:57, Wolfram Sang wrote:
>> + geni_status = readl_relaxed(gi2c->se.base + SE_GENI_STATUS);
>> + if (!(geni_status & M_GENI_CMD_ACTIVE))
>> + goto out;
>> +
>> + cur = gi2c->cur;
>> + geni_i2c_abort_xfer(gi2c);
>> + if (cur->flags & I2C_M_RD)
>> + geni_i2c_rx_msg_cleanup(gi2c, cur);
>> + else
>> + geni_i2c_tx_msg_cleanup(gi2c, cur);
>> +out:
>> + pm_runtime_put_sync_suspend(gi2c->se.dev);
>> +}
>
> The use of 'goto' is not needed here IMHO. I think:
>
> if (geni_status & M_GENI_CMD_ACTIVE) {
> do_the_stuff
> }
>
> pm_runtime_put_sync_suspend(...);
>
> is more readable, in fact.
>
In context to the previous comment [1], I have implemented this way.
But, yeah anything is fine for me.
> Also, I don't think we really need the 'cur'
> variable and just use 'gi2c->cur' but that's very minor and you can
> keep
> it if you like it.
>
In geni_i2c_abort_xfer() function gi2c->cur will be made NULL, so
copying it before to "cur" is needed here.
> Reset looks good!
[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/20200820103522.26242-3-rojay@codeaurora.org/#23560541
Thanks,
Roja
next prev parent reply other threads:[~2021-01-08 9:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 12:37 [PATCH V7 0/2] Implement Shutdown callback for geni-i2c Roja Rani Yarubandi
2020-12-21 12:38 ` [PATCH V7 1/2] i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev struct Roja Rani Yarubandi
2020-12-30 9:24 ` Akash Asthana
2021-01-05 15:22 ` Wolfram Sang
2020-12-21 12:38 ` [PATCH V7 2/2] i2c: i2c-qcom-geni: Add shutdown callback for i2c Roja Rani Yarubandi
2020-12-30 9:26 ` Akash Asthana
2021-01-05 15:27 ` Wolfram Sang
2021-01-08 9:56 ` rojay [this message]
2021-01-08 10:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e53aabf39e888d8184faa2981f7837@codeaurora.org \
--to=rojay@codeaurora.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=pyarlaga@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=skakit@codeaurora.org \
--cc=sumit.semwal@linaro.org \
--cc=swboyd@chromium.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.