From: Dave Hansen <dave.hansen@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v2 1/1] x86/reboot: KVM: Guard nmi_shootdown_cpus_on_restart() with ifdeffery
Date: Tue, 8 Apr 2025 07:56:58 -0700 [thread overview]
Message-ID: <d40efb68-eb4e-4158-9dc6-5de101adefd1@intel.com> (raw)
In-Reply-To: <Z_U0Vn0V18KYGjkP@smile.fi.intel.com>
On 4/8/25 07:36, Andy Shevchenko wrote:
> On Tue, Apr 08, 2025 at 07:17:51AM -0700, Dave Hansen wrote:
>> On 4/8/25 05:19, Andy Shevchenko wrote:
>>> Any news here? Build error is still reproducible.
>> In the end, adding the #ifdefs leads to worse code, less maintainable
>> code. I'll take the occasional actual unused static inline in a .c file
>> over a mess of #ifdefs to make the compiler happy.
>>
>> I really think that warning needs to go away in some way, shape or form.
>> Either get rid of it entirely, or kick it out of -Wall somehow. It's a
>> super pedantic warning that leads to worse code most of the time.
> Does it mean you can take Sean's approach?
It looks fine at first glance.
next prev parent reply other threads:[~2025-04-08 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 19:14 [PATCH v2 1/1] x86/reboot: KVM: Guard nmi_shootdown_cpus_on_restart() with ifdeffery Andy Shevchenko
2024-10-09 19:34 ` Sean Christopherson
2024-10-09 23:37 ` Andy Shevchenko
2024-11-04 19:08 ` Andy Shevchenko
2025-04-08 12:19 ` Andy Shevchenko
2025-04-08 14:17 ` Dave Hansen
2025-04-08 14:36 ` Andy Shevchenko
2025-04-08 14:56 ` Dave Hansen [this message]
2025-05-02 14:04 ` Andy Shevchenko
2025-05-02 14:24 ` Dave Hansen
2025-05-02 14:30 ` Peter Zijlstra
2025-05-02 20:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d40efb68-eb4e-4158-9dc6-5de101adefd1@intel.com \
--to=dave.hansen@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.