From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25912CDB465 for ; Mon, 16 Oct 2023 16:05:41 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.617841.960895 (Exim 4.92) (envelope-from ) id 1qsQ5t-0003hP-VT; Mon, 16 Oct 2023 16:05:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 617841.960895; Mon, 16 Oct 2023 16:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qsQ5t-0003hI-SD; Mon, 16 Oct 2023 16:05:25 +0000 Received: by outflank-mailman (input) for mailman id 617841; Mon, 16 Oct 2023 16:05:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qsQ5s-0003hC-Kg for xen-devel@lists.xenproject.org; Mon, 16 Oct 2023 16:05:24 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfe16da7-6c3d-11ee-98d4-6d05b1d4d9a1; Mon, 16 Oct 2023 18:05:23 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id C3EAF4EE0737; Mon, 16 Oct 2023 18:05:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfe16da7-6c3d-11ee-98d4-6d05b1d4d9a1 MIME-Version: 1.0 Date: Mon, 16 Oct 2023 18:05:22 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH][for-next v2 6/8] x86/mce: Move MC_NCLASSES into the enum mctelem_class In-Reply-To: References: <6622a2ec7079f86b73ae420e1e840d3d35ffb3a0.1697123806.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 16/10/2023 17:45, Jan Beulich wrote: > On 12.10.2023 17:28, Nicola Vetrini wrote: >> The definition of MC_NCLASSES contained a violation of MISRA C:2012 >> Rule 10.1, therefore by moving it as an enumeration constant resolves >> the >> violation and makes it more resilient to possible additions to that >> enum. > > And using an enumerator as array dimension specifier is okay for Misra? > That would be odd when elsewhere named enums are treated specially. > > Jan > Yes, the array subscript operator is one of the few places where an enum can be used as an operand (also because negative values wouldn't compile), as opposed to mixing them with ordinary integers. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)