From: Alejandro Colomar <alx.manpages@gmail.com>
To: "Günther Noack" <gnoack3000@gmail.com>
Cc: linux-man@vger.kernel.org, Quentin Monnet <quentin@isovalent.com>
Subject: Re: [PATCH] mount_setattr.2, openat2.2, bpf-helpers.7, landlock.7: wfix
Date: Fri, 21 Apr 2023 21:45:15 +0200 [thread overview]
Message-ID: <d45fce19-e7eb-ed15-3223-df02ba926cc1@gmail.com> (raw)
In-Reply-To: <20230421150555.5075-1-gnoack3000@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 3065 bytes --]
Hi Günther,
On 4/21/23 17:05, Günther Noack wrote:
> Spell "run time" in two words, as documented in man-pages(7).
>
> Signed-off-by: Günther Noack <gnoack3000@gmail.com>
> ---
> man2/mount_setattr.2 | 2 +-
> man2/openat2.2 | 2 +-
> man7/bpf-helpers.7 | 2 +-
> man7/landlock.7 | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/man2/mount_setattr.2 b/man2/mount_setattr.2
> index 24801a4bd..8df02641a 100644
> --- a/man2/mount_setattr.2
> +++ b/man2/mount_setattr.2
> @@ -862,7 +862,7 @@ may change in the future
> user-space applications should zero-fill
> .I struct mount_attr
> to ensure that recompiling the program with new headers will not result in
> -spurious errors at runtime.
> +spurious errors at run time.
Good.
> The simplest way is to use a designated initializer:
> .PP
> .in +4n
> diff --git a/man2/openat2.2 b/man2/openat2.2
> index e90211fad..182851089 100644
> --- a/man2/openat2.2
> +++ b/man2/openat2.2
> @@ -545,7 +545,7 @@ may change in the future (with new fields being added when system headers are
> updated), user-space applications should zero-fill
> .I struct open_how
> to ensure that recompiling the program with new headers will not result in
> -spurious errors at runtime.
> +spurious errors at run time.
Good.
> The simplest way is to use a designated
> initializer:
> .PP
> diff --git a/man7/bpf-helpers.7 b/man7/bpf-helpers.7
> index 26ddf8369..663dfd1d1 100644
> --- a/man7/bpf-helpers.7
> +++ b/man7/bpf-helpers.7
> @@ -3025,7 +3025,7 @@ copied and the last byte is set to NUL.
> On success, returns the number of bytes that were written,
> including the terminal NUL. This makes this helper useful in
> tracing programs for reading strings, and more importantly to
> -get its length at runtime. See the following snippet:
> +get its length at run time. See the following snippet:
Good, but bpf-helpers.7 is generated from kernel sources. This
one will depend on what kernel developers want. I CCed Quentin,
since he's nice and might be able to tell if BPF guys are
interested in this kind of wording fixes.
> .INDENT 7.0
> .INDENT 3.5
> .sp
> diff --git a/man7/landlock.7 b/man7/landlock.7
> index b6c9d3821..250b69635 100644
> --- a/man7/landlock.7
> +++ b/man7/landlock.7
> @@ -251,7 +251,7 @@ will stay enforced on all this thread's descendants.
> This allows creating standalone and modular security policies
> per application,
> which will automatically be composed between themselves
> -according to their runtime parent policies.
> +according to their run time parent policies.
In this case, since it works as an adjective, it should be
"run-time", with a hyphen.
Cheers,
Alex
> .\"
> .SS Ptrace restrictions
> A sandboxed process has less privileges than a non-sandboxed process and
>
> base-commit: 59e44e4511391a98f531c08aaba17391f3b7075b
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-21 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 15:05 [PATCH] mount_setattr.2, openat2.2, bpf-helpers.7, landlock.7: wfix Günther Noack
2023-04-21 19:45 ` Alejandro Colomar [this message]
2023-04-21 21:58 ` Quentin Monnet
2023-04-22 14:59 ` Günther Noack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d45fce19-e7eb-ed15-3223-df02ba926cc1@gmail.com \
--to=alx.manpages@gmail.com \
--cc=gnoack3000@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=quentin@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.