From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Shi Subject: Re: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page() Date: Fri, 17 Jul 2020 17:30:27 +0800 Message-ID: References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-15-git-send-email-alex.shi@linux.alibaba.com> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1594429136-20002-15-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="macroman" To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org, daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org, richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org Cc: =?UTF-8?Q?Mika_Penttil=c3=a4?= CkFkZCBhIFZNX1dBUk5fT04gZm9yIHRyYWNraW5nLiBhbmQgdXBkYXRlZCBjb21tZW50cyBmb3Ig dGhlIGNvZGUuCgpUaGFua3MKCi0tLQpGcm9tIGYxMzgxYTE1NDc2MjVhNjUyMTc3N2JmOTIzNTgy M2Q4ZmJkMDBkYWMgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZyb206IEFsZXggU2hpIDxhbGV4 LnNoaS1LUHNvRmJOczdHaXpyR0U1YlJxWUFnQy9HMks0ekRIZkBwdWJsaWMuZ21hbmUub3JnPgpE YXRlOiBGcmksIDEwIEp1bCAyMDIwIDE2OjU0OjM3ICswODAwClN1YmplY3Q6IFtQQVRDSCB2MTYg MTQvMjJdIG1tL3RocDogYWRkIHRhaWwgcGFnZXMgaW50byBscnUgYW55d2F5IGluCiBzcGxpdF9o dWdlX3BhZ2UoKQpNSU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNo YXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKU3BsaXRfaHVnZV9w YWdlKCkgbXVzdCBzdGFydCB3aXRoIFBhZ2VMUlUoaGVhZCksIGFuZCB3ZSBhcmUgaG9sZGluZyB0 aGUKbHJ1X2xvY2sgaGVyZS4gSWYgdGhlIGhlYWQgd2FzIGNsZWFyZWQgbHJ1IGJpdCB1bmV4cGVj dGVkLCB0cmFja2luZyBpdC4KClNpZ25lZC1vZmYtYnk6IEFsZXggU2hpIDxhbGV4LnNoaS1LUHNv RmJOczdHaXpyR0U1YlJxWUFnQy9HMks0ekRIZkBwdWJsaWMuZ21hbmUub3JnPgpDYzogS2lyaWxs IEEuIFNodXRlbW92IDxraXJpbGwtb0t3N2NJZEhIOGVMd3V0RzUwTHRHQUBwdWJsaWMuZ21hbmUu b3JnPgpDYzogQW5kcmV3IE1vcnRvbiA8YWtwbS1kZS90blhUZitKTHNmSERYdmJLdjNXRDJGUUpr KzgrYkBwdWJsaWMuZ21hbmUub3JnPgpDYzogSm9oYW5uZXMgV2VpbmVyIDxoYW5uZXMtZHJ1VWd2 bDBMQ05BZnVnUnBDNnU2d0BwdWJsaWMuZ21hbmUub3JnPgpDYzogTWF0dGhldyBXaWxjb3ggPHdp bGx5LXdFR0NpS0hlMkxxV1ZmZUF3QTd4SFFAcHVibGljLmdtYW5lLm9yZz4KQ2M6IEh1Z2ggRGlj a2lucyA8aHVnaGQtaHBJcXNENEFLbGZRVDBkWlIrQWxmQUBwdWJsaWMuZ21hbmUub3JnPgpDYzog TWlrYSBQZW50dGlsw6QgPG1pa2EucGVudHRpbGEtTVJzcjdkdGhBOVZXazBIdGlrM0ovd0BwdWJs aWMuZ21hbmUub3JnPgpDYzogbGludXgtbW0tQnczMU1hWktLczNZdGp2eVc2eURzZ0BwdWJsaWMu Z21hbmUub3JnCkNjOiBsaW51eC1rZXJuZWwtdTc5dXdYTDI5VFk3Nloyck01bUhYQUBwdWJsaWMu Z21hbmUub3JnCi0tLQogbW0vaHVnZV9tZW1vcnkuYyB8IDE2ICsrKysrKysrKystLS0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL21tL2h1Z2VfbWVtb3J5LmMgYi9tbS9odWdlX21lbW9yeS5jCmluZGV4IGQ4NjZiNmU0MzQz NC4uMjg1Mzg0NDQxOTdiIDEwMDY0NAotLS0gYS9tbS9odWdlX21lbW9yeS5jCisrKyBiL21tL2h1 Z2VfbWVtb3J5LmMKQEAgLTIzNDgsMTUgKzIzNDgsMTkgQEAgc3RhdGljIHZvaWQgbHJ1X2FkZF9w YWdlX3RhaWwoc3RydWN0IHBhZ2UgKmhlYWQsIHN0cnVjdCBwYWdlICpwYWdlX3RhaWwsCiAJVk1f QlVHX09OX1BBR0UoUGFnZUxSVShwYWdlX3RhaWwpLCBoZWFkKTsKIAlsb2NrZGVwX2Fzc2VydF9o ZWxkKCZscnV2ZWNfcGdkYXQobHJ1dmVjKS0+bHJ1X2xvY2spOwogCi0JaWYgKCFsaXN0KQotCQlT ZXRQYWdlTFJVKHBhZ2VfdGFpbCk7Ci0KLQlpZiAobGlrZWx5KFBhZ2VMUlUoaGVhZCkpKQotCQls aXN0X2FkZF90YWlsKCZwYWdlX3RhaWwtPmxydSwgJmhlYWQtPmxydSk7Ci0JZWxzZSBpZiAobGlz dCkgeworCWlmIChsaXN0KSB7CiAJCS8qIHBhZ2UgcmVjbGFpbSBpcyByZWNsYWltaW5nIGEgaHVn ZSBwYWdlICovCiAJCWdldF9wYWdlKHBhZ2VfdGFpbCk7CiAJCWxpc3RfYWRkX3RhaWwoJnBhZ2Vf dGFpbC0+bHJ1LCBsaXN0KTsKKwl9IGVsc2UgeworCQkvKgorCQkgKiBTcGxpdCBzdGFydCBmcm9t IFBhZ2VMUlUoaGVhZCksIGFuZCB3ZSBhcmUgaG9sZGluZyB0aGUKKwkJICogbHJ1X2xvY2suCisJ CSAqIERvIGEgd2FybmluZyBpZiB0aGUgaGVhZCdzIGxydSBiaXQgd2FzIGNsZWFyZWQgdW5leHBl Y3RlZC4KKwkJICovCisJCVZNX1dBUk5fT04oIVBhZ2VMUlUoaGVhZCkpOworCQlTZXRQYWdlTFJV KHBhZ2VfdGFpbCk7CisJCWxpc3RfYWRkX3RhaWwoJnBhZ2VfdGFpbC0+bHJ1LCAmaGVhZC0+bHJ1 KTsKIAl9CiB9CiAKLS0gCjEuOC4zLjEKCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BBDC433DF for ; Fri, 17 Jul 2020 09:31:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1A9CA2063A for ; Fri, 17 Jul 2020 09:31:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A9CA2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8ED508D002C; Fri, 17 Jul 2020 05:31:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89C898D0028; Fri, 17 Jul 2020 05:31:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78CB18D002C; Fri, 17 Jul 2020 05:31:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 6035A8D0028 for ; Fri, 17 Jul 2020 05:31:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1DB00183E4B7D for ; Fri, 17 Jul 2020 09:31:29 +0000 (UTC) X-FDA: 77047049898.10.burn69_04151e926f09 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id D2978507C3 for ; Fri, 17 Jul 2020 09:31:28 +0000 (UTC) X-HE-Tag: burn69_04151e926f09 X-Filterd-Recvd-Size: 3732 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Jul 2020 09:31:27 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07425;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0U2zo7Ok_1594978280; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U2zo7Ok_1594978280) by smtp.aliyun-inc.com(127.0.0.1); Fri, 17 Jul 2020 17:31:21 +0800 Subject: Re: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page() From: Alex Shi To: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name Cc: =?UTF-8?Q?Mika_Penttil=c3=a4?= References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-15-git-send-email-alex.shi@linux.alibaba.com> Message-ID: Date: Fri, 17 Jul 2020 17:30:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1594429136-20002-15-git-send-email-alex.shi@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: D2978507C3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add a VM_WARN_ON for tracking. and updated comments for the code. Thanks --- >From f1381a1547625a6521777bf9235823d8fbd00dac Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Fri, 10 Jul 2020 16:54:37 +0800 Subject: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page() MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Split_huge_page() must start with PageLRU(head), and we are holding the lru_lock here. If the head was cleared lru bit unexpected, tracking it. Signed-off-by: Alex Shi Cc: Kirill A. Shutemov Cc: Andrew Morton Cc: Johannes Weiner Cc: Matthew Wilcox Cc: Hugh Dickins Cc: Mika Penttil=C3=A4 Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/huge_memory.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index d866b6e43434..28538444197b 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2348,15 +2348,19 @@ static void lru_add_page_tail(struct page *head, = struct page *page_tail, VM_BUG_ON_PAGE(PageLRU(page_tail), head); lockdep_assert_held(&lruvec_pgdat(lruvec)->lru_lock); =20 - if (!list) - SetPageLRU(page_tail); - - if (likely(PageLRU(head))) - list_add_tail(&page_tail->lru, &head->lru); - else if (list) { + if (list) { /* page reclaim is reclaiming a huge page */ get_page(page_tail); list_add_tail(&page_tail->lru, list); + } else { + /* + * Split start from PageLRU(head), and we are holding the + * lru_lock. + * Do a warning if the head's lru bit was cleared unexpected. + */ + VM_WARN_ON(!PageLRU(head)); + SetPageLRU(page_tail); + list_add_tail(&page_tail->lru, &head->lru); } } =20 --=20 1.8.3.1