From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0A5C433E0 for ; Wed, 1 Jul 2020 22:51:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E61FF2082F for ; Wed, 1 Jul 2020 22:51:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="MNGOk6aS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726121AbgGAWvk (ORCPT ); Wed, 1 Jul 2020 18:51:40 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:52667 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbgGAWvk (ORCPT ); Wed, 1 Jul 2020 18:51:40 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1593643899; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Gzk6MArs2xkSxAn767zjaSgf4SaIL+y96yccCcZqcCg=; b=MNGOk6aS4GEmqeli6tR8+RFKJfn5ph/h/q4HbR20GGDchXCtCZzkufvTpRuznZUYiBgVKjnH /i0o1PPVJdfjOJALR7FsOLijMM968Eo6NPjCSOTAcf+l3i51Ijv7fY7yw1eurf81LpldU7gw WKyQ18X1LgQX60aCxTUpK55NCXY= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n20.prod.us-east-1.postgun.com with SMTP id 5efd136c356bcc26abe21d9c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 01 Jul 2020 22:51:24 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A7E7BC433A0; Wed, 1 Jul 2020 22:51:22 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id EFE0FC433C6; Wed, 1 Jul 2020 22:51:21 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 01 Jul 2020 15:51:21 -0700 From: abhinavk@codeaurora.org To: Rob Clark Cc: dri-devel@lists.freedesktop.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Drew Davenport , Sam Ravnborg , Hongbo Yao , Kalyan Thota , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH] drm/msm: ratelimit crtc event overflow error In-Reply-To: <20200701203602.1272157-1-robdclark@gmail.com> References: <20200701203602.1272157-1-robdclark@gmail.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-07-01 13:36, Rob Clark wrote: > From: Rob Clark > > This can happen a lot when things go pear shaped. Lets not flood dmesg > when this happens. > > Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index e15b42a780e0..969d95aa873c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -389,7 +389,7 @@ static void dpu_crtc_frame_event_cb(void *data, u32 > event) > spin_unlock_irqrestore(&dpu_crtc->spin_lock, flags); > > if (!fevent) { > - DRM_ERROR("crtc%d event %d overflow\n", crtc->base.id, event); > + DRM_ERROR_RATELIMITED("crtc%d event %d overflow\n", crtc->base.id, > event); > return; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C14C433E0 for ; Wed, 1 Jul 2020 22:51:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C5F8207E8 for ; Wed, 1 Jul 2020 22:51:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="NlYyDJW9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C5F8207E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BE216EA0B; Wed, 1 Jul 2020 22:51:26 +0000 (UTC) Received: from mail29.static.mailgun.info (mail29.static.mailgun.info [104.130.122.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id B71B86EA0B for ; Wed, 1 Jul 2020 22:51:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1593643884; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Gzk6MArs2xkSxAn767zjaSgf4SaIL+y96yccCcZqcCg=; b=NlYyDJW9QhsaC5/qopdCdTXKWo9nUoGkmj7aNxiAp5xcf8rB7rmaW7iGygk44jaHd5gkFPvM 4avnTf6K7Y1qearEwJrI5r1mjYQSrG9qe13QDPLrvwLkaKAi+xWgACTIJb+FR5NG7dJJejqo yyVk3z5C4ayUvYooXdfGEqalBWQ= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n13.prod.us-east-1.postgun.com with SMTP id 5efd136ba3d8a44743347bf8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 01 Jul 2020 22:51:23 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9D96CC43395; Wed, 1 Jul 2020 22:51:22 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id EFE0FC433C6; Wed, 1 Jul 2020 22:51:21 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 01 Jul 2020 15:51:21 -0700 From: abhinavk@codeaurora.org To: Rob Clark Subject: Re: [PATCH] drm/msm: ratelimit crtc event overflow error In-Reply-To: <20200701203602.1272157-1-robdclark@gmail.com> References: <20200701203602.1272157-1-robdclark@gmail.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , freedreno@lists.freedesktop.org, David Airlie , Sam Ravnborg , linux-arm-msm@vger.kernel.org, Hongbo Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kalyan Thota , Drew Davenport , Sean Paul , linux-arm-msm-owner@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-07-01 13:36, Rob Clark wrote: > From: Rob Clark > > This can happen a lot when things go pear shaped. Lets not flood dmesg > when this happens. > > Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index e15b42a780e0..969d95aa873c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -389,7 +389,7 @@ static void dpu_crtc_frame_event_cb(void *data, u32 > event) > spin_unlock_irqrestore(&dpu_crtc->spin_lock, flags); > > if (!fevent) { > - DRM_ERROR("crtc%d event %d overflow\n", crtc->base.id, event); > + DRM_ERROR_RATELIMITED("crtc%d event %d overflow\n", crtc->base.id, > event); > return; > } _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel