From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76ABDC433FE for ; Mon, 21 Nov 2022 15:10:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5C57C852BE; Mon, 21 Nov 2022 16:10:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="BTh2fBmy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6B306852BE; Mon, 21 Nov 2022 16:10:13 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0623.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::623]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C6EDF852BE for ; Mon, 21 Nov 2022 16:10:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fCHojRKFptb+Rhmtnud/gDx8vpmrVyVygYFplbWT/iG1REkXjY1Grkxbdk/802GFSxG5LhmqsArC3xYRyxISoNn+VFNyg1yNT45SkyWZ4BIc67xb8zMi7Pg5BLR7EVFSSXgyHf1T3qNkeBykDYVSkiaf9hL7R9Zu2UPxMljio9vJ05iVeHIp7LGDkSY+BxHzp+BH/W6tnIJ8O0PAJ8o7sgt/hrYtWjaKw34ZNRcWtnj/7U+1dQqpGkq4c9vBNkY1wzcfHs8rMuYFSC4Vzgs1INpcs0aHF39Wf6GFK3JFRXigOD3N6+AYmirbpzbp8Y01kRLjVoPZ6vwtPRv1bRmHYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7yhLwOzYnBT65Rg20F/wYixYH5zmfKUyD2GsE7m9Bm4=; b=RgYehYPZZPR+J0bE8p/ETqbJPXR8Ud1j6lOxJCxGG+6v+W/HAnPWbIRyokEbwuHZeqs7yz/L1FqRWNX5HtNkcAkqatAYyY8fIngztCe9ej7LjnylfRJbMtptd4GsTWJz9600jwGCcwC9306WSrjeXbMrx3ilsbLghomIVGp0tgKd5753Hm6ecGWMnp2rV8sJsQ4Cp9lrTTiTLceflldUnRYU1HxhkrFzAGtH/Lo9yCB6Qknjwgd8y5nY54WQT7LjJBKGoDPLPQj5H+QT15+iAg7S4RKsq7V8MEmq0qgrNs2k+fNmRLwkiKZ9bY7Za3n/W/Hk7Nwq8RKjNxRTPIs8+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yhLwOzYnBT65Rg20F/wYixYH5zmfKUyD2GsE7m9Bm4=; b=BTh2fBmy0p6KI8ZOqqoIFHwlY9rwMgAIoCGpBFlP6S7+pPeTilUKDk0R1avdnoONfLmchiX5egqL+p8r2To4MjCLjILIdJEGf6IepDMCXC0RRLLVZRZIyKnvLkOf4t0xl7Knwl/QGfgpDBmfpa4wT3wPm1CQg6TrmkFbYNf8aKoenlyC/qB8w+OqSbCEZDyuJ66p9guizWo/vJk8ZhHwHfDaQw4tvOEYdAbFjS8ISTJOPuy4DKNK0ul2540gtT8DzbTPJEh8olkKamHnU4ogwySH8oaxSy0CBi9wfY4wzjVNGJMJObIw0HTYb1bKTorK9ggEAb6hbUnCv6481vPGqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB9PR03MB8847.eurprd03.prod.outlook.com (2603:10a6:10:3dd::13) by PA4PR03MB7021.eurprd03.prod.outlook.com (2603:10a6:102:e1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 15:10:03 +0000 Received: from DB9PR03MB8847.eurprd03.prod.outlook.com ([fe80::2b95:1fe4:5d8f:22fb]) by DB9PR03MB8847.eurprd03.prod.outlook.com ([fe80::2b95:1fe4:5d8f:22fb%7]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 15:10:03 +0000 Message-ID: Date: Mon, 21 Nov 2022 10:09:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned" Content-Language: en-US To: Gary Bisson Cc: u-boot@lists.denx.de, qianfanguijin@163.com, Troy Kisky , Peng Fan , sjg@chromium.org References: <20221118121323.4009193-1-gary.bisson@boundarydevices.com> <79465afa-3528-7e1b-9d15-1258ef327f74@seco.com> From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR02CA0070.namprd02.prod.outlook.com (2603:10b6:207:3d::47) To DB9PR03MB8847.eurprd03.prod.outlook.com (2603:10a6:10:3dd::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR03MB8847:EE_|PA4PR03MB7021:EE_ X-MS-Office365-Filtering-Correlation-Id: 820086a1-7870-4643-b53b-08dacbd275d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UuslEWnXUQqdbXnPtPsNqgexQAD03PZGMde0M4UlEfOyjlJmpBT9uEXDqnDOFCLYS8/IDAl38Lgig38t98iE0BQ3YqcAO4JFsYL0BBo/6iEi4/LnQY7DkJm0Da+qq3ghPxbu0Vl+BDHVSZtQckYcSXWUphRX5kYvMjTOLaVRTK2kzduXOn1XCMsianvVXDluXVqTH+LIHGSnlJyUPyg/w+51fI94qKoWSdXKMJtg8eIBqwaY+JU3F+89er/tVKAue0+y5RkovoAKQ4JJMdQz0W73JiQIe4SpV8KwCHyi3nrSr7XaSnD/E7gWPx5YzpeZTCPUVVPWsLyOZd9iyLUp0cHuH/0ZhetHVfp/Y7PZ80q2Wu6j1pZPr+EPu9/S8kLjFyA3sA1GbXaNHSyqH87HpoNS5ekppCUSGu55SpWnO9r62FuRHScfABYZA/MLvPC9xi2TYb1U0EkUmaAD1c94wHkBonIQdmbUspijwy2XPQm6Pz8ctWggvYoPbSiAMDMQrOcHh3P3aRuyWqZEUWY+9huZoL5aPKeqRJVEKVB6kmF+C0un5evhRzFi8xCpL9Llf1QvxtP1kzsOMBqXwYyaXUOxuNSgTiFwI/3m9S0XpPCMCDbEpgjBTvEP7Fr682SuhKQXsAiW2KRoXVyT96d0oq3cMD1bxl+UC+K52K9pCnp0mwGXNYFTMAUcqiK588sC5k8/WRarWlTiBwfYFBZFQPGlMSU2me2nKdh9kA9/snbaf911MXso3+Do++bTlu9UHpzxssU+8lymEuBX9zKqNw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR03MB8847.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(366004)(136003)(396003)(39850400004)(451199015)(6486002)(36756003)(478600001)(44832011)(38100700002)(38350700002)(31696002)(6506007)(86362001)(52116002)(6666004)(53546011)(26005)(6512007)(6916009)(41300700001)(54906003)(8676002)(316002)(8936002)(4326008)(66476007)(66556008)(66946007)(5660300002)(31686004)(2616005)(186003)(83380400001)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzFBWHhTaGhpUmZ3OGRTbEVoTGpYU1BYQnJIY1RENUMrV2lxSWVGZmNKK2h6?= =?utf-8?B?bUxtUWN5djMzOFNNODM0bTVpTUxwRU5FYVFLNkRSc0tJZm9oK2Y5MVRlM0dV?= =?utf-8?B?Q3VhblptdTlUTk0zMmgrSTEzNm5OMXZ2VElRbjNTSWdua3F6cUh1TzJncW14?= =?utf-8?B?MlZ1Y0VmVXdWUjdBcHVXM1pLbkxSTXU1dGtPU1pQTGNNVG12REFnSU4yVmdN?= =?utf-8?B?YVF6dnhySDFMYllXamwzbDdHUWlxZENaMG9jK1dheUcybVhGZzNrMXExQncw?= =?utf-8?B?WkJtb1RZTVRNdXF3TkZvU0puMHNSZkc1MFF4YXdWaDhORVVBVFBIZGtYTFlr?= =?utf-8?B?OUhYOG5MTnFIVmdZR3FvbjhHTTNuTDdkUnhJSVZlWFZxajhaaFArNDl5anBk?= =?utf-8?B?OVpJeXNuaXFkMG42R0huWjJGYzNmaHRXSVJMSzcwajVkVkdURkdZaG9yMGtT?= =?utf-8?B?VC91YTBTYkFlSk1RdzZnejFJVUwzQXRiOG04L2VrWmo1ZHFUVXhwaGluWkg3?= =?utf-8?B?SkVQWm52RCtJaHZtTkg1VFJMeGl2aHhJK0pRMHFlQWNsL2d1cHJzd1c5VXZV?= =?utf-8?B?clhrS2dXYnJYUGJudUNwQ01GcGZzVnNmYytYbWtLSDRUY01YUWFBa1VYaEph?= =?utf-8?B?Q1lpdldEK3dVc05KamRjazF1b2ZqUFVFekRMOHZoVUNOcEREa3QzZjZwRENH?= =?utf-8?B?cS9ZWWxPM2l2SmxhN1laK20rZTZhZW9JcTlLLzFUU2NJUUo1R0RNOVIrOWg5?= =?utf-8?B?VTBLUkhXNHR2V0ZDSlc2QlpKVUZBUExqZlAzODkrYVBkcVRMcExhNk5qdVM1?= =?utf-8?B?ZmZidUgxcVZQa0czODhMc0c3VExZcWpmRUtzWTdrd2tKbFA1NUZjVXBBa2o0?= =?utf-8?B?K1Zrczl0dVdadk1heXJrS2RLQzVMV0pFNUE3UFlqSERKaHo0NGN3Qjc5dFVy?= =?utf-8?B?VXlrK0lUalNRMzlwdjdPN2RZam1SK3JZVnBBbWY1VHBFcGE2TWhTRWQwR01H?= =?utf-8?B?ckQwbXM0ank4SUovRFcrM052UVBIUXZJb05pYldScXl1cUNzTXY4djJZL0dR?= =?utf-8?B?MXpmWUZuTnhZTXlBS3RDU0twQWVnRlJ3RDRKOXVNK0NsL2JwVFJxYnk2dm10?= =?utf-8?B?RFh6STY5Uk5kMkNodjF2TUhzQ0pUczBNaVlLcitWam1SbHZocG9acDFjOUlQ?= =?utf-8?B?eEtocWx6SEF5bG85TEdkbUxjbTJjNE1paDRTbkQ1cHMydkxyV0dwK0doSUMw?= =?utf-8?B?VHBYZWxTcE1ualhUY0MrTGNrMURQNUpTOHdqYzRnU2dlbldWZzV0aElPUDJP?= =?utf-8?B?eFJLOTJYMWlVL1dZdGN5UWo5UlNBZk5ia2lhWmc2Z251ZmU2YzdScU1acE1Q?= =?utf-8?B?ckFHLzN6c3ZxclpINjVMTnYvaFlXbkw5QVNTbVprcjFKSSsrWHNUMWlTN0ZM?= =?utf-8?B?ZWxpUDI3VEJXMXdKUk5yQlRWQnVyZmdNQVV1WnJ0Q1lkZk02KzRBVjh2cE9F?= =?utf-8?B?UDY5dWpxQjdRVmp4ejJRNHRTWTFjYkVrbk8xblE1UXJiZmY5aVJwQjBLdzdn?= =?utf-8?B?VEpRd1pTYWNSZTFXZk1yTVdKelBqVDQxeGZ5QmpyQzg2VndYaHlrYkljY2lo?= =?utf-8?B?RzJrQklOQnFrUGRhWWg3Qm1Za1N4NjdHRktON3BNcndJRW96Qk50YWIyNjBY?= =?utf-8?B?R25sb2diQk5qbE12L3FXRnlkTC9OWUIxNDQvbnhrbERUcmF4WFFqRS9Dbnh6?= =?utf-8?B?SmVvZFJPeHB4Ui9kZHA1SWUwSlJhbDdnbjhOZHJOZ2hrOEhTbTMwR1J5YWFY?= =?utf-8?B?b3JZakgzVkNXNFdxckdFTTVvRytjd2VaNEg2d1JzUGJnL3ZrcmNVYzZEdFEw?= =?utf-8?B?UnlqWTd6ZHFSRWJ3SHU4ZjVzRm53d3ZLT3ovZXVoVkFBOFZabEg5a3lCQjJE?= =?utf-8?B?U3VzM1IyVXB1NFN5bkJvYXdHT29MK3lJK0h3NGEyZE5DZDZVVEhxcCtFY2Vu?= =?utf-8?B?Y0NIQ0QvZlROT1VIKzNIc2sxNDJ6MFFIbytNdktSTGpyQlh1Z0hWSnJweS9X?= =?utf-8?B?eGo4MzZLUXJSMlExam5HazdmNmFPN3BGTnZsY3pOSWlYKzdDTjBCNVZrejFs?= =?utf-8?B?YURwMnI4azFKRzR2dHlGQUdpSDFqRVp6dzlMVnZhbTBuZDAwenl5WW1ZUFFR?= =?utf-8?B?emc9PQ==?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 820086a1-7870-4643-b53b-08dacbd275d5 X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 15:10:02.9353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nDrZv2fGMnaISnFyXi4RID1fACkNh2PHKyk3AAGSmYGSS32kf6YtrsLSj/u1pnhse9FStwtpSjawNlhpWiu3kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7021 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/21/22 09:50, Gary Bisson wrote: > Hi, > > On Fri, Nov 18, 2022 at 10:36:58AM -0500, Sean Anderson wrote: >> On 11/18/22 07:13, Gary Bisson wrote: >> > This reverts commit 62649165cb02ab95b57360bb362886935f524f26. >> > >> > The patch decreased the write performance quite a bit. >> > Here is an example on an i.MX 8M Quad platform. >> > - Before the revert: >> > Sending sparse 'vendor' 1/2 (516436 KB) OKAY [ 5.113s] >> > Writing 'vendor' OKAY [128.335s] >> > Sending sparse 'vendor' 2/2 (76100 KB) OKAY [ 0.802s] >> > Writing 'vendor' OKAY [ 27.902s] >> > - After the revert: >> > Sending sparse 'vendor' 1/2 (516436 KB) OKAY [ 5.310s] >> > Writing 'vendor' OKAY [ 18.041s] >> > Sending sparse 'vendor' 2/2 (76100 KB) OKAY [ 1.244s] >> > Writing 'vendor' OKAY [ 2.663s] >> > >> > Considering that the patch only moves buffer around to avoid a warning >> > message about misaligned buffers, let's keep the best performances. >> >> So what is the point of this warning? > > Well the warning does say something true that the cache operation is not > aligned. Better ask Simon as he's the one who changed the print from a > debug to warn_non_spl one: > bcc53bf0958 arm: Show cache warnings in U-Boot proper only > > BTW, in my case I couldn't see the misaligned messages, yet I saw the > performance hit described above. Maybe it is better to keep this as a Kconfig? Some arches may support unaligned access but others may not. I wonder if we have something like this already. --Seam