From: Marc Zyngier <maz@misterjones.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: <socketcan-core@lists.berlios.de>, <netdev@vger.kernel.org>,
Christian Pellegrin <chripell@fsfe.org>
Subject: Re: [PATCH 6/8] can: mcp251x: Don't use pdata->model for chip selection anymore
Date: Mon, 18 Oct 2010 15:49:11 +0200 [thread overview]
Message-ID: <d4c9d3f3d2843bd9cdb4cbb6a75236ce@localhost> (raw)
In-Reply-To: <1287408674-15412-7-git-send-email-mkl@pengutronix.de>
On Mon, 18 Oct 2010 15:31:12 +0200, Marc Kleine-Budde <mkl@pengutronix.de>
wrote:
> Since commit e446630c960946b5c1762e4eadb618becef599e7, i.e. v2.6.35-rc1,
> the mcp251x chip model can be selected via the modalias member in the
> struct spi_board_info. The driver stores the actual model in the
> struct mcp251x_platform_data.
>
> From the driver point of view the platform_data should be read only.
> Since all in-tree users of the mcp251x have already been converted to
> the modalias method, this patch moves the "model" member from the
> struct mcp251x_platform_data to the driver's private data structure.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: Christian Pellegrin <chripell@fsfe.org>
> Cc: Marc Zyngier <maz@misterjones.org>
Acked-by: Marc Zyngier <maz@misterjones.org>
--
Who you jivin' with that Cosmik Debris?
next prev parent reply other threads:[~2010-10-18 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 13:31 [PATCH V3 0/8] can: mcp251x: fix and optimize driver Marc Kleine-Budde
[not found] ` <1287408674-15412-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-10-18 13:31 ` [PATCH 1/8] can: mcp251x: fix NOHZ local_softirq_pending 08 warning Marc Kleine-Budde
2010-10-18 13:31 ` [PATCH 2/8] can: mcp251x: increase rx_errors on overflow, not only rx_over_errors Marc Kleine-Budde
2010-10-18 13:31 ` [PATCH 3/8] can: mcp251x: allow to read two registers in one spi transfer Marc Kleine-Budde
2010-10-18 13:31 ` [PATCH 4/8] can: mcp251x: read-modify-write eflag only when needed Marc Kleine-Budde
2010-10-18 14:12 ` [PATCH V3 0/8] can: mcp251x: fix and optimize driver David Miller
2010-10-18 13:31 ` [PATCH 5/8] can: mcp251x: write intf only when needed Marc Kleine-Budde
2010-10-18 13:31 ` [PATCH 6/8] can: mcp251x: Don't use pdata->model for chip selection anymore Marc Kleine-Budde
2010-10-18 13:49 ` Marc Zyngier [this message]
2010-10-18 14:14 ` Marc Kleine-Budde
2010-10-18 13:31 ` [PATCH 7/8] can: mcp251x: define helper functions mcp251x_is_2510, mcp251x_is_2515 Marc Kleine-Budde
2010-10-18 13:31 ` [PATCH 8/8] can: mcp251x: optimize 2515, rx int gets cleared automatically Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4c9d3f3d2843bd9cdb4cbb6a75236ce@localhost \
--to=maz@misterjones.org \
--cc=chripell@fsfe.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.