From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Geliang Tang <geliang.tang@suse.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] selftests: mptcp: fix a mp_fail test warning
Date: Tue, 3 May 2022 18:35:35 +0200 [thread overview]
Message-ID: <d4d2dca7-bf7b-c45c-ef1d-d8878465cf24@tessares.net> (raw)
In-Reply-To: <6dd3d1ae0042025c2b4b4fde0e341562c200024a.1651537116.git.geliang.tang@suse.com>
Hi Geliang,
On 03/05/2022 02:19, Geliang Tang wrote:
> Older version tc command (iprout2 5.3) shows actions in multiple lines,
> not a single line. Then the following unexpected MP_FAIL selftest output
> occurs:
>
> file received by server has inverted byte at 169
> ./mptcp_join.sh: line 1277: [: [{"total acts":1},{"actions":[{"order":0 pedit ,"control_action":{"type":"pipe"}keys 1
> index 1 ref 1 bind 1,"installed":0,"last_used":0
> key #0 at 148: val ff000000 mask ffffffff
> 5: integer expression expected
> 001 Infinite map syn[ ok ] - synack[ ok ] - ack[ ok ]
> sum[ ok ] - csum [ ok ]
> ftx[ ok ] - failrx[ ok ]
> rtx[ ok ] - rstrx [ ok ]
> itx[ ok ] - infirx[ ok ]
> ftx[ ok ] - failrx[ ok ] invert
>
> This patch adds a 'grep' before 'sed' to fix this.
Thank you for the patch!
Now in our tree (fix for net-next) with my RvB tag and without the
iproute2 typo:
New patches for t/upstream:
- d691758ed81c: selftests: mptcp: fix a mp_fail test warning
- Results: c3f5d94e8dc4..9cac72edfb62 (export)
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220503T163309
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2022-05-03 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 0:19 [PATCH mptcp-next] selftests: mptcp: fix a mp_fail test warning Geliang Tang
2022-05-03 1:53 ` selftests: mptcp: fix a mp_fail test warning: Tests Results MPTCP CI
2022-05-03 13:49 ` [PATCH mptcp-next] selftests: mptcp: fix a mp_fail test warning Geliang Tang
2022-05-03 16:35 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4d2dca7-bf7b-c45c-ef1d-d8878465cf24@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.