From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manu Gautam Subject: Re: [PATCH v3 14/16] phy: Add notify_speed callback Date: Fri, 29 Dec 2017 09:54:28 +0530 Message-ID: References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-15-git-send-email-mgautam@codeaurora.org> <082d2ca8-21dc-878f-c668-a76872a7ea92@ti.com> <5b67c348-4ec9-58ca-05ed-8b93bed77efb@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, "open list:GENERIC PHY FRAMEWORK" List-Id: linux-arm-msm@vger.kernel.org Hi, On 12/28/2017 4:34 PM, Kishon Vijay Abraham I wrote: > Hi, > [snip] > >>> I'd prefer adding modes in enum phy_mode according to speed and using phy_set_mode. >> yeah, that also seems good idea. How about something like this: >> >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/phy.h >> @@ -23,12 +23,16 @@ >> struct phy; >> >> enum phy_mode { >> - PHY_MODE_INVALID, >> - PHY_MODE_USB_HOST, >> - PHY_MODE_USB_DEVICE, >> - PHY_MODE_USB_OTG, >> - PHY_MODE_SGMII, >> - PHY_MODE_10GKR, >> + PHY_MODE_INVALID = 0, >> + PHY_MODE_USB_HOST = BIT(0), >> + PHY_MODE_USB_DEVICE = BIT(1), >> + PHY_MODE_USB_OTG, = BIT(2), >> + PHY_MODE_SGMII = BIT(3), >> + PHY_MODE_10GKR = BIT(4), >> + PHY_MODE_USB_LS = BIT(5), >> + PHY_MODE_USB_FS = BIT(6), >> + PHY_MODE_USB_HS = BIT(7), >> + PHY_MODE_USB_SS = BIT(8), >> }; >> >> >> This way I don't need to duplicate USB speed enums for host/device or otg modes. > no.. let's keep enum. It's lot more cleaner IMO. In that case all PHY drivers would need to consider these speed enums. E.g. if (mode == HOST) check in PHY driver would need to be changed to: if (mode == HOST || mode == HOST_LS || mode == HOST_FS || mode == HOST_HS ||     mode == HOST_SS This looks clumsy. Where as if bits to used then there is no need for such changes. > > Thanks > Kishon > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,14/16] phy: Add notify_speed callback From: Manu Gautam Message-Id: Date: Fri, 29 Dec 2017 09:54:28 +0530 To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, "open list:GENERIC PHY FRAMEWORK" List-ID: SGksCgoKT24gMTIvMjgvMjAxNyA0OjM0IFBNLCBLaXNob24gVmlqYXkgQWJyYWhhbSBJIHdyb3Rl Ogo+IEhpLAo+CltzbmlwXQo+Cj4+PiBJJ2QgcHJlZmVyIGFkZGluZyBtb2RlcyBpbiBlbnVtIHBo eV9tb2RlIGFjY29yZGluZyB0byBzcGVlZCBhbmQgdXNpbmcgcGh5X3NldF9tb2RlLgo+PiB5ZWFo LCB0aGF0IGFsc28gc2VlbXMgZ29vZCBpZGVhLiBIb3cgYWJvdXQgc29tZXRoaW5nIGxpa2UgdGhp czoKPj4KPj4gLS0tIGEvaW5jbHVkZS9saW51eC9waHkvcGh5LmgKPj4gKysrIGIvaW5jbHVkZS9s aW51eC9waHkvcGh5LmgKPj4gQEAgLTIzLDEyICsyMywxNiBAQAo+PiAgc3RydWN0IHBoeTsKPj4g IAo+PiAgZW51bSBwaHlfbW9kZSB7Cj4+IC0JUEhZX01PREVfSU5WQUxJRCwKPj4gLQlQSFlfTU9E RV9VU0JfSE9TVCwKPj4gLQlQSFlfTU9ERV9VU0JfREVWSUNFLAo+PiAtCVBIWV9NT0RFX1VTQl9P VEcsCj4+IC0JUEhZX01PREVfU0dNSUksCj4+IC0JUEhZX01PREVfMTBHS1IsCj4+ICsJUEhZX01P REVfSU5WQUxJRAk9IDAsCj4+ICsJUEhZX01PREVfVVNCX0hPU1QJPSBCSVQoMCksCj4+ICsJUEhZ X01PREVfVVNCX0RFVklDRQk9IEJJVCgxKSwKPj4gKwlQSFlfTU9ERV9VU0JfT1RHLAk9IEJJVCgy KSwKPj4gKwlQSFlfTU9ERV9TR01JSQkJPSBCSVQoMyksCj4+ICsJUEhZX01PREVfMTBHS1IJCT0g QklUKDQpLAo+PiArCVBIWV9NT0RFX1VTQl9MUwkJPSBCSVQoNSksCj4+ICsJUEhZX01PREVfVVNC X0ZTCQk9IEJJVCg2KSwKPj4gKwlQSFlfTU9ERV9VU0JfSFMJCT0gQklUKDcpLAo+PiArCVBIWV9N T0RFX1VTQl9TUwkJPSBCSVQoOCksCj4+ICB9Owo+Pgo+Pgo+PiBUaGlzIHdheSBJIGRvbid0IG5l ZWQgdG8gZHVwbGljYXRlIFVTQiBzcGVlZCBlbnVtcyBmb3IgaG9zdC9kZXZpY2Ugb3Igb3RnIG1v ZGVzLgo+IG5vLi4gbGV0J3Mga2VlcCBlbnVtLiBJdCdzIGxvdCBtb3JlIGNsZWFuZXIgSU1PLgoK SW4gdGhhdCBjYXNlIGFsbCBQSFkgZHJpdmVycyB3b3VsZCBuZWVkIHRvIGNvbnNpZGVyIHRoZXNl IHNwZWVkIGVudW1zLiBFLmcuCgppZiAobW9kZSA9PSBIT1NUKSBjaGVjayBpbiBQSFkgZHJpdmVy IHdvdWxkIG5lZWQgdG8gYmUgY2hhbmdlZCB0bzoKaWYgKG1vZGUgPT0gSE9TVCB8fCBtb2RlID09 IEhPU1RfTFMgfHwgbW9kZSA9PSBIT1NUX0ZTIHx8IG1vZGUgPT0gSE9TVF9IUyB8fArCoCDCoCBt b2RlID09IEhPU1RfU1MKClRoaXMgbG9va3MgY2x1bXN5LgpXaGVyZSBhcyBpZiBiaXRzIHRvIHVz ZWQgdGhlbiB0aGVyZSBpcyBubyBuZWVkIGZvciBzdWNoIGNoYW5nZXMuCgo+Cj4gVGhhbmtzCj4g S2lzaG9uCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGlu ZSAidW5zdWJzY3JpYmUgbGludXgtYXJtLW1zbSIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2Ug dG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0 dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=