All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mat Martineau <martineau@kernel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: [PATCH mptcp-net 0/2] mptcp: options: avoid printing uninit data
Date: Wed, 9 Sep 2026 08:51:22 -0700 (PDT)	[thread overview]
Message-ID: <d4f8a020-8cce-d760-4625-adafb26d9ede@kernel.org> (raw)
In-Reply-To: <20260908-mptcp-opt-read-debug-v1-0-b3e74549b6f6@kernel.org>

On Tue, 8 Sep 2026, Matthieu Baerts (NGI0) wrote:

> When parsing the MPTCP suboptions, some pr_debug() might read and print
> uninit values.
>
> That's mostly harmless, but that's also confusing. Fixing that also
> avoids some tools to complain about accessing unint data.
>
> So read these fields only if they have been set.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (2):
>      mptcp: options: mpc: avoid printing uninit data
>      mptcp: options: dss: avoid printing uninit csum
>
> net/mptcp/options.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
> ---
> base-commit: a59eb98e30b7db5fa1cc7cd5343ad387bced3ae0
> change-id: 20260908-mptcp-opt-read-debug-d818ab97c05e

Thanks Matthieu, series LGTM:

Reviewed-by: Mat Martineau <martineau@kernel.org>


      parent reply	other threads:[~2026-09-09 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 17:07 [PATCH mptcp-net 0/2] mptcp: options: avoid printing uninit data Matthieu Baerts (NGI0)
2026-09-08 17:07 ` [PATCH mptcp-net 1/2] mptcp: options: mpc: " Matthieu Baerts (NGI0)
2026-09-08 17:07 ` [PATCH mptcp-net 2/2] mptcp: options: dss: avoid printing uninit csum Matthieu Baerts (NGI0)
2026-09-08 18:00 ` [PATCH mptcp-net 0/2] mptcp: options: avoid printing uninit data MPTCP CI
2026-09-09 15:51 ` Mat Martineau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4f8a020-8cce-d760-4625-adafb26d9ede@kernel.org \
    --to=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.