From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 205B8CCF9FF for ; Fri, 31 Oct 2025 09:30:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CF590416DC; Fri, 31 Oct 2025 09:30:11 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id GNF-HWoVdJzS; Fri, 31 Oct 2025 09:30:11 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 08061416EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1761903011; bh=dJCHY1xD4kMzxCb5bZ79VDVwPE90+O5Z/44h0qgKOvI=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JMnwHxTuuQIjneTELq81qBF5NRKi38ZmuzuxTknszjd+XM6/8DjKwnBB2u8syYafU ToXOKbv8QJUwKlKtWrrQXU2k8UakPYK8MJmoFcc5cN0ud+fXUXRv+E9dWx982H35tS FcObC/ZYZagUoM+sNnybwK0AnMVYmHnRWtj//5K/8YFbG4pxwlg58vtBzl/H3D4CPN iYA1oEC37JHJScc3koEI35Jq0W7A/5GuYUbIP989Oulwd28FqUx1GI6HCoI8D5ccuJ MbQk1AWfbaEC9oQFwrL5GQtpJ4sR8sVIodwSzf1rc+PPJa825B5VQgwT3ZWRIFzY/E R85l4oZM4dn7g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 08061416EF; Fri, 31 Oct 2025 09:30:11 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 55C68160 for ; Fri, 31 Oct 2025 09:30:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 47C91816E2 for ; Fri, 31 Oct 2025 09:30:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TvVAxmDhAHDg for ; Fri, 31 Oct 2025 09:30:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.8; helo=mgamail.intel.com; envelope-from=dawid.osuchowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 31EA083506 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 31EA083506 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by smtp1.osuosl.org (Postfix) with ESMTPS id 31EA083506 for ; Fri, 31 Oct 2025 09:30:07 +0000 (UTC) X-CSE-ConnectionGUID: /ZFUl55oQe2eeHIU/+RgFw== X-CSE-MsgGUID: BWuSyLenTf2RX3QLjtpzqA== X-IronPort-AV: E=McAfee;i="6800,10657,11598"; a="81690555" X-IronPort-AV: E=Sophos;i="6.19,269,1754982000"; d="scan'208";a="81690555" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2025 02:30:07 -0700 X-CSE-ConnectionGUID: S5PZvJ/MTP+l9A3gvPAJwQ== X-CSE-MsgGUID: hTCdttE1SA2eh0rICcHl5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,269,1754982000"; d="scan'208";a="185465564" Received: from soc-5cg4396xfb.clients.intel.com (HELO [172.28.180.29]) ([172.28.180.29]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2025 02:30:05 -0700 Message-ID: Date: Fri, 31 Oct 2025 10:29:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: "Sanigani, SarithaX" , "intel-wired-lan@lists.osuosl.org" Cc: "Fijalkowski, Maciej" , "Lobakin, Aleksander" , "Keller, Jacob E" , "Zaremba, Larysa" , "Kitszel, Przemyslaw" , "Nguyen, Anthony L" , "Kubiak, Michal" References: Content-Language: pl, en-US From: Dawid Osuchowski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761903008; x=1793439008; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+K4yEluZ9DNkA/LHn1mgdDau/jNPIfLmkaXdvyofzzc=; b=QGqTwihgYpEVbt5rkx0l+WlEFfKcIhGScJh0MooVbfFH6SsclG1LeoWi RnVcMC1nTiyXO2lE1aFff3MzTLwFEkxEvyZiQ5WSmn3DKXm2mqhxwTGIt WBhQn+94/uN3V6Z7uYT2uSdjqRLA4cWIIwgHX3aEgpqF70/yPHQFYwYAR 88YmnScu0+EkO4cola6n1qoq1X5uvSDJx5xyDdQFPcLZIFJLGte69rB6n NAJxv84m+a1cb8l2fkxL426ve2S9krf9pxM1SnqxCqUrr4yHcZhXeVdj9 Nj+b/7Y4mVReyVTs+8654nnXbM5iY/dPGFKJfyUI+ZtOWvuvkeYjx2Dn9 A==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QGqTwihg Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: remove legacy Rx and construct SKB X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2025-10-31 5:58 AM, Sanigani, SarithaX wrote: >> -----Original Message----- > >> From: Intel-wired-lan > On Behalf Of Michal Kubiak > >> Sent: Thursday, September 25, 2025 2:53 PM > >> To: intel-wired-lan@lists.osuosl.org > >> Cc: Fijalkowski, Maciej >; Lobakin, Aleksander >; Keller, Jacob E >; > >> Zaremba, Larysa >; netdev@vger.kernel.org; Kitszel, Przemyslaw >; pmenzel@molgen.mpg.de; > >> Nguyen, Anthony L >; Kubiak, Michal > > >> Subject: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: remove legacy Rx and construct SKB > >> > >> The commit 53844673d555 ("iavf: kill 'legacy-rx' for good") removed the legacy Rx path in the iavf driver. This change applies the same rationale to the ice driver. > >> > >> The legacy Rx path relied on manual skb allocation and header copying, which has become increasingly inefficient and difficult to maintain. > >> With the stabilization of build_skb() and the growing adoption of features like XDP, page_pool, and multi-buffer support, the legacy approach is no longer viable. > >> > >> Key drawbacks of the legacy path included: > >> - Higher memory pressure due to direct page allocations and splitting; > >> - Redundant memcpy() operations for packet headers; > >> - CPU overhead from eth_get_headlen() and Flow Dissector usage; > >> - Compatibility issues with XDP, which imposes strict headroom and > >> tailroom requirements. > >> > >> The ice driver, like iavf, does not benefit from the minimal headroom savings that legacy Rx once offered, as it already splits pages into fixed halves. Removing this path simplifies the Rx logic, eliminates unnecessary branches in the hotpath, and prepares the driver for upcoming enhancements. > >> > >> In addition to removing the legacy Rx path, this change also eliminates the custom construct_skb() functions from both the standard and zero-copy (ZC) Rx paths. These are replaced with the build_skb() > and standardized xdp_build_skb_from_zc() helpers, aligning the driver with the modern XDP infrastructure and reducing code duplication. > >> > >> This cleanup also reduces code complexity and improves maintainability as we move toward a more unified and modern Rx model across drivers. > >> > >> Co-developed-by: Alexander Lobakin > > >> Signed-off-by: Alexander Lobakin > > >> Reviewed-by: Alexander Lobakin > > >> Reviewed-by: Jacob Keller > > >> Signed-off-by: Michal Kubiak > > >> --- > > Tested-by: Saritha Sanigani > (A Contingent Worker at Intel) Hello Saritha It seems your email client is misconfigured as this message (and the rest of messages for this series) appear as completely separate from the thread "ice: convert Rx path to Page Pool". This also means patchwork did not pick up your Tested-by tags [1]. Another issue is the mangled email addresses in Signed-off-by/Reviewed-by/Tested-by tags. Best, Dawid [1] https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20250925092253.1306476-2-michal.kubiak@intel.com/