All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: jrossi@linux.ibm.com, qemu-devel@nongnu.org,
	qemu-s390x@nongnu.org, cohuck@redhat.com, mjrosato@linux.ibm.com
Cc: zycai@linux.ibm.com, jdaley@linux.ibm.com, jjherne@linux.ibm.com,
	nrb@linux.ibm.com
Subject: Re: [PATCH v2 3/6] pc-bios/s390-ccw: Add per-queue notification offset for multi-queue virtio configurations
Date: Wed, 01 Jul 2026 21:49:07 -0400	[thread overview]
Message-ID: <d52bc6d7e5f763e64bc4c5db6d43928223174c53.camel@linux.ibm.com> (raw)
In-Reply-To: <20260630141917.673995-4-jrossi@linux.ibm.com>

On Tue, 2026-06-30 at 10:19 -0400, jrossi@linux.ibm.com wrote:
> From: Zhuoying Cai <zycai@linux.ibm.com>
> 
> The initial support for virtio-blk-pci IPL devices used a single virt-queue, but
> other device types require multiple queues, and for PCI device types this also
> requires a per-queue notification offset.
> 
> Add a PCI notify field to the VRing struct so that each queue has a unique
> notify offset as defined in the virtio spec.
> 
> Signed-off-by: Zhuoying Cai <zycai@linux.ibm.com>
> Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
> ---
>  pc-bios/s390-ccw/virtio-pci.c | 38 +++++++++++++++++++++--------------
>  pc-bios/s390-ccw/virtio-pci.h |  2 +-
>  pc-bios/s390-ccw/virtio.c     |  2 +-
>  pc-bios/s390-ccw/virtio.h     |  1 +
>  4 files changed, 26 insertions(+), 17 deletions(-)

Thank you for pulling out the bugfix from this patch. This still looks good.

Reviewed-by: Eric Farman <farman@linux.ibm.com>


  reply	other threads:[~2026-07-02  1:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 14:19 [PATCH v2 0/6] s390x: Fix intermittent errors with IPL from PCI devices on s390x jrossi
2026-06-30 14:19 ` [PATCH v2 1/6] pc-bios/s390-ccw: Refactor byte swapping jrossi
2026-06-30 14:19 ` [PATCH v2 2/6] pc-bios/s390-ccw/virtio.c: Fix missing break for PCI notifications jrossi
2026-07-02  1:44   ` Eric Farman
2026-07-02  2:12   ` Matthew Rosato
2026-06-30 14:19 ` [PATCH v2 3/6] pc-bios/s390-ccw: Add per-queue notification offset for multi-queue virtio configurations jrossi
2026-07-02  1:49   ` Eric Farman [this message]
2026-06-30 14:19 ` [PATCH v2 4/6] pc-bios/s390-ccw: Verify virtio support when booting from virtio PCI device on s390x jrossi
2026-07-02  2:03   ` Eric Farman
2026-06-30 14:19 ` [PATCH v2 5/6] pc-bios/s390-ccw: write IPLB location for non-net virtio devices jrossi
2026-07-02  2:04   ` Eric Farman
2026-06-30 14:19 ` [PATCH v2 6/6] s390x: Enable boot menu for virtio pci device jrossi
2026-07-02  2:08   ` Matthew Rosato
2026-07-02  2:12 ` [PATCH v2 0/6] s390x: Fix intermittent errors with IPL from PCI devices on s390x Matthew Rosato
2026-07-07 11:59 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d52bc6d7e5f763e64bc4c5db6d43928223174c53.camel@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=jdaley@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=jrossi@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=nrb@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=zycai@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.