All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Giancarlo Teodori <gteodori@gmail.com>,
	qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 4/4] prep: add IBM RS/6000 7020 (40p) machine emulation
Date: Tue, 10 Jan 2017 21:51:18 +0100	[thread overview]
Message-ID: <d5360409-c701-8656-2115-e9247a97efcb@reactos.org> (raw)
In-Reply-To: <3ae2a0f5-6bf0-c6f6-5852-6aff7bf8791a@redhat.com>

Le 09/01/2017 à 13:25, Thomas Huth a écrit :
>  Hi,
>
> On 07.01.2017 16:23, Hervé Poussineau wrote:
>> Machine supports both Open Hack'Ware and OpenBIOS.
>> Open Hack'Ware is the default because OpenBIOS is currently unable to boot
>> PReP boot partitions or PReP kernels.
>>
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>> ---
>>  default-configs/ppc-softmmu.mak |   1 +
>>  hw/ppc/prep.c                   | 229 ++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 230 insertions(+)

[...]

>
> This currently does not compile on a ppc64 host where CONFIG_KVM is set:
>
> hw/ppc/prep.c: In function ‘ibm_40p_init’:
> hw/ppc/prep.c:872:9: error: implicit declaration of function ‘kvmppc_get_tbfreq’ [-Werror=implicit-function-declaration]
>          fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_TBFREQ, kvmppc_get_tbfreq());
>          ^
> hw/ppc/prep.c:872:9: error: nested extern declaration of ‘kvmppc_get_tbfreq’ [-Werror=nested-externs]
> hw/ppc/prep.c:874:9: error: implicit declaration of function ‘kvmppc_get_hypercall’ [-Werror=implicit-function-declaration]
>          kvmppc_get_hypercall(env, hypercall, 16);
>          ^
> hw/ppc/prep.c:874:9: error: nested extern declaration of ‘kvmppc_get_hypercall’ [-Werror=nested-externs]
>
> You need to #include "kvm_ppc.h" to get the prototype of the
> kvmppc_get_tbfreq() function.

Done

  reply	other threads:[~2017-01-10 20:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-07 15:23 [Qemu-devel] [PATCH v3 0/4] ppc: add a IBM 40p machine (RS/6000, PReP) Hervé Poussineau
2017-01-07 15:23 ` [Qemu-devel] [PATCH v3 1/4] prep: do not use global variable to access nvram Hervé Poussineau
2017-01-07 15:23 ` [Qemu-devel] [PATCH v3 2/4] prep: add PReP System I/O Hervé Poussineau
2017-01-07 15:23 ` [Qemu-devel] [PATCH v3 3/4] prep: add IBM RS/6000 7020 (40p) memory controller Hervé Poussineau
2017-01-07 15:23 ` [Qemu-devel] [PATCH v3 4/4] prep: add IBM RS/6000 7020 (40p) machine emulation Hervé Poussineau
2017-01-09 12:25   ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2017-01-10 20:51     ` Hervé Poussineau [this message]
2017-01-09  1:42 ` [Qemu-devel] [PATCH v3 0/4] ppc: add a IBM 40p machine (RS/6000, PReP) David Gibson
2017-01-09  7:43 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2017-01-10  0:28   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5360409-c701-8656-2115-e9247a97efcb@reactos.org \
    --to=hpoussin@reactos.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=gteodori@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.