From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH net] r8169: fix NAPI handling under high load Date: Thu, 18 Oct 2018 07:58:52 +0200 Message-ID: References: <8f84fe39-3d8d-396d-3b97-027e0a83f8cb@gmail.com> <20181017233044.GA8478@electric-eye.fr.zoreil.com> <20181017.222149.1241280289340067644.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, netdev@vger.kernel.org To: David Miller , romieu@fr.zoreil.com Return-path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:39790 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbeJRN6T (ORCPT ); Thu, 18 Oct 2018 09:58:19 -0400 Received: by mail-wm1-f68.google.com with SMTP id y144-v6so4384939wmd.4 for ; Wed, 17 Oct 2018 22:58:59 -0700 (PDT) In-Reply-To: <20181017.222149.1241280289340067644.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 18.10.2018 07:21, David Miller wrote: > From: Francois Romieu > Date: Thu, 18 Oct 2018 01:30:45 +0200 > >> Heiner Kallweit : >> [...] >>> This issue has been there more or less forever (at least it exists in >>> 3.16 already), so I can't provide a "Fixes" tag. >> >> Hardly forever. It fixes da78dbff2e05630921c551dbbc70a4b7981a8fff. > > I don't see exactly how that can be true. > > That commit didn't change the parts of the NAPI poll processing which > are relevant here, mainly the guarding of the RX and TX work using > the status bits which are cleared. > AFAICS Francois is right and patch da78dbff2e05 ("r8169: remove work from irq handler") introduced the guarding of RX and TX work. I just checked back to 3.16 as oldest LTS kernel version. > Maybe I'm missing something? If so, indeed it would be nice to add > a proper Fixes: tag here. > Shall I submit a v2 including the Fixes line? > Thanks! >