From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Daehyeon Ko <4ncienth@gmail.com>,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Hagen Paul Pfeifer <hagen@jauu.net>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v2] mm/secretmem: properly account locked pages
Date: Tue, 25 Aug 2026 14:56:02 +0200 [thread overview]
Message-ID: <d58bfaaf-5849-43aa-9c18-271fd0500aaf@kernel.org> (raw)
In-Reply-To: <ao13TmFVVpsv0zO4@gremlin>
>>>
>>> + if (!secretmem_account_folio(state, folio)) {
>>> + folio_put(folio);
>>> + ret = VM_FAULT_SIGBUS;
>>> + goto out;
>>> + }
>>> +
>> Okay, that works because secretmem does not support any form of truncate, in
>> particular, no FALLOC_FL_PUNCH_HOLE.
>
> Yeah exactly. I think I covered that off somewhere in my essay-length
> commit msg but if not but yeah that is a thing that I noted.
I didn't quickly spot it, but it would be worth adding it if not already there.
>
>>
>> Overall, the idea sounds good to me. Nothing jumped at me.
>
> Thanks! So in a way you kinda... Ack it right? :P If only there were a tag
> for that 🤔 ;)
Well, on the split patch without the test ;)
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-08-25 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 19:14 [PATCH v2] mm/secretmem: properly account locked pages Lorenzo Stoakes (ARM)
2026-08-24 13:21 ` Mike Rapoport
2026-08-25 10:50 ` David Hildenbrand (Arm)
2026-08-25 11:18 ` Lorenzo Stoakes (ARM)
2026-08-25 12:56 ` David Hildenbrand (Arm) [this message]
2026-08-26 16:18 ` Lorenzo Stoakes (ARM)
2026-08-26 1:39 ` Daehyeon Ko
2026-08-26 7:57 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58bfaaf-5849-43aa-9c18-271fd0500aaf@kernel.org \
--to=david@kernel.org \
--cc=4ncienth@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hagen@jauu.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.