From: Ping-Ke Shih <pkshih@realtek.com>
To: Dmitry Morgun <d.morgun@ispras.ru>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: RE: [PATCH rtw-next v3] wifi: rtw89: check return values in rtw89_ops_start_ap()
Date: Tue, 30 Jun 2026 00:27:04 +0000 [thread overview]
Message-ID: <d58f1e279a0944529669a1e49d96cac6@realtek.com> (raw)
In-Reply-To: <20260629094452.8709-1-d.morgun@ispras.ru>
Dmitry Morgun <d.morgun@ispras.ru> wrote:
> Subject: [PATCH rtw-next v3] wifi: rtw89: check return values in rtw89_ops_start_ap()
Patch is fine. But I don't remember why this is v3. Can you point out
v1 and v2?
> Several functions called in rtw89_ops_start_ap() may fail to allocate
> skb or fail to send H2C command to firmware, returning -ENOMEM or an
> error code. Their return values are ignored, so subsequent commands
> are executed with incorrect state.
>
> Check the return values and propagate errors.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: a52e4f2ce0f5 ("wifi: rtw89: implement ieee80211_ops::start_ap and stop_ap")
> Signed-off-by: Dmitry Morgun <d.morgun@ispras.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2026-06-30 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 9:44 [PATCH rtw-next v3] wifi: rtw89: check return values in rtw89_ops_start_ap() Dmitry Morgun
2026-06-30 0:27 ` Ping-Ke Shih [this message]
2026-07-03 15:53 ` d.morgun
2026-07-06 1:28 ` Ping-Ke Shih
2026-07-03 3:51 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58f1e279a0944529669a1e49d96cac6@realtek.com \
--to=pkshih@realtek.com \
--cc=d.morgun@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.