From: Janani Sunil <jananisunil.dev@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
Janani Sunil <janani.sunil@analog.com>
Cc: "Michael Walle" <mwalle@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>
Subject: Re: [PATCH v7 3/3] gpio: ad7768: Add AD7768 GPIO auxiliary driver
Date: Thu, 10 Sep 2026 17:07:12 +0200 [thread overview]
Message-ID: <d597d432-2903-4f0c-883e-eccb6867bc8d@gmail.com> (raw)
In-Reply-To: <ap_nqnPLWJpz5N8o@ashevche-desk.local>
On 9/8/26 12:47, Andy Shevchenko wrote:
> On Tue, Sep 08, 2026 at 09:24:54AM +0200, Janani Sunil wrote:
>> The AD7768 provides five GPIOs controlled through registers shared
>> with the parent IIO device. Register an auxiliary gpio-regmap driver
>> and use the parent device for runtime PM.
>>
>> The device has separate input-state and output-latch registers. Add a
>> reg_mask_xlate() callback that checks the line direction and reads the
>> programmed output latch for output lines while retaining input-state
>> reads for input lines.
> ...
>
>> + if (ngpios > AD7768_FILTER_GPIO &&
>> + device_property_match_string(gc->parent->parent, "clock-names",
>> + "mclk") < 0)
> Looking at the length of the line I have just noticed that this uses
> gc->parent->parent. Here is the question: what does gc->fwnode refer to?
>
gc->fwnode is currently null. Would you prefer that I explicitly set config.fwnode = dev_fwnode(parent) and use the fwnode_property_match_string() here instead of walking gc->parent->parent?
Best Regards,
Jan
next prev parent reply other threads:[~2026-09-10 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 7:24 [PATCH v7 0/3] gpio: Add AD7768 GPIO support Janani Sunil
2026-09-08 7:24 ` [PATCH v7 1/3] gpio: regmap: Use regmap_test_bits() for single bit reads Janani Sunil
2026-09-08 7:24 ` [PATCH v7 2/3] gpio: regmap: Add optional runtime PM support Janani Sunil
2026-09-08 7:24 ` [PATCH v7 3/3] gpio: ad7768: Add AD7768 GPIO auxiliary driver Janani Sunil
2026-09-08 10:47 ` Andy Shevchenko
2026-09-10 15:07 ` Janani Sunil [this message]
2026-09-10 15:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d597d432-2903-4f0c-883e-eccb6867bc8d@gmail.com \
--to=jananisunil.dev@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@kernel.org \
--cc=janani.sunil@analog.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwalle@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.