Re: [RFC PATCH v3 02/10] drm/amdgpu: Add cwsr functions

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/12/2025 13:54, Lijo Lazar wrote:
> +		BUILD_BUG_ON(sizeof(cwsr_trap_gfx11_hex) > PAGE_SIZE);
> +		cwsr_info->isa_buf = cwsr_trap_gfx11_hex;
> +		cwsr_info->isa_sz = sizeof(cwsr_trap_gfx11_hex);
> +	} else {
> +		BUILD_BUG_ON(sizeof(cwsr_trap_gfx12_hex) >
> +			     AMDGPU_CWSR_TBA_MAX_SIZE);
> +		cwsr_info->isa_buf = cwsr_trap_gfx12_hex;
> +		cwsr_info->isa_sz = sizeof(cwsr_trap_gfx12_hex);
> +	}
> +}
> +
> +int amdgpu_cwsr_init(struct amdgpu_device *adev)
> +{
> +	struct amdgpu_cwsr_info *cwsr_info __free(kfree) = NULL;


This is an undesired syntax explicitly documented as one to avoid. You
need here proper assignment, not NULL. Please don't use cleanup.h if you
do not intend to follow it because it does not make the code simpler.


Best regards,
Krzysztof