From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DE94C0015E for ; Tue, 15 Aug 2023 15:18:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2254B81F25; Tue, 15 Aug 2023 15:18:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2254B81F25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1692112706; bh=ccvEwRBilKjRRM3+MLrQcH7Sc8wNC374muCsF6SyThU=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=t9c6ovCT8KQ+eCOo7rkyo7h6oHGxzlUzY8Qbj6hzdwqRIhtdOPujcBwr67M3PL8e1 r9LXQFbY8i1gokZ5yCOzgYgamhZ1QvsBtaEpwyHU6hqRW617w7+KCxFlB3PvstAytB KP+FsMSsI+zqlBH69JTViqYA1ynSQBR57RIEX0HQ0fXs/DDJdGx0S84fcEHcsF8hEg Si0yBinYna7qdnRUZJ/6QAJs9FnaST8wnCsBQbA75Zp8J5STv8XA2nMJqLNAJA/7CF k5DRmJr4n25LHrPabWRjxhfsQ2fEmTT9kSoyrytzQ+h35tCrXcevH7v96NHZ7m3mTj gX4SRTy0sUI9Q== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HwkaBgbKO3ti; Tue, 15 Aug 2023 15:18:25 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 3D51E81F2C; Tue, 15 Aug 2023 15:18:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3D51E81F2C Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 1E7EC1BF475 for ; Tue, 15 Aug 2023 15:18:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C21EF402C5 for ; Tue, 15 Aug 2023 15:18:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C21EF402C5 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w2y0nKUt0Hgy for ; Tue, 15 Aug 2023 15:18:22 +0000 (UTC) Received: from out-25.mta1.migadu.com (out-25.mta1.migadu.com [95.215.58.25]) by smtp4.osuosl.org (Postfix) with ESMTPS id 6E123402B9 for ; Tue, 15 Aug 2023 15:18:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6E123402B9 Message-ID: Date: Tue, 15 Aug 2023 16:18:16 +0100 MIME-Version: 1.0 Content-Language: en-US To: Jakub Kicinski References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20230814202441.349586b4@kernel.org> X-Migadu-Flow: FLOW_OUT X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692112700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5jkRrsW9ZohDgZxdapSfROnd5WC/t+pIz3Z7RYOCEpk=; b=c5FEo+pNIRIQR7Ia0XE3msfztl33UetjSbeMLnJyhUSRhDUCP2kxoRpHGyDdwiMOcjW43J qoHzwqxkoMhZFA8/CC1eUtKOuhQ/885vlEtdkrFqcVDLMYBer7/m3NNBBM1aFld7cbsGE7 w8ziAMKjx3NN87XuwGAI6Vrfj8zshdw= X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=c5FEo+pN Subject: Re: [Intel-wired-lan] [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , Bart Van Assche , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, Jiri Pirko , Jonathan Lemon , Paolo Abeni , linux-clk@vger.kernel.org, Milena Olech Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 15/08/2023 04:24, Jakub Kicinski wrote: > On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: >> + xa_for_each(&pin->dpll_refs, i, ref) { >> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); >> + struct dpll_device *dpll = ref->dpll; >> + >> + if (!ops->frequency_set) >> + return -EOPNOTSUPP; >> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), >> + dpll, dpll_priv(dpll), freq, extack); >> + if (ret) >> + return ret; >> + __dpll_pin_change_ntf(pin); >> + } > > only one freq is reported in get, AFAICT, so why send a notification > after each ref is updated? The pin can be technically connected to several DPLLs and app may watch for the specific DPLL messages only. We would like to inform all users on any DPLL which has this pin connected to. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1047CC0015E for ; Tue, 15 Aug 2023 15:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234061AbjHOPS7 (ORCPT ); Tue, 15 Aug 2023 11:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237957AbjHOPSh (ORCPT ); Tue, 15 Aug 2023 11:18:37 -0400 Received: from out-2.mta1.migadu.com (out-2.mta1.migadu.com [95.215.58.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 350E119A3 for ; Tue, 15 Aug 2023 08:18:22 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692112700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5jkRrsW9ZohDgZxdapSfROnd5WC/t+pIz3Z7RYOCEpk=; b=c5FEo+pNIRIQR7Ia0XE3msfztl33UetjSbeMLnJyhUSRhDUCP2kxoRpHGyDdwiMOcjW43J qoHzwqxkoMhZFA8/CC1eUtKOuhQ/885vlEtdkrFqcVDLMYBer7/m3NNBBM1aFld7cbsGE7 w8ziAMKjx3NN87XuwGAI6Vrfj8zshdw= Date: Tue, 15 Aug 2023 16:18:16 +0100 MIME-Version: 1.0 Subject: Re: [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions Content-Language: en-US To: Jakub Kicinski Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20230814202441.349586b4@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 15/08/2023 04:24, Jakub Kicinski wrote: > On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: >> + xa_for_each(&pin->dpll_refs, i, ref) { >> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); >> + struct dpll_device *dpll = ref->dpll; >> + >> + if (!ops->frequency_set) >> + return -EOPNOTSUPP; >> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), >> + dpll, dpll_priv(dpll), freq, extack); >> + if (ret) >> + return ret; >> + __dpll_pin_change_ntf(pin); >> + } > > only one freq is reported in get, AFAICT, so why send a notification > after each ref is updated? The pin can be technically connected to several DPLLs and app may watch for the specific DPLL messages only. We would like to inform all users on any DPLL which has this pin connected to. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28893C0015E for ; Tue, 15 Aug 2023 15:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=klLA0sLbzibrFEwWs4pVHVLCEGuF922idRzT9yk6zJs=; b=hwULBEXVkCH9D9 XVvyZTezUm/DtDbwY4dTLFK61nZIA2VPBiFZrQhTCjKQ1Gfxh6O4v1xPzpiQCaKwSnSZyjWu6L01R N0Z9KZz74QRJYU8TBLkKaqYSy32tKllwKbGLclVRvKfXbvDzx+57IFpE/oPGE5M9qIzPq4cTkwV05 dp5xih112rY3gQQRAea/MHa96RU7QI7/hgWypcwrOfM1CLrdzxyNwm17yQYQWCprWM5/he57Op5jv BwoMUC4D4LCFnrTc8gMxEbf0sE3dlUhBCnDHNT4iMAifE2wrvkjvQP1apclKop4x5XzfyvU21/7Es o8VeWcyCmAtsbk2zJ2TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVvoS-001pxm-1S; Tue, 15 Aug 2023 15:18:28 +0000 Received: from out-24.mta1.migadu.com ([95.215.58.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVvoO-001pwY-08 for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 15:18:27 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692112700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5jkRrsW9ZohDgZxdapSfROnd5WC/t+pIz3Z7RYOCEpk=; b=c5FEo+pNIRIQR7Ia0XE3msfztl33UetjSbeMLnJyhUSRhDUCP2kxoRpHGyDdwiMOcjW43J qoHzwqxkoMhZFA8/CC1eUtKOuhQ/885vlEtdkrFqcVDLMYBer7/m3NNBBM1aFld7cbsGE7 w8ziAMKjx3NN87XuwGAI6Vrfj8zshdw= Date: Tue, 15 Aug 2023 16:18:16 +0100 MIME-Version: 1.0 Subject: Re: [PATCH net-next v4 4/9] dpll: netlink: Add DPLL framework base functions Content-Language: en-US To: Jakub Kicinski Cc: Jiri Pirko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-5-vadim.fedorenko@linux.dev> <20230814202441.349586b4@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20230814202441.349586b4@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_081824_504213_9873E0C3 X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/08/2023 04:24, Jakub Kicinski wrote: > On Fri, 11 Aug 2023 21:03:35 +0100 Vadim Fedorenko wrote: >> + xa_for_each(&pin->dpll_refs, i, ref) { >> + const struct dpll_pin_ops *ops = dpll_pin_ops(ref); >> + struct dpll_device *dpll = ref->dpll; >> + >> + if (!ops->frequency_set) >> + return -EOPNOTSUPP; >> + ret = ops->frequency_set(pin, dpll_pin_on_dpll_priv(dpll, pin), >> + dpll, dpll_priv(dpll), freq, extack); >> + if (ret) >> + return ret; >> + __dpll_pin_change_ntf(pin); >> + } > > only one freq is reported in get, AFAICT, so why send a notification > after each ref is updated? The pin can be technically connected to several DPLLs and app may watch for the specific DPLL messages only. We would like to inform all users on any DPLL which has this pin connected to. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel