From: manojbm@codeaurora.org
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, subashab@quicinc.com,
sharathv@qti.qualcomm.com, ssaha@qti.qualcomm.com,
vidulak@qti.qualcomm.com, bryanh@quicinc.com,
jovanar@qti.qualcomm.com, manojbm@qti.qualcomm.com
Subject: Re: [PATCH] netfilter: xtables: Add snapshot of hardidletimer target
Date: Wed, 13 Nov 2019 00:23:46 +0530 [thread overview]
Message-ID: <d5ebd8d0d6fa6bb0c102a822c17c6060@codeaurora.org> (raw)
In-Reply-To: <20191112111424.GE19558@breakpoint.cc>
On 2019-11-12 16:44, Florian Westphal wrote:
> Manoj Basapathi <manojbm@codeaurora.org> wrote:
>> When the timer expires, the target module sends a sysfs notification
>> to the userspace, which can then decide what to do (eg. disconnect to
>> save power)
>>
>> Compared to xt_IDLETIMER, xt_HARDIDLETIMER can send notifications when
>> CPU is in suspend too, to notify the timer expiry.
>
> Would it make sense to add this feature to IDLETIMER instead of a new
> module? AFAICS there is a lot of boilerplate overlap between those two.
Its a feature specific module .Keeping it as a separate module helps us
to enable and disable it via defconfig.
As iptable rules are target specific , it also helps iptable rules run
independently and easier to debug .
next prev parent reply other threads:[~2019-11-12 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 6:56 [PATCH] netfilter: xtables: Add snapshot of hardidletimer target Manoj Basapathi
2019-11-12 11:02 ` Arturo Borrero Gonzalez
2019-11-12 11:14 ` Florian Westphal
2019-11-12 18:44 ` manojbm
2019-11-12 18:53 ` manojbm [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-05 10:22 Manoj Basapathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5ebd8d0d6fa6bb0c102a822c17c6060@codeaurora.org \
--to=manojbm@codeaurora.org \
--cc=bryanh@quicinc.com \
--cc=fw@strlen.de \
--cc=jovanar@qti.qualcomm.com \
--cc=manojbm@qti.qualcomm.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=sharathv@qti.qualcomm.com \
--cc=ssaha@qti.qualcomm.com \
--cc=subashab@quicinc.com \
--cc=vidulak@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.