From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D093DCAC59B for ; Tue, 16 Sep 2025 19:04:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 907EC826A8; Tue, 16 Sep 2025 19:04:20 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UqzvzWM5rOFB; Tue, 16 Sep 2025 19:04:19 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C46DF826B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1758049459; bh=HXOAPEjzekOAjE4mciNBEhLhGsM198o+7B85xHhnuzA=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Y0nOSCA5+JV3I3vLNYbhNvOjl67Jh425vLjrgsMIcTgXwwtbfJLx0t9iIm37/VdYO kcsCxDixxiDTU4ecMlruceXOP9UHR4csc8s9seRAqqsVHm/jaw1R5VOQsVZf2j+Vn7 uODBUmnzrDvqxsFXnE2Cw3OBtMe/MIgrq6G3/c9WNbDDU29WgSp26LLqlHmeBVGOIs YOQmsDTuBqSTK8vuvESJyJSqGqMRYdrwPvxlXxv2ZVMfdoQsRHy0HrRqfsUSj/WwBn 0XPQHPUzhpRfWx+NRYaJUsjLGl+i2IoHe1P1iaPMJjNkF3orkcD7DpxMpaYT27xYU4 mvOXNqG4LGjRA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id C46DF826B0; Tue, 16 Sep 2025 19:04:19 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id DA8C012D for ; Tue, 16 Sep 2025 19:04:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C0CBA826A8 for ; Tue, 16 Sep 2025 19:04:17 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id xaMaKgChmqnc for ; Tue, 16 Sep 2025 19:04:16 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:41d0:1004:224b::b4; helo=out-180.mta0.migadu.com; envelope-from=vadim.fedorenko@linux.dev; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org EA100826B4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org EA100826B4 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [IPv6:2001:41d0:1004:224b::b4]) by smtp1.osuosl.org (Postfix) with ESMTPS id EA100826B4 for ; Tue, 16 Sep 2025 19:04:15 +0000 (UTC) Message-ID: Date: Tue, 16 Sep 2025 20:04:04 +0100 MIME-Version: 1.0 To: Alexander Lobakin , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20250916160118.2209412-1-aleksander.lobakin@intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250916160118.2209412-1-aleksander.lobakin@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1758049451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXOAPEjzekOAjE4mciNBEhLhGsM198o+7B85xHhnuzA=; b=aQEk3/vfn2molZrZKNuI31cy6yCYMkCI7CiNCMpqf1iPYO5lrulrKVailmopFUznZ86QU7 tsSsgwMKsfaAuhZf5ARVKNEwUicYVqghTmaaeLua0aGGC7zp4jipiFyRfROryJqLfIEkKh XLiC2oDRJgC3dygNGBLNW4+Vblncp8k= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=linux.dev X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=aQEk3/vf Subject: Re: [Intel-wired-lan] [PATCH net-next] libie: fix linking with libie_{adminq, fwlog} when CONFIG_LIBIE=n X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Przemek Kitszel , Naresh Kamboju , linux-kernel@vger.kernel.org, nxne.cnse.osdt.itp.upstreaming@intel.com, Tony Nguyen , Simon Horman , netdev@vger.kernel.org, Michal Swiatkowski , intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 16/09/2025 17:01, Alexander Lobakin wrote: > Initially, libie contained only 1 module and I assumed that new modules > in its folder would depend on it. > However, Michał did a good job and libie_{adminq,fwlog} are completely > independent, but libie/ is still traversed by Kbuild only under > CONFIG_LIBIE != n. > This results in undefined references with certain kernel configs. > > Tell Kbuild to always descend to libie/ to be able to build each module > regardless of whether the basic one is enabled. > If none of CONFIG_LIBIE* is set, Kbuild will just create an empty > built-in.a there with no side effects. > > Fixes: 641585bc978e ("ixgbe: fwlog support for e610") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/all/202509140606.j8z3rE73-lkp@intel.com > Reported-by: Naresh Kamboju > Closes: https://lore.kernel.org/all/CA+G9fYvH8d6pJRbHpOCMZFjgDCff3zcL_AsXL-nf5eB2smS8SA@mail.gmail.com > Signed-off-by: Alexander Lobakin > --- > Sending directly to net-next to quickly unbreak net-next and > linux-next builds. > Also to net-next as the blamed commit landed recently and is > not present in any other tree. > --- > drivers/net/ethernet/intel/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/Makefile b/drivers/net/ethernet/intel/Makefile > index 04c844ef4964..9a37dc76aef0 100644 > --- a/drivers/net/ethernet/intel/Makefile > +++ b/drivers/net/ethernet/intel/Makefile > @@ -4,7 +4,7 @@ > # > > obj-$(CONFIG_LIBETH) += libeth/ > -obj-$(CONFIG_LIBIE) += libie/ > +obj-y += libie/ > > obj-$(CONFIG_E100) += e100.o > obj-$(CONFIG_E1000) += e1000/ Reviewed-by: Vadim Fedorenko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD4F26E6FB for ; Tue, 16 Sep 2025 19:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758049456; cv=none; b=dhJm4+j1eUboYc7Ytlp8xerQYJgwJyOIXeclGhdtabJ4yxt5UzxJSgBUmYbKjrCcryk2pglLcsK+gZjyzbzYIVWrxLnOiIwzJIrvrdaCnMjXPFkHrST+5Q5bmlIMtkyyBujQHVI9RqT2eHzt6gwNduOdtjLTw/tfSc4OVLYp0CU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758049456; c=relaxed/simple; bh=eVMZ8aJw3wzjCNrVys1HEp1kSdur0B6Zj2ywjbkTItM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oryPKVFwBJohLlENYO3ccYpR8WbPWabJhej8m/EhIP/BE7kEsb7FzBXQejNAoZ+Ef1VhSeB8Y4+2aXkq2OhZ7z1KQJ91IHOBzBXhG9yhH4LgsDPVXsyXHjETLmtupqab7wyBZGcejoo9o07IU8v36mb1/b/HCe6CIqznplRXfl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aQEk3/vf; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aQEk3/vf" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1758049451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXOAPEjzekOAjE4mciNBEhLhGsM198o+7B85xHhnuzA=; b=aQEk3/vfn2molZrZKNuI31cy6yCYMkCI7CiNCMpqf1iPYO5lrulrKVailmopFUznZ86QU7 tsSsgwMKsfaAuhZf5ARVKNEwUicYVqghTmaaeLua0aGGC7zp4jipiFyRfROryJqLfIEkKh XLiC2oDRJgC3dygNGBLNW4+Vblncp8k= Date: Tue, 16 Sep 2025 20:04:04 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next] libie: fix linking with libie_{adminq,fwlog} when CONFIG_LIBIE=n To: Alexander Lobakin , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Michal Swiatkowski , Przemek Kitszel , Tony Nguyen , Simon Horman , kernel test robot , Naresh Kamboju , nxne.cnse.osdt.itp.upstreaming@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250916160118.2209412-1-aleksander.lobakin@intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250916160118.2209412-1-aleksander.lobakin@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 16/09/2025 17:01, Alexander Lobakin wrote: > Initially, libie contained only 1 module and I assumed that new modules > in its folder would depend on it. > However, Michał did a good job and libie_{adminq,fwlog} are completely > independent, but libie/ is still traversed by Kbuild only under > CONFIG_LIBIE != n. > This results in undefined references with certain kernel configs. > > Tell Kbuild to always descend to libie/ to be able to build each module > regardless of whether the basic one is enabled. > If none of CONFIG_LIBIE* is set, Kbuild will just create an empty > built-in.a there with no side effects. > > Fixes: 641585bc978e ("ixgbe: fwlog support for e610") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/all/202509140606.j8z3rE73-lkp@intel.com > Reported-by: Naresh Kamboju > Closes: https://lore.kernel.org/all/CA+G9fYvH8d6pJRbHpOCMZFjgDCff3zcL_AsXL-nf5eB2smS8SA@mail.gmail.com > Signed-off-by: Alexander Lobakin > --- > Sending directly to net-next to quickly unbreak net-next and > linux-next builds. > Also to net-next as the blamed commit landed recently and is > not present in any other tree. > --- > drivers/net/ethernet/intel/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/Makefile b/drivers/net/ethernet/intel/Makefile > index 04c844ef4964..9a37dc76aef0 100644 > --- a/drivers/net/ethernet/intel/Makefile > +++ b/drivers/net/ethernet/intel/Makefile > @@ -4,7 +4,7 @@ > # > > obj-$(CONFIG_LIBETH) += libeth/ > -obj-$(CONFIG_LIBIE) += libie/ > +obj-y += libie/ > > obj-$(CONFIG_E100) += e100.o > obj-$(CONFIG_E1000) += e1000/ Reviewed-by: Vadim Fedorenko