From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF1E734678C for ; Wed, 1 Jul 2026 18:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782931215; cv=fail; b=XII9TSXSrQu1IlZ3R5KhPMbGlH+DBBetsAqUNRjwmOu6FkGXkuYIE7eaFALTcj/WLUfWWkckHfAvHAQyzexksZYyUfWOTfZ0josmLCaMAbdZkqKU1gx3qmYdL6PoIrKeYScR1AYHd5CwddMZ5zs1EY8ShTmbfU536jx63yAYkzM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782931215; c=relaxed/simple; bh=21jL97vlhOLGdH6pV6v2a0z0YTJ37vZ0f61Xx+Xruqc=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=inZL5xt0u0Q3tAn0VIUBCFIDy6PIJ+MrS2FHR/PLNbKhazR5dLdR8s2j9m6hElGFHh4vgicjz2dtmbUKnwQIbAsJhmPwsuHbpmOGR1aeW4QdYtdBQhg/ZKljhqM15mGcWnulp740apHIBjJKzwPjtQmURlVItFpdQezXU+mc9D0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mPBMH7Ux; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mPBMH7Ux" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782931213; x=1814467213; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=21jL97vlhOLGdH6pV6v2a0z0YTJ37vZ0f61Xx+Xruqc=; b=mPBMH7UxIkBAUQvSLz0HPil0JP7AeGq+F0sO9MJCaZ0Yu+qKujAtrVVv 6GQNwTXTf6BFfr5Wz6HAbTfUMAE0D3kDLR1/QmDAVoqdKCc3U9Rah4lEC fYWB40fy8TknsRnlgvYG375MOmXDAtd8HYc06bveIbcYZ4GScfao8rTiJ lKhJCCx6WDOrZwfxDHPQgcy0zY9tcgABm/rkrevbLSuwZLVSbvmwytyHx LKRyeNFuF6Z2rjcDht1RZjGX79JAwHV54G3zbLbG/+cETYuS1NG9jNOYa 0Qnu8V5W6boM9i65RL9jSBvHwk5MV6J8ds1QR6LT8MM2iYpo8FSZCktL0 A==; X-CSE-ConnectionGUID: zppXq9V8SwaTnAJFOjyYtA== X-CSE-MsgGUID: CJjknjltRBqiIcwHC1wgQQ== X-IronPort-AV: E=McAfee;i="6800,10657,11834"; a="94273788" X-IronPort-AV: E=Sophos;i="6.25,142,1779174000"; d="scan'208";a="94273788" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 11:40:12 -0700 X-CSE-ConnectionGUID: zv+yUIsLQfK2XMALYBYAnA== X-CSE-MsgGUID: TxGAgQ6GR9yRNg91MvEl4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,142,1779174000"; d="scan'208";a="251595216" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 11:40:11 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Wed, 1 Jul 2026 11:40:11 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43 via Frontend Transport; Wed, 1 Jul 2026 11:40:11 -0700 Received: from DM1PR04CU001.outbound.protection.outlook.com (52.101.61.67) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Wed, 1 Jul 2026 11:40:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KyyyWJG3Ec6bCLyE5hgiH+OeNCx4kwsAEul7uRJVZiSS/6bpCuYgJ5P5dY1Fv83uSrevrGJJIwiGLd1DmIuJhTeTdZ5yFtioJophgMBu+iwaNiQFAVmMYvaAJt2fj8YxH7BDWZHVIf/gTc+MM2h42EoZynRqXIUcsxdRyEda23I6jIFUgvr6edeSBpiHhDXjRjbKZj8pxnVIG0Pk/FSEBIzlkCzruetSNgs0CK0imoZBEMI80JqShhEWt8+m5CmJ5md+T4hBr6TPlOrQ3Rte3PFbNYRtQSGAKHS2Te8OSQY4DlnI5gIYGRAZslm0GxhYLrXJWzJftDTFViqv26DosA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DtDAzoiWHkW6QIRsYffra4PBNr2jdNKEaFG6E21kMQc=; b=f/EkTooDwoEo3d8azSIjb5GGSAL4JkqWfzLTTzxFIUuqgqbetvVBXd4yuzP+GKoE1xLeoKDA3sD+OM29ydT/4uX9tvzyIqoP8uA5GBqY72NsWmQfdDrgoe/KlqCW32fXd14GStv9pnvqbPHzH+csXTqT4BkGlZSfhAAqt8FYdwm7mdQ30JS5cQ6NZMiPQff5BS8k6B3mYNHqU3IUlkGt+f9QAKEhFBBTC1FjBowcL831m3nibrXwEgg3TIdlXydNm2hjHl8wrYkYXG03O+uavC0RqmhwIXyD751wthqZVXyJQqzkXbarrri75T7sFtYYEIY0mKwOvloM9ASqdKNQhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by SA0PR11MB4688.namprd11.prod.outlook.com (2603:10b6:806:72::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.13; Wed, 1 Jul 2026 18:40:01 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0159.018; Wed, 1 Jul 2026 18:40:01 +0000 Message-ID: Date: Wed, 1 Jul 2026 11:39:59 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] x86/msr: Switch users of native_wrmsr() to native_wrmsrq() To: Juergen Gross , , CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tony Luck , "Dave Martin" , James Morse , Babu Moger References: <20260629063943.3641266-1-jgross@suse.com> <20260629063943.3641266-2-jgross@suse.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <20260629063943.3641266-2-jgross@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0340.namprd03.prod.outlook.com (2603:10b6:303:dc::15) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|SA0PR11MB4688:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b3999aa-d760-4079-7610-08ded7a028ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|23010399003|56012099006|11063799006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 8OPgRMliIPJGId3RglEKxYBYzY+SchAOgZsI9g+K2VqOF2EzifRkMGW5s0a+59ncpdjeIVP3BnwU6txo5Avrd/mDjyqj5XgwqP/Fu1p8lNccaPYhBd8oYIlpwWmDmU5USvQL1X5t5asaZfHkppkIpYte1H0XiUXnVkkPCbRVot6IAVRKQ6IOECYfW3zEfmDQPaz5dup/0F+PhDhS+sPgqDVvQ0w6tbxODZIHCiA+SzVMWluR6AHKH64zbB29dzzxMGX1uw+LCC1A7ejWXpoE6Wxc3WGYAmD5KON+rFfsxbB/Wuqj/NdcEuz42I9i5vdxK2dZu9KR7Bz7Vde/Km/pIqR28qGw12Ev+SmZUPm8Qk48CdbPKUZIWnLPZqlyF9xt/5FZqb7EKqLfdKclIxvPTbZxxVyEP59dm66wKpLUClj+TtDHPLCG8lrpS5iTL2cB0kRPElcDopg7ZBXpwv109x4lHen28ssBXiWpANdsSMKuV4BNbCdRJv132Ln3LocC0YbWbeQsRkfmEKvrDoMbOMNpjGwmo2fMgLHMGP/Yv8fVV75MMzgB6bcraCCdXhmaIdaelIyIuh2zRjXykrcl0KObgQ6jjKW9HTm5AKiWX3D4Kc+1AB3bXxfKabjw+rBHpHZbvFA40i1e8fnnu8tzJXjb6TapLZacok43g6lRzjc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(23010399003)(56012099006)(11063799006)(4143699003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUxsdU4vbndwNFcyVlJEZ2x2YXViclJSb0p5amx0MmplSmIyNy9ZT3drZnFO?= =?utf-8?B?L2ZpbzVqeHZRaUQ3WWc3RHJOZFZYUHJmM0k3Y2kxWTM3NzJkZjRIV1Y1elRD?= =?utf-8?B?MVNqT0FlVGUvejlCaENIeDdabHNLWGoySU84eEcydUxlUUtadzBzSXNYUGdJ?= =?utf-8?B?MWFpelp0UU9BeUNGbm5ibDBLd2pwWkpkRUVsN1pwV0V4eVdjVUh6UGlNdXdy?= =?utf-8?B?MUhFZ0h2cktDSFRDOGl5Y2hIY0lrVWdjRTBwUmlhU0UyS2wvajM1d1Z5N09O?= =?utf-8?B?elQzcWZRWUIzSHFjSzFsSmYxMWFxTGZDQldWN1RYT3pzL0xuU1VzV2ZxWCt2?= =?utf-8?B?SllPeFI3UFlzSDRUZ0l5K0pIbHE3SUI3QkY3T0p3NVR6Q1RCbzR4clhiSmk2?= =?utf-8?B?MzVvMUoxaFZxdUVxUHFFbktxa1QyK3FiNWdNUmZLSUdzUG5uS09aQ0hEKzFT?= =?utf-8?B?aGZNakRlMEFmWmNOV0Z2TkpCU1hkUFN0NGhGRDFpL3h2UVVqM0UvemgyNHlj?= =?utf-8?B?OGRHaFV3cEdDMnZ6V1JwT3A3aGN0T0c0cmVYL21xWDk1RmJSeDJZMzBDZUVv?= =?utf-8?B?c0J2aWJLa3V6MklsWndEZG53T3BLeUVzeWo5elJjZ1dvQTJBK1liSFdsd3R3?= =?utf-8?B?MHdXT0loeGgwYWhIakhmK1FoV2p0YjhuRHUvUEQxMmNDZDNUL0FKdnBQNkph?= =?utf-8?B?VlRQVWFpVkc3alpKR3F2eFBaUVBlTVljRHl6Uml4Z2ZFVE13dUFseVpzQU5o?= =?utf-8?B?VjlFekIrWVFUMWlGeDNmSzBlTkZJN3ljbkRpOE5mbXgwSUx5VFlNRnEycDBE?= =?utf-8?B?dUxFL05zTVNKei9QNnpZYk9DeEIvT01UTUhTMSt6WmVhK3pGTktMRDNkempl?= =?utf-8?B?QmRFYXgrTFlLb2ZJQlJtRi9GMDlacFZVdStEY29aSVRjZ0VUeE9zWWZLWlNx?= =?utf-8?B?dTBtWWUvMkdPQzJrSEdSYnA2SjJpZnMrMGx5bHNhOXdwVC95VEpHNjNYdUtH?= =?utf-8?B?dXhGU2lOQktIZmxsVHo5a0xUYnRtSy92VEdWN2IzZUpVSlRSRW1FcVk1cXcx?= =?utf-8?B?eFNXdHhURlYzNm5LenQyZENmS1pXb2xYZWVGZjF3ejFhT3NOY1hxZzJTQ09T?= =?utf-8?B?MUg3RHhueVhQYUIvcjJ5MFI3UEZDbm95TVhXaE1OTTc0N3grOXhwVHpNZk9L?= =?utf-8?B?ZG1jK0E2aktkT3BJUGhCb0dzaHpOaTlUblhPR2JWRTVYZkpyZFZqcjl1MDdl?= =?utf-8?B?TDI4QTVPdExueG5NNFJyYnh2WWtITEVZOGdIVWFVdlhUQkxXRXdDc2kxb1Q0?= =?utf-8?B?QUZtRkxnbGs0TlJBeWRWd1ZwSVJmTWRaS1JhTEtmTk81OXRBZWlmMVpzdC9s?= =?utf-8?B?VHkwbjBEcXdmdTArQlFaWkNCanFOOS9ZOTU5bkJJa2ZnN1NaTlQ3QUpEZVE2?= =?utf-8?B?U0YxUStMWHJhend6RUtYQllsVmpNbDgzTHlpZjNBNW0wUXJ1YTQ2cXV2Zk9G?= =?utf-8?B?OHExc2FqQ3JRdUFPSllXcDJtMlhYRGNLVEZkWGg1SG1NUk5CaTRrQnpkdzhE?= =?utf-8?B?Z0dPbmJKdXkwT1lpUmtPWDJJUmkwaHU4VmM5dzZ2T1VyWVJYSGYwcWFpU1Bl?= =?utf-8?B?b2lvMVBESDdRc1ExSVk1dkxMTURheUUrZmp4SXQyOWJZK2RNaGxYcW81TnRl?= =?utf-8?B?cGVqOXZDRHdsRmRKaGVYL3doQ1orREJrNWk1UEJiSDFIU0RibEJ6cUhKSnBM?= =?utf-8?B?N0RleFQ1RVVMMGZub1JXSWxPYTltL0NtdlZEcUpZbWdrTVlvTzRjbWlaRmhC?= =?utf-8?B?TGM3bU1QQ1ozdG5MUFZlY09udkRJVXNtWlhaVVNwUVloc0FCTnF2YVdWTXlx?= =?utf-8?B?R2RpcDBMRGNjbWwvZFdzamw5ZFlUWWZnRU9CTUU2eE9OOEYzWElmUjE0Znl3?= =?utf-8?B?RnprQjN6UDNoSkxMMjErRDViSjdVTWR1ZkxVRk16M1JwanB4eVlEWVZpMkJn?= =?utf-8?B?b1krZEY3aGJFMWVsWGNGdWJ1OGRlSGVQdVdMYWdYTkI1WCttdDlWR3p4eHF1?= =?utf-8?B?SDE2NHQwcmswSkN2YWw1ZGh3K2g1TjB5ME9sMEZyQ2dOOHlKdWFXZXpCbkFO?= =?utf-8?B?eEwxamFNK0N1RDgwMGxhUUlLOWlleFR5SEpXdk14VXlJVHpGZFFaYnlpUzdB?= =?utf-8?B?WkRETWMxbU1QeXVHcUR1YTl1TFZQbXRzM3BuclpWT05HRGxPZmNSemhTL00y?= =?utf-8?B?TnExT3ZWeFpSQWM0Qi9rbEY3NjVNem9XbFNETFVqUTMwM0Z0NllseE1XMkpQ?= =?utf-8?B?bmk4WUg4VEVQY05FRmx5SUt3Z2w5cGxnNDdsc2U1VFBGazRHbk5sUTFnclg2?= =?utf-8?Q?9x/Uz89Prinfn0zQ=3D?= X-Exchange-RoutingPolicyChecked: VlhDjqn+GN0NvVaGGiMdDvVemGV1rcih6nRw+xiRiTjLJln2+Upbgv0wZ7MTnsKd9yUH1gPmoY+ePzJ9iDT3jWfpg7NwxuC/1zKuEY8vJWZu+8h94Ry5IPNI8IQ9BAm97Z/nKqRcnYNGqWUfWhfI0WcPdLWSWex0dR2UcszFe/u5bDm6fXT17BMcdOtGeDpidPQ6qcjozBOV0em+4oCa8JZZDNucFOFhoVuHeJlNd4IyTTLLUBMMFgab+Sn76AYz390iKdWek/SHjSk5tEH9Tgc2WTaSE107wn3HmozofPR9Y8z3ZYCWrGIIf0a6l6kunmOFg3f9LL+aRT2SUy+kQA== X-MS-Exchange-CrossTenant-Network-Message-Id: 7b3999aa-d760-4079-7610-08ded7a028ed X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 18:40:01.5693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AqY8pZFagW4+aRotbc1BQI7RnH6p/979CVocCtJu7lJF6V40g1AzrfrLqo4/D8cKza+UbR8FnZzjN783OHG4VOGtsXNQ0t9O6dswZd5IgKE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4688 X-OriginatorOrg: intel.com Hi Juergen, On 6/28/26 11:39 PM, Juergen Gross wrote: > Switch all users of native_wrmsr() to native_wrmsrq() in order to > prepare removal of native_wrmsr(). > > Signed-off-by: Juergen Gross > --- (just looking at resctrl changes ...) > diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c > index 0408ac7f66fd..ad4c0d79ce1d 100644 > --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c > +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c > @@ -175,7 +175,7 @@ int resctrl_arch_pseudo_lock_fn(void *_plr) > * pseudo-locked followed by reading of kernel memory to load it > * into the cache. > */ > - native_wrmsr(MSR_IA32_PQR_ASSOC, rmid_p, plr->closid); > + native_wrmsrq(MSR_IA32_PQR_ASSOC, rmid_p | ((u64)plr->closid << 32)); > This is ok but I find that it could be easier to read if changed to: native_wrmsrq(MSR_IA32_PQR_ASSOC, (u64)plr->closid << 32 | rmid_p) Above matches existing and familiar pattern of "high << 32 | low" when preparing register values as found in, for example arch/x86/include/asm/msr.h, that matches the mental model of ordering registers from MSB to LSB. The extra parentheses seem unnecessary. > /* > * Cache was flushed earlier. Now access kernel memory to read it > @@ -212,7 +212,7 @@ int resctrl_arch_pseudo_lock_fn(void *_plr) > * Critical section end: restore closid with capacity bitmask that > * does not overlap with pseudo-locked region. > */ > - native_wrmsr(MSR_IA32_PQR_ASSOC, rmid_p, closid_p); > + native_wrmsrq(MSR_IA32_PQR_ASSOC, rmid_p | ((u64)closid_p << 32)); > > /* Re-enable the hardware prefetcher(s) */ > wrmsrq(MSR_MISC_FEATURE_CONTROL, saved_msr); Reinette