From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A39EC433F5 for ; Fri, 1 Apr 2022 06:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343568AbiDAG6q (ORCPT ); Fri, 1 Apr 2022 02:58:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343565AbiDAG6m (ORCPT ); Fri, 1 Apr 2022 02:58:42 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B243B19F45E; Thu, 31 Mar 2022 23:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648796207; x=1680332207; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Wxp4yJ/NukfxY6U5mWq/JBboluF6jxxrl8HF3wv1pMc=; b=eKgaeZs2O26Nin60M62tJcf55tS38SGNyv7Xg65rho9I7cXRxzvxZdOV lVg8aNJEZF2y3yyLjKuIWLOBxZrzMTxKvDWvq8NEZcxOnbPHUyGhRXJHj vtEkZECGe8Ke3xqaEKSvCHumW9QirU2L9I8sHJmkDfX1ZOoiR7JOKRisO ygxoS2KdWxieN69xbmRPKK9KaubAxHUyKgvGZtrwYoBDlROy/tzMphyiv oL0NbM0gBIDKv5rkDJsKrDSOQ4ZMChYzGWCXb+ApG/NluMfoarQPv7H+z NcMh4NlIURuy9eqlDr6OYNlECy5bznV9u1zC8BHiDElGzG/Miy5e3jFTt w==; X-IronPort-AV: E=McAfee;i="6200,9189,10303"; a="260045758" X-IronPort-AV: E=Sophos;i="5.90,226,1643702400"; d="scan'208";a="260045758" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 23:56:46 -0700 X-IronPort-AV: E=Sophos;i="5.90,226,1643702400"; d="scan'208";a="567217562" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.249.171.24]) ([10.249.171.24]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 23:56:43 -0700 Message-ID: Date: Fri, 1 Apr 2022 14:56:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.6.1 Subject: Re: [RFC PATCH v5 008/104] KVM: TDX: Add a function to initialize TDX module Content-Language: en-US To: Isaku Yamahata , Kai Huang Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Jim Mattson , erdemaktas@google.com, Connor Kuehl , Sean Christopherson References: <36aac3cb7c7447db6454ee396e25eea3bad378e6.camel@intel.com> <20220331194144.GA2084469@ls.amr.corp.intel.com> From: Xiaoyao Li In-Reply-To: <20220331194144.GA2084469@ls.amr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 4/1/2022 3:41 AM, Isaku Yamahata wrote: > On Thu, Mar 31, 2022 at 04:31:10PM +1300, > Kai Huang wrote: > >> On Fri, 2022-03-04 at 11:48 -0800, isaku.yamahata@intel.com wrote: >>> From: Isaku Yamahata > >>> Add a wrapper function to initialize the TDX module and get system-wide >>> parameters via those APIs. Because TDX requires VMX enabled, It will be >>> called on-demand when the first guest TD is created via x86 KVM init_vm >>> callback. >> >> Why not just merge this patch with the change where you implement the init_vm >> callback? Then you can just declare this patch as "detect and initialize TDX >> module when first VM is created", or something like that.. > > Ok. Anyway in the next respoin, tdx module initialization will be done when > loading kvm_intel.ko. So the whole part will be changed and will be a part > of module loading. Will we change the GET_TDX_CAPABILITIES ioctl back to KVM scope?