RE: [PATCH] pps: clients: gpio: fix interrupt handling order in remove path

["Farber, Eliav" <farbere@amazon.com>]

>> @@ -228,6 +228,7 @@ static void pps_gpio_remove(struct platform_device *pdev)
>>   {
>>       struct pps_gpio_device_data *data = platform_get_drvdata(pdev);
>>
>> +     free_irq(data->irq, data);
>
> Why not just use devm_free_irq()?

As far as I understand, the main purpose of devm_*() is to provide
hands-off resource management. devm_request_irq() is intended to
eliminate the need for explicit cleanup in the remove() function by
automatically freeing the IRQ after remove() returns.

In my opinion, calling devm_free_irq() undermines the benefit of using
devm_request_irq() in the first place. If I need to explicitly free the
IRQ during remove(), then I’m no longer relying on devm’s automatic
cleanup - I’m effectively reverting to manual resource management while
still using devm-style registration, which I find unnecessary.

That said, if you still favor devm_free_irq(), I’ll revise the patch
accordingly.

Regards, Eliav