All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bodo Stroesser <bstroesser@ts.fujitsu.com>
To: linux-scsi@vger.kernel.org
Cc: kai.makisara@kolumbus.fi, bstroesser@ts.fujitsu.com
Subject: [PATCH 2/3] st.ko: remove unnecessary normalize_buffer
Date: 02 Dec 2013 20:00:44 +0100	[thread overview]
Message-ID: <d6437a$579tob@dgate10u.abg.fsc.net> (raw)

From: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Date: Mon, 2 Dec 2013 18:52:10 +0100
Subject: [PATCH 2/3] st.ko: remove unnecessary normalize_buffer

This patch removes an unnecessary call to normalize_buffer()
in enlarge_buffer()

In st_open() always a buffer of one page is allocated.
When the buffer needs to be enlarged later, it does not make
sense to free this page unconditionally.
 
Cc: Kai Makisara <kai.makisara@kolumbus.fi>
Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>

---

--- a/drivers/scsi/st.c	2013-12-02 18:52:10.000000000 +0100
+++ b/drivers/scsi/st.c	2013-12-02 18:52:10.000000000 +0100
@@ -3725,9 +3725,6 @@ static int enlarge_buffer(struct st_buff
 	if (new_size <= STbuffer->buffer_size)
 		return 1;
 
-	if (STbuffer->buffer_size <= PAGE_SIZE)
-		normalize_buffer(STbuffer);  /* Avoid extra segment */
-
 	max_segs = STbuffer->use_sg;
 
 	priority = GFP_KERNEL | __GFP_NOWARN;

             reply	other threads:[~2013-12-02 19:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 19:00 Bodo Stroesser [this message]
     [not found] <61eb00$4eu08m@dgate20u.abg.fsc.net>
2013-12-16 18:45 ` [PATCH 2/3] st.ko: remove unnecessary normalize_buffer "Kai Mäkisara (Kolumbus)"
2013-12-16 19:19   ` Strösser, Bodo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='d6437a$579tob@dgate10u.abg.fsc.net' \
    --to=bstroesser@ts.fujitsu.com \
    --cc=kai.makisara@kolumbus.fi \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.