From: Kanchan Joshi <joshi.k@samsung.com>
To: Caleb Sander Mateos <csander@purestorage.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node
Date: Tue, 22 Apr 2025 13:08:15 +0530 [thread overview]
Message-ID: <d6437a1d-8bee-4655-a7bf-e9254b2d881f@samsung.com> (raw)
In-Reply-To: <20250421165525.1618434-3-csander@purestorage.com>
On 4/21/2025 10:25 PM, Caleb Sander Mateos wrote:
> + prp_pools = &dev->prp_pools[numa_node < nr_node_ids ? numa_node : 0];
Numa node values are always in the range [0, nr_node_ids - 1], so is
this condition "numa_node < nr_node_ids" really required?
The patch looks good to me though.
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
next prev parent reply other threads:[~2025-04-22 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 16:55 [PATCH v3 0/2] nvme/pci: PRP list DMA pool partitioning Caleb Sander Mateos
2025-04-21 16:55 ` [PATCH v3 1/2] nvme/pci: factor out nvme_init_hctx() helper Caleb Sander Mateos
2025-04-22 7:38 ` Kanchan Joshi
2025-04-22 11:45 ` Sagi Grimberg
2025-04-21 16:55 ` [PATCH v3 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node Caleb Sander Mateos
2025-04-22 7:38 ` Kanchan Joshi [this message]
2025-04-22 11:48 ` Sagi Grimberg
2025-04-22 14:59 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6437a1d-8bee-4655-a7bf-e9254b2d881f@samsung.com \
--to=joshi.k@samsung.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.