From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C65D3E77A for ; Wed, 10 Dec 2025 20:16:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1183267.1506018 (Exim 4.92) (envelope-from ) id 1vTQbG-0003yt-HX; Wed, 10 Dec 2025 20:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1183267.1506018; Wed, 10 Dec 2025 20:15:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTQbG-0003ym-ES; Wed, 10 Dec 2025 20:15:50 +0000 Received: by outflank-mailman (input) for mailman id 1183267; Wed, 10 Dec 2025 20:15:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vTQbF-0003yg-69 for xen-devel@lists.xenproject.org; Wed, 10 Dec 2025 20:15:49 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03f39788-d605-11f0-b15b-2bf370ae4941; Wed, 10 Dec 2025 21:15:47 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) (Authenticated sender: nicola) by support.bugseng.com (Postfix) with ESMTPA id 34BDF4EEBC5F; Wed, 10 Dec 2025 21:15:47 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03f39788-d605-11f0-b15b-2bf370ae4941 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1765397747; b=wAnW7DL6Eg5EANgJyvr3rlG1v1sUJGiCjvdnGV8IlrVGTZu1CNXApzw2GDKqM6jPT3eF 2Zv1EW1hUL67DWWI9MQKiuDcPD8Zo2HW8x2oJdH1Bqy2AQm6eEH9pzKlsn8+Lsvngiq53 xvIPIMhJ+bNxwxO95TMhKYS48BmOUuTimq/nJJC+kwAqPlJifUIqrM75/Z9d//d8w0yTJ LzQcEiR5KYScCWtGtWkC3kLtka3D4ob5KaUbuzeXlUTc+p1sCCuUqV7Xqrjw+cDL9qQ6T a1wEgkBf0Lt9B0/0NgNDbT4FBQXAlrB4PsuyitxKfj55+fj7imZ813Q4Y8AgwTRmfk94q Nq6HoxRnMfikiIHIXHYL9B5X20Z85tNYaCwsfdYI7hYGVlfcX+qeHqj5cRgDTuoul1ID1 U55Eg8om7Y5VaCiSEfwPBOLOoMElVHPfVllXW0PQbiVfAxl8mFaT4xEHGpmlZngd2RPJS fc6xGbLwqyR05tqxwDljwfQoWpw1yxbBluJQeNGUvDiIpw0+Zv0PT785B5xdARfkxedwo DHw6+8oG7j4y/WbmN3jYZ20UooXhvW8k6xhyRMV+Z5jCgylzaq049AaIVLs0ZxVckvzUp 42h6PFj7+AnT6bD1JzSLZxAzo2miED6bb+pKWRlwcRuDkRJ4IiK3CE0xDo59mAY= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1765397747; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=5SWB32j6qN5Z3Umy5Yr9Qmzm4X0peIk85zVEJRMym+c=; b=OoNdUgXtM1ebaFWCw7F38apfrsc+O32RgB+8VbK21yt59e63iuNFBW//0TbO/NHmoeNe 0n46b6gxtQBCS4Qvj9E7RSF3vgHQ2j5ary0V+V85Vvb5/rShVRfuoMcGhv5+Fa4Fx0meY NcQn3dMvipDt/MvRwqsSPMgZDBqqEJFqYqNAdGJN3H2SOprN8QBQ9q4uvQ/e5Ezdy5iZB ZLEaTFfG1lwUPyQ4AiUVgXUfyinO1pieWWrp/wmFHy37Qw0ntkO8Ok2jeMuBzIFTmZ2AM /GHFIlP4fzS1nouQJBPeMh8Q+lRHYRr6pwpO66QIkThijzJQBbC33o3FUcAtx/K/+8Bmr MPMXvq+f1JGKvC5Raer55wcDDH8adaoRohYHj1uDV9mIh7JNMwOBoxN0eNPaS7BpEGfHP q2c5e0V/ffN/QRjMvvwFXJsTfBEIe3ZvGlYUDHbexnpTirwmr4eiLLZUMygzl1n5E0URk GTZ5yEZ1kCb86la22DKpfVUP9v67QGi7JNmXbXYK6aE19VfHqkMUlu7JBpS5pVwUn0SDr MX8tCbNNfbrt8W/bbCNAA9sq4itQGEvha+3A2/zLPeZZyGliJt8cmNpPbuqn2KM9OuWuZ JgSTLSpblwn+wTZEbZIc/18UHdKnJ/7ACnbyvb5Y34enk+0mLac7I6qC/bcnRiY= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1765397747; bh=kJg82dbXHi0byGbCOTthmUyaYivblmEJJtIZHSAv5rY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I/iPFEBmh+JHsVALv5MS5SghFa1tD5amOmPvVTtysweBGgSaVuK1e8mB0AJIGmPqH g/uAMRunekkY2Ndw+aoNfgdc8yfue9Xjkfv/Tr4qQ5vybzK1mLkOThubNE3Z3DQ9xN RwnveL0TtZbAE8SOQLp8WXEEmYmZYmsQ3AFciycBt7u+iYQsIGP5see1Xki48vz9fN c+pBbZXPe48/aNvqhgUm/1UJ9Tr101nZ+X2RnWDe9cWQzvlI8uzR681w2pGVEH8Mlx DHz6AKqzlu0pMC9Us/xTfsrs0sbwobEZ7DF29v0mO/h4S6aKsS1Qct0/7dhodAy1qX BHFxfHyIgZt1w== MIME-Version: 1.0 Date: Wed, 10 Dec 2025 21:15:47 +0100 From: Nicola Vetrini To: Andrew Cooper Cc: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , "consulting @ bugseng . com" Subject: Re: [PATCH 2/5] x86: Name parameters in function declarations In-Reply-To: <20251210183019.2241560-3-andrew.cooper3@citrix.com> References: <20251210183019.2241560-1-andrew.cooper3@citrix.com> <20251210183019.2241560-3-andrew.cooper3@citrix.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-12-10 19:30, Andrew Cooper wrote: > With the wider testing, some more violations have been spotted. This > addresses violations of Rule 8.2 (parameters must be named). > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini One nit below > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: consulting@bugseng.com > CC: Nicola Vetrini > --- > xen/arch/x86/mm/shadow/common.c | 8 ++++---- > xen/arch/x86/pv/emul-priv-op.c | 2 +- > xen/include/xen/livepatch.h | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/x86/mm/shadow/common.c > b/xen/arch/x86/mm/shadow/common.c > index 423764a32653..f2aee5be46a7 100644 > --- a/xen/arch/x86/mm/shadow/common.c > +++ b/xen/arch/x86/mm/shadow/common.c > @@ -69,11 +69,11 @@ const uint8_t sh_type_to_size[] = { > > DEFINE_PER_CPU(uint32_t,trace_shadow_path_flags); > > -static int cf_check sh_enable_log_dirty(struct domain *); > -static int cf_check sh_disable_log_dirty(struct domain *); > -static void cf_check sh_clean_dirty_bitmap(struct domain *); > +static int cf_check sh_enable_log_dirty(struct domain *d); > +static int cf_check sh_disable_log_dirty(struct domain *d); > +static void cf_check sh_clean_dirty_bitmap(struct domain *d); > > -static void cf_check shadow_update_paging_modes(struct vcpu *); > +static void cf_check shadow_update_paging_modes(struct vcpu *v); > > /* Set up the shadow-specific parts of a domain struct at start of > day. > * Called for every domain from arch_domain_create() */ > diff --git a/xen/arch/x86/pv/emul-priv-op.c > b/xen/arch/x86/pv/emul-priv-op.c > index 225d4cff03c1..08dec9990e39 100644 > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -40,7 +40,7 @@ struct priv_op_ctxt { > }; > > /* I/O emulation helpers. Use non-standard calling conventions. */ > -void nocall load_guest_gprs(struct cpu_user_regs *); > +void nocall load_guest_gprs(struct cpu_user_regs *regs); > void nocall save_guest_gprs(void); > > typedef void io_emul_stub_t(struct cpu_user_regs *); > diff --git a/xen/include/xen/livepatch.h b/xen/include/xen/livepatch.h > index d074a5bebecc..3f5ad01f1bdd 100644 > --- a/xen/include/xen/livepatch.h > +++ b/xen/include/xen/livepatch.h > @@ -62,7 +62,7 @@ struct livepatch_fstate { > uint8_t insn_buffer[LIVEPATCH_OPAQUE_SIZE]; > }; > > -int livepatch_op(struct xen_sysctl_livepatch_op *); > +int livepatch_op(struct xen_sysctl_livepatch_op *op); xen/common/livepatch.c:int livepatch_op(struct xen_sysctl_livepatch_op *livepatch) Shouldn't this decl also use "*op" as well? Might not be triggered in this configuration due to the absence of CONFIG_LIVEPATCH I think. > void check_for_livepatch_work(void); > unsigned long livepatch_symbols_lookup_by_name(const char *symname); > bool is_patch(const void *addr); -- Nicola Vetrini, B.Sc. Software Engineer BUGSENG (https://bugseng.com) LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253