From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-bluetooth@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: NXP: select CONFIG_CRC8
Date: Wed, 22 Mar 2023 14:35:07 +0200 (EET) [thread overview]
Message-ID: <d651b66d-a33b-ead0-e41-aeb76f4523b6@linux.intel.com> (raw)
In-Reply-To: <20230322111636.1028838-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
On Wed, 22 Mar 2023, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver needs both CRC32 and CRC8 to link correctly:
>
> ld.lld: error: undefined symbol: crc8_populate_msb
> >>> referenced by btnxpuart.c
> >>> drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
> ld.lld: error: undefined symbol: crc8
> >>> referenced by btnxpuart.c
> >>> drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a
>
> Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 0703bdd44140..f84322d375de 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -469,6 +469,7 @@ config BT_NXPUART
> tristate "NXP protocol support"
> depends on SERIAL_DEV_BUS
> select CRC32
> + select CRC8
> help
> NXP is serial driver required for NXP Bluetooth
> devices with UART interface.
>
Right. ...I should have realized this was missing too when I noticed
select CRC32 wasn't there.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2023-03-22 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:16 [PATCH] Bluetooth: NXP: select CONFIG_CRC8 Arnd Bergmann
2023-03-22 12:02 ` bluez.test.bot
2023-03-22 12:35 ` Ilpo Järvinen [this message]
2023-03-22 23:00 ` [PATCH] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d651b66d-a33b-ead0-e41-aeb76f4523b6@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.