From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4044AC433F5 for ; Tue, 8 Feb 2022 04:31:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E5AF460C2C; Tue, 8 Feb 2022 04:31:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H8VBWPiW1aZh; Tue, 8 Feb 2022 04:31:17 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id BFCE460BA4; Tue, 8 Feb 2022 04:31:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A2280C001A; Tue, 8 Feb 2022 04:31:16 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7D3D3C000B for ; Tue, 8 Feb 2022 04:31:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6BF6A40500 for ; Tue, 8 Feb 2022 04:31:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7rBscatYSNBZ for ; Tue, 8 Feb 2022 04:31:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by smtp2.osuosl.org (Postfix) with ESMTPS id A852640275 for ; Tue, 8 Feb 2022 04:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644294674; x=1675830674; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=sLnwdFLCJ4UV9sC7s0su5wmh+vi9Lj/1fhIUEK9dmJA=; b=CEPicDEFT3t+tPWDNF0MPnbp6zColuEf4UENBKbMeW4AaT4PDeVh/k3I zKeHTQBLdexNu8X80dWJh8pDW0+oqiIu6HYlWKXPDq90wL1qQRN+Z9B1A HaLk2c3r/lncX/cOhsjSJCKA3qTy3MJwJ3/phASwingAN2anITEvzW7Ev EibjWZn1jMknCgJYM/SCswkO2n4lgRLT//4cfeLQE6JURSnWn9htrzhaU EdtqwQlUcRM4hpH2QPXBZWf58MKMZpvIu8waTneSPzFX3bwHL2ih7heFS rCaEyh3Y4/FlVA5npZS8dWjb27j49OFi4B5u1RJD3uXn/JuCbJ+s4ljFy Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="229517314" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="229517314" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 20:31:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="677985554" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by fmsmga001.fm.intel.com with ESMTP; 07 Feb 2022 20:31:07 -0800 Message-ID: Date: Tue, 8 Feb 2022 12:29:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1 04/10] iommu/vt-d: Remove iova_cache_get/put() Content-Language: en-US To: John Garry , Joerg Roedel , Kevin Tian , Ashok Raj , Liu Yi L , Jacob Pan References: <20220207064142.1092846-1-baolu.lu@linux.intel.com> <20220207064142.1092846-5-baolu.lu@linux.intel.com> From: Lu Baolu In-Reply-To: Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jason Gunthorpe , Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMi83LzIyIDY6MzkgUE0sIEpvaG4gR2Fycnkgd3JvdGU6Cj4gT24gMDcvMDIvMjAyMiAwNjo0 MSwgTHUgQmFvbHUgd3JvdGU6Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lvbW11L2ludGVsL2lv bW11LmMgYi9kcml2ZXJzL2lvbW11L2ludGVsL2lvbW11LmMKPj4gaW5kZXggNTgzZWMwZmE0YWMx Li5lOGQ1ODY1NDM2MWMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvaW9tbXUvaW50ZWwvaW9tbXUu Ywo+PiArKysgYi9kcml2ZXJzL2lvbW11L2ludGVsL2lvbW11LmMKPj4gQEAgLTMzNDgsOSArMzM0 OCw2IEBAIHN0YXRpYyBpbmxpbmUgaW50IGlvbW11X2RldmluZm9fY2FjaGVfaW5pdCh2b2lkKQo+ PiDCoCBzdGF0aWMgaW50IF9faW5pdCBpb21tdV9pbml0X21lbXBvb2wodm9pZCkKPj4gwqAgewo+ PiDCoMKgwqDCoMKgIGludCByZXQ7Cj4+IC3CoMKgwqAgcmV0ID0gaW92YV9jYWNoZV9nZXQoKTsK Pj4gLcKgwqDCoCBpZiAocmV0KQo+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsKPj4gwqDC oMKgwqDCoCByZXQgPSBpb21tdV9kb21haW5fY2FjaGVfaW5pdCgpOwo+PiDCoMKgwqDCoMKgIGlm IChyZXQpCj4+IEBAIC0zMzYyLDcgKzMzNTksNiBAQCBzdGF0aWMgaW50IF9faW5pdCBpb21tdV9p bml0X21lbXBvb2wodm9pZCkKPj4gwqDCoMKgwqDCoCBrbWVtX2NhY2hlX2Rlc3Ryb3koaW9tbXVf ZG9tYWluX2NhY2hlKTsKPj4gwqAgZG9tYWluX2Vycm9yOgo+IAo+IG5pdDogaXMgdGhpcyBsYWJl bCBzdGlsbCByZWFsbHkgcmVxdWlyZWQ/IG9ubHkgZmFpbHVyZXMgaW4gCj4gaW9tbXVfZG9tYWlu X2NhY2hlX2luaXQoKSBqdW1wIHRvIGl0LCBhbmQgdGhhdCBjYW4gcmV0dXJuIGRpcmVjdGx5IG5v dy4KCkl0IHdpbGwgYmUgY2xlYW5lZCB1cCBpbiB0aGUgbmV4dCBwYXRjaC4KCj4gCj4gVGhhbmtz LAo+IEpvaG4KPiAKPj4gLcKgwqDCoCBpb3ZhX2NhY2hlX3B1dCgpOwo+IAoKQmVzdCByZWdhcmRz LApiYW9sdQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpp b21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6 Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D43A9C433EF for ; Tue, 8 Feb 2022 04:31:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346941AbiBHEbO (ORCPT ); Mon, 7 Feb 2022 23:31:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234088AbiBHEbL (ORCPT ); Mon, 7 Feb 2022 23:31:11 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 149AAC0401DC for ; Mon, 7 Feb 2022 20:31:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644294671; x=1675830671; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=sLnwdFLCJ4UV9sC7s0su5wmh+vi9Lj/1fhIUEK9dmJA=; b=CcreWIs7Igj61y8rLAWOaAPyM9uUg8S9CekjAmqzHdPYRA1Ms6QHlnZK Z1IY1OvwESheVO7xKeVKZFmJEWswsB2eluc3ualSBc0Kj7XuuLEW4RENh cNuIY2RG5hOEnlu+JSBZ6JRV0YPj0uk2wvtblrENtESPjUYJ4AgTbzU+0 rfVFo4+MLMiMasJlx0Zce5VCRoGroqp/G1wwnccaYtpmQgJJHco9Vwxgj KK6Ahet/c7r+dTTqhBjMJflOVs3daYWaKFZJ/aDe0oA3n3YJmbAzd/SZh 01BtdTzJkDctUCrnhvqZ+rnxKDag/yoITpJ2QQl81qisb3HtusoKDfCLS w==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="236275232" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="236275232" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 20:31:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="677985554" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by fmsmga001.fm.intel.com with ESMTP; 07 Feb 2022 20:31:07 -0800 Message-ID: Date: Tue, 8 Feb 2022 12:29:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jason Gunthorpe , Robin Murphy , Christoph Hellwig Subject: Re: [PATCH v1 04/10] iommu/vt-d: Remove iova_cache_get/put() Content-Language: en-US To: John Garry , Joerg Roedel , Kevin Tian , Ashok Raj , Liu Yi L , Jacob Pan References: <20220207064142.1092846-1-baolu.lu@linux.intel.com> <20220207064142.1092846-5-baolu.lu@linux.intel.com> From: Lu Baolu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/7/22 6:39 PM, John Garry wrote: > On 07/02/2022 06:41, Lu Baolu wrote: >> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c >> index 583ec0fa4ac1..e8d58654361c 100644 >> --- a/drivers/iommu/intel/iommu.c >> +++ b/drivers/iommu/intel/iommu.c >> @@ -3348,9 +3348,6 @@ static inline int iommu_devinfo_cache_init(void) >>   static int __init iommu_init_mempool(void) >>   { >>       int ret; >> -    ret = iova_cache_get(); >> -    if (ret) >> -        return ret; >>       ret = iommu_domain_cache_init(); >>       if (ret) >> @@ -3362,7 +3359,6 @@ static int __init iommu_init_mempool(void) >>       kmem_cache_destroy(iommu_domain_cache); >>   domain_error: > > nit: is this label still really required? only failures in > iommu_domain_cache_init() jump to it, and that can return directly now. It will be cleaned up in the next patch. > > Thanks, > John > >> -    iova_cache_put(); > Best regards, baolu