diff for duplicates of <d6591d1e-c568-dfcd-d162-03b60ae528cb@users.sourceforge.net> diff --git a/a/1.txt b/N1/1.txt index 84dbc1a..d7e2597 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -23,7 +23,7 @@ index 6192f0718bf2..0eaf79c625c6 100644 packet_buffer_init(struct packet_buffer *buffer, size_t capacity) { buffer->data = kmalloc(capacity, GFP_KERNEL); -- if (buffer->data = NULL) +- if (buffer->data == NULL) + if (!buffer->data) return -ENOMEM; buffer->head = (struct packet *) buffer->data; @@ -32,12 +32,12 @@ index 6192f0718bf2..0eaf79c625c6 100644 break; } mutex_unlock(&card_mutex); -- if (lynx = NULL) +- if (lynx == NULL) + if (!lynx) return -ENODEV; client = kmalloc(sizeof *client, GFP_KERNEL); -- if (client = NULL) +- if (client == NULL) + if (!client) goto fail; @@ -46,7 +46,7 @@ index 6192f0718bf2..0eaf79c625c6 100644 pci_set_master(dev); lynx = kzalloc(sizeof *lynx, GFP_KERNEL); -- if (lynx = NULL) { +- if (lynx == NULL) { + if (!lynx) { ret = -ENOMEM; goto fail_disable; @@ -55,7 +55,7 @@ index 6192f0718bf2..0eaf79c625c6 100644 lynx->registers = ioremap_nocache(pci_resource_start(dev, 0), PCILYNX_MAX_REGISTER); -- if (lynx->registers = NULL) { +- if (lynx->registers == NULL) { + if (!lynx->registers) { dev_err(&dev->dev, "Failed to map registers\n"); ret = -ENOMEM; @@ -64,9 +64,9 @@ index 6192f0718bf2..0eaf79c625c6 100644 sizeof(struct pcl), &lynx->rcv_pcl_bus); lynx->rcv_buffer = pci_alloc_consistent(lynx->pci_device, RCV_BUFFER_SIZE, &lynx->rcv_buffer_bus); -- if (lynx->rcv_start_pcl = NULL || -- lynx->rcv_pcl = NULL || -- lynx->rcv_buffer = NULL) { +- if (lynx->rcv_start_pcl == NULL || +- lynx->rcv_pcl == NULL || +- lynx->rcv_buffer == NULL) { + if (!lynx->rcv_start_pcl || !lynx->rcv_pcl || !lynx->rcv_buffer) { dev_err(&dev->dev, "Failed to allocate receive buffer\n"); ret = -ENOMEM; diff --git a/a/content_digest b/N1/content_digest index 1da88ba..512a86e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0c4e817a2-1554-2480-9469-9d06543b1eee@users.sourceforge.net\0" "From\0SF Markus Elfring <elfring@users.sourceforge.net>\0" "Subject\0[PATCH 2/2] firewire: nosy: Adjust eight checks for null pointers\0" - "Date\0Tue, 13 Feb 2018 18:34:53 +0000\0" + "Date\0Tue, 13 Feb 2018 19:34:53 +0100\0" "To\0linux1394-devel@lists.sourceforge.net" " Stefan Richter <stefanr@s5r6.in-berlin.de>\0" "Cc\0LKML <linux-kernel@vger.kernel.org>" @@ -33,7 +33,7 @@ " packet_buffer_init(struct packet_buffer *buffer, size_t capacity)\n" " {\n" " \tbuffer->data = kmalloc(capacity, GFP_KERNEL);\n" - "-\tif (buffer->data = NULL)\n" + "-\tif (buffer->data == NULL)\n" "+\tif (!buffer->data)\n" " \t\treturn -ENOMEM;\n" " \tbuffer->head = (struct packet *) buffer->data;\n" @@ -42,12 +42,12 @@ " \t\t\tbreak;\n" " \t\t}\n" " \tmutex_unlock(&card_mutex);\n" - "-\tif (lynx = NULL)\n" + "-\tif (lynx == NULL)\n" "+\tif (!lynx)\n" " \t\treturn -ENODEV;\n" " \n" " \tclient = kmalloc(sizeof *client, GFP_KERNEL);\n" - "-\tif (client = NULL)\n" + "-\tif (client == NULL)\n" "+\tif (!client)\n" " \t\tgoto fail;\n" " \n" @@ -56,7 +56,7 @@ " \tpci_set_master(dev);\n" " \n" " \tlynx = kzalloc(sizeof *lynx, GFP_KERNEL);\n" - "-\tif (lynx = NULL) {\n" + "-\tif (lynx == NULL) {\n" "+\tif (!lynx) {\n" " \t\tret = -ENOMEM;\n" " \t\tgoto fail_disable;\n" @@ -65,7 +65,7 @@ " \n" " \tlynx->registers = ioremap_nocache(pci_resource_start(dev, 0),\n" " \t\t\t\t\t PCILYNX_MAX_REGISTER);\n" - "-\tif (lynx->registers = NULL) {\n" + "-\tif (lynx->registers == NULL) {\n" "+\tif (!lynx->registers) {\n" " \t\tdev_err(&dev->dev, \"Failed to map registers\\n\");\n" " \t\tret = -ENOMEM;\n" @@ -74,9 +74,9 @@ " \t\t\t\tsizeof(struct pcl), &lynx->rcv_pcl_bus);\n" " \tlynx->rcv_buffer = pci_alloc_consistent(lynx->pci_device,\n" " \t\t\t\tRCV_BUFFER_SIZE, &lynx->rcv_buffer_bus);\n" - "-\tif (lynx->rcv_start_pcl = NULL ||\n" - "-\t lynx->rcv_pcl = NULL ||\n" - "-\t lynx->rcv_buffer = NULL) {\n" + "-\tif (lynx->rcv_start_pcl == NULL ||\n" + "-\t lynx->rcv_pcl == NULL ||\n" + "-\t lynx->rcv_buffer == NULL) {\n" "+\tif (!lynx->rcv_start_pcl || !lynx->rcv_pcl || !lynx->rcv_buffer) {\n" " \t\tdev_err(&dev->dev, \"Failed to allocate receive buffer\\n\");\n" " \t\tret = -ENOMEM;\n" @@ -84,4 +84,4 @@ "-- \n" 2.16.1 -d18ac617e7498677a1ec1c914c73cd7a7cecf46076330d196e975c1362c7137d +3c56dcbac4ca818b97e6f1d20bda4f9c592acad662aa8f5e2860959b31209064
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.