From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH v2] cansniffer: totally untested hack to reduce display update by factor of 10 Date: Tue, 24 Jun 2014 18:44:07 +0200 Message-ID: References: <1403627167-28287-1-git-send-email-mkl@pengutronix.de> <53A9A96E.5030407@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:60997 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756379AbaFXQoL (ORCPT ); Tue, 24 Jun 2014 12:44:11 -0400 In-Reply-To: <53A9A96E.5030407@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp , felix.seitz@thm-motorsport.de Cc: linux-can@vger.kernel.org On 24 June 2014 18:38:06 CEST, Oliver Hartkopp wrote: >I'll check it and give a feedback. > >Btw. it needs a v3: > >> /* time defaults */ >> >> -#define TIMEOUT 50 /* in 100ms */ >> -#define HOLD 10 /* in 100ms */ >> -#define LOOP 2 /* in 100ms */ >> +#define TIMEOUT 500 /* in 10ms */ >> +#define HOLD 100 /* in 10ms */ >> +#define LOOP 2 /* in 10ms */ > >LOOP has to be *10 too. Yes, if we want unchanged behaviour, which would be better for mainlining. With my patch the default is now 20ms. Marc