From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Suma Hegde <suma.hegde@amd.com>
Cc: platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Naveen Krishna Chatradhi <nchatrad@amd.com>
Subject: Re: [PATCH v5 11/11] platform/x86/amd/hsmp: Remove extra parenthesis and add a space
Date: Wed, 24 Jan 2024 14:25:25 +0200 (EET) [thread overview]
Message-ID: <d66af894-e1d7-d045-0600-21386262dd41@linux.intel.com> (raw)
In-Reply-To: <20240106022532.1746932-11-suma.hegde@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]
On Sat, 6 Jan 2024, Suma Hegde wrote:
> Remove unnecessary parenthesis around hsmp_get_tbl_dram_base().
>
> Signed-off-by: Suma Hegde <suma.hegde@amd.com>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
> ---
> Changes since v4:
> New patch, generated after splitting the 9th patch in v4 series
>
> drivers/platform/x86/amd/hsmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c
> index ccf7cd8f98f6..99a34b48f78f 100644
> --- a/drivers/platform/x86/amd/hsmp.c
> +++ b/drivers/platform/x86/amd/hsmp.c
> @@ -643,12 +643,12 @@ static int hsmp_init_metric_tbl_bin_attr(struct bin_attribute **hattrs, u16 sock
> hattrs[0] = hattr;
>
> if (plat_dev.proto_ver == HSMP_PROTO_VER6)
> - return (hsmp_get_tbl_dram_base(sock_ind));
> + return hsmp_get_tbl_dram_base(sock_ind);
> else
> return 0;
> }
>
> -/* One bin sysfs for metrics table*/
> +/* One bin sysfs for metrics table */
> #define NUM_HSMP_ATTRS 1
>
> static int hsmp_create_attr_list(struct attribute_group *attr_grp,
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
prev parent reply other threads:[~2024-01-24 12:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 2:25 [PATCH v5 01/11] platform/x86/amd/hsmp: Move hsmp_test to probe Suma Hegde
2024-01-06 2:25 ` [PATCH v5 02/11] platform/x86/amd/hsmp: Cache pci_dev in struct hsmp_socket Suma Hegde
2024-01-06 2:25 ` [PATCH v5 03/11] platform/x86/amd/hsmp: Create static func to handle platdev Suma Hegde
2024-01-06 2:25 ` [PATCH v5 04/11] platform/x86/amd/hsmp: Define a struct to hold mailbox regs Suma Hegde
2024-01-06 2:25 ` [PATCH v5 05/11] platform/x86/amd/hsmp: Move dev from platdev to hsmp_socket Suma Hegde
2024-01-06 2:25 ` [PATCH v5 06/11] platform/x86/amd/hsmp: Restructure sysfs group creation Suma Hegde
2024-01-24 12:34 ` Ilpo Järvinen
2024-01-06 2:25 ` [PATCH v5 07/11] platform/x86/amd/hsmp: Add support for ACPI based probing Suma Hegde
2024-01-24 13:02 ` Ilpo Järvinen
2024-01-06 2:25 ` [PATCH v5 08/11] platform/x86/amd/hsmp: Non-ACPI support for AMD F1A_M00~0Fh Suma Hegde
2024-01-06 2:25 ` [PATCH v5 09/11] platform/x86/amd/hsmp: Check num_sockets against MAX_AMD_SOCKETS Suma Hegde
2024-01-06 2:25 ` [PATCH v5 10/11] platform/x86/amd/hsmp: Change devm_kzalloc() to devm_kcalloc() Suma Hegde
2024-01-24 12:29 ` Ilpo Järvinen
2024-01-25 12:33 ` Ilpo Järvinen
2024-01-29 12:44 ` Ilpo Järvinen
2024-01-29 13:24 ` Hegde, Suma
2024-01-31 10:32 ` Ilpo Järvinen
2024-02-06 6:38 ` Hegde, Suma
2024-02-06 9:04 ` Ilpo Järvinen
2024-02-06 9:46 ` Hegde, Suma
2024-01-06 2:25 ` [PATCH v5 11/11] platform/x86/amd/hsmp: Remove extra parenthesis and add a space Suma Hegde
2024-01-24 12:25 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66af894-e1d7-d045-0600-21386262dd41@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=nchatrad@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=suma.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.