From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Date: Tue, 28 Jan 2020 18:59:48 +0300 Message-ID: References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200128004301.GD20624@richard> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200128004301.GD20624@richard> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wei Yang , Russell King - ARM Linux Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org, kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org, yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org, thellstrom-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, Thierry Reding , Jon Hunter , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-tegra@vger.kernel.org 28.01.2020 03:43, Wei Yang пишет: > On Sun, Jan 26, 2020 at 05:47:57PM +0300, Dmitry Osipenko wrote: >> 18.01.2020 02:22, Wei Yang пишет: >>> Use the general helper instead of do it by hand. >>> >>> Signed-off-by: Wei Yang >>> --- >>> mm/mremap.c | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/mm/mremap.c b/mm/mremap.c >>> index c2af8ba4ba43..a258914f3ee1 100644 >>> --- a/mm/mremap.c >>> +++ b/mm/mremap.c >>> @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_area_struct *vma, >>> >>> for (; old_addr < old_end; old_addr += extent, new_addr += extent) { >>> cond_resched(); >>> - next = (old_addr + PMD_SIZE) & PMD_MASK; >>> - /* even if next overflowed, extent below will be ok */ >>> + next = pmd_addr_end(old_addr, old_end); >>> extent = next - old_addr; >>> - if (extent > old_end - old_addr) >>> - extent = old_end - old_addr; >>> old_pmd = get_old_pmd(vma->vm_mm, old_addr); >>> if (!old_pmd) >>> continue; >>> @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area_struct *vma, >>> >>> if (pte_alloc(new_vma->vm_mm, new_pmd)) >>> break; >>> - next = (new_addr + PMD_SIZE) & PMD_MASK; >>> + next = pmd_addr_end(new_addr, new_addr + len); >>> if (extent > next - new_addr) >>> extent = next - new_addr; >>> move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, >>> >> >> Hello Wei, >> >> Starting with next-20200122, I'm seeing the following in KMSG on NVIDIA >> Tegra (ARM32): >> >> BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 >> > > Thanks. > > Would you mind letting me know which case you are testing? Nothing special, systemd starts to fall apart during boot. > Or the special thing is 32-bit platform? I have a limited knowledge about mm/, so can't provide detailed explanation. Please take a look at this: [1] https://elixir.bootlin.com/linux/v5.5/source/arch/arm/include/asm/pgtable-2level.h#L210 [2] https://elixir.bootlin.com/linux/v5.5/source/include/asm-generic/pgtable.h#L549 [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c0ba10b512eb2e2a3888b6e6cc0e089f5e7a191b From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D5CC2D0DB for ; Tue, 28 Jan 2020 16:00:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5291E21739 for ; Tue, 28 Jan 2020 16:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iVM9y715"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lIAeCkFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5291E21739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wYXTY9veGBKlEKS+a+/ssysQuUJ/vtOgv/zkuvvWLH8=; b=iVM9y715B0PCjU KHYiYCrtm3HGz1SbZkPDgGrNo7aXSS1A+xDRA0i4E/b4vjCeFXWqUvpSYVECdQP8SQs8BmWTYK0hb 2JiGEfZhhTt2xE4vphdrsHEzeHrvyW6H/cU3Jt91JRroVgiFNxY1zCI8sH2VhHqPHsghxqawUdWDm hkJuBnanIvnwdrxqq5mxoO26p/3eLYmNdpEIMVvDmxjT0l47F9GM/ibZ81GIeLG3dd4Z30f5Ej3Pc ij17pAyLc0wPOfIvbtLXQQAhr8l1LIChh/u92+oxdwCYBPKBAhF8pjYqD36Fgb1quacDWNVBNH80A wE4nOXL7FvvSFzEee3Lg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwTHV-0006kW-5R; Tue, 28 Jan 2020 16:00:01 +0000 Received: from mail-il1-x143.google.com ([2607:f8b0:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwTHR-0006j2-T4 for linux-arm-kernel@lists.infradead.org; Tue, 28 Jan 2020 15:59:59 +0000 Received: by mail-il1-x143.google.com with SMTP id l4so11058061ilj.1 for ; Tue, 28 Jan 2020 07:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w4ohonp6++tc7WV/sPZwKkfZN7aW1XO2ASROEv1nRiU=; b=lIAeCkFhXtKcaKTzDLsiXbW2Ul2ROk9tb5PwiMDl/qJCGJ+ZSMAIZoTnpN8/KjHmuX SxlWPSts47s3FdhN9qe/baojNFdM5XSVtWYqE36fQmaZ25sLCxCD3MZbBrRjSaI+iQWK PlR/1AkzKpzTO4qNV7w57wm3961oum3bDHlO5GyL25C09Ec+87//WpH+YDxd80rhkqXr 6I4Hm3J2nwoHXsQODKt+oEjzDYJJcVkKYNBeG/Q4nl/Qd/MFXh9ia5l6qmfIRqYWr/7s Q5SxKAzQ/giBRAgiB8iPG8CiaU57GF9fu98xJknuguPQs9aWZVc7+D6RGo7hieBAeDDH +LnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w4ohonp6++tc7WV/sPZwKkfZN7aW1XO2ASROEv1nRiU=; b=F8hNBGv0NrDM2+PoHMoPB5cVRxVJi9vJ2UzE24/65hmXkgwcdDtzHwDFk6+a3wfzby OxCkM2OJmm4pqPm2LAumM1ZfTEye8qiuWVD/Zdn9887hhOWdag7M+pRxD8peD92Fj5Pk qfVGemgt48spYx+ZlKBxfl+99Ug+HEwPybLh3at6E5GlnoJbrKXefwWuKnznjnOwry6B 3EFY/GK9Qx6sIhfTOt6D5/BxsJ02G9zb80anyROGbYBQxUHAslypAzXjRYMO9P32e8i3 dPMC4GqZUezyw91z4bmjr+OP5EgF8+EfQNoupZU36JgVeMsIjefCVlhYdDZ8g0fcDOqg bh5Q== X-Gm-Message-State: APjAAAVsOz8YZTitR8h1t4k7S9JddxpzN6GVka4kQnpPR+fBdDodOxwe TtPF0ikldwams/unAec0O4Uw072j X-Google-Smtp-Source: APXvYqwEH+xXx7KfDR76ROthSQWmNYsqJe8W5aR8XGWqgGAr0ee4xhb+Ck7XnHVGnn3Ly4TJztRBFg== X-Received: by 2002:a92:3cc3:: with SMTP id j64mr12118361ilf.160.1580227194744; Tue, 28 Jan 2020 07:59:54 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id e23sm1828838ild.37.2020.01.28.07.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 07:59:54 -0800 (PST) Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() To: Wei Yang , Russell King - ARM Linux References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200128004301.GD20624@richard> From: Dmitry Osipenko Message-ID: Date: Tue, 28 Jan 2020 18:59:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200128004301.GD20624@richard> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200128_075957_942471_86302832 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thellstrom@vmware.com, yang.shi@linux.alibaba.com, aneesh.kumar@linux.ibm.com, linux-kernel@vger.kernel.org, Jon Hunter , linux-mm@kvack.org, Thierry Reding , "linux-tegra@vger.kernel.org" , kirill@shutemov.name, akpm@linux-foundation.org, dan.j.williams@intel.com, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjguMDEuMjAyMCAwMzo0MywgV2VpIFlhbmcg0L/QuNGI0LXRgjoKPiBPbiBTdW4sIEphbiAyNiwg MjAyMCBhdCAwNTo0Nzo1N1BNICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IDE4LjAx LjIwMjAgMDI6MjIsIFdlaSBZYW5nINC/0LjRiNC10YI6Cj4+PiBVc2UgdGhlIGdlbmVyYWwgaGVs cGVyIGluc3RlYWQgb2YgZG8gaXQgYnkgaGFuZC4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBXZWkg WWFuZyA8cmljaGFyZHcueWFuZ0BsaW51eC5pbnRlbC5jb20+Cj4+PiAtLS0KPj4+ICBtbS9tcmVt YXAuYyB8IDcgKystLS0tLQo+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDUg ZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL21tL21yZW1hcC5jIGIvbW0vbXJlbWFw LmMKPj4+IGluZGV4IGMyYWY4YmE0YmE0My4uYTI1ODkxNGYzZWUxIDEwMDY0NAo+Pj4gLS0tIGEv bW0vbXJlbWFwLmMKPj4+ICsrKyBiL21tL21yZW1hcC5jCj4+PiBAQCAtMjUzLDExICsyNTMsOCBA QCB1bnNpZ25lZCBsb25nIG1vdmVfcGFnZV90YWJsZXMoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2 bWEsCj4+PiAgCj4+PiAgCWZvciAoOyBvbGRfYWRkciA8IG9sZF9lbmQ7IG9sZF9hZGRyICs9IGV4 dGVudCwgbmV3X2FkZHIgKz0gZXh0ZW50KSB7Cj4+PiAgCQljb25kX3Jlc2NoZWQoKTsKPj4+IC0J CW5leHQgPSAob2xkX2FkZHIgKyBQTURfU0laRSkgJiBQTURfTUFTSzsKPj4+IC0JCS8qIGV2ZW4g aWYgbmV4dCBvdmVyZmxvd2VkLCBleHRlbnQgYmVsb3cgd2lsbCBiZSBvayAqLwo+Pj4gKwkJbmV4 dCA9IHBtZF9hZGRyX2VuZChvbGRfYWRkciwgb2xkX2VuZCk7Cj4+PiAgCQlleHRlbnQgPSBuZXh0 IC0gb2xkX2FkZHI7Cj4+PiAtCQlpZiAoZXh0ZW50ID4gb2xkX2VuZCAtIG9sZF9hZGRyKQo+Pj4g LQkJCWV4dGVudCA9IG9sZF9lbmQgLSBvbGRfYWRkcjsKPj4+ICAJCW9sZF9wbWQgPSBnZXRfb2xk X3BtZCh2bWEtPnZtX21tLCBvbGRfYWRkcik7Cj4+PiAgCQlpZiAoIW9sZF9wbWQpCj4+PiAgCQkJ Y29udGludWU7Cj4+PiBAQCAtMzAxLDcgKzI5OCw3IEBAIHVuc2lnbmVkIGxvbmcgbW92ZV9wYWdl X3RhYmxlcyhzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwKPj4+ICAKPj4+ICAJCWlmIChwdGVf YWxsb2MobmV3X3ZtYS0+dm1fbW0sIG5ld19wbWQpKQo+Pj4gIAkJCWJyZWFrOwo+Pj4gLQkJbmV4 dCA9IChuZXdfYWRkciArIFBNRF9TSVpFKSAmIFBNRF9NQVNLOwo+Pj4gKwkJbmV4dCA9IHBtZF9h ZGRyX2VuZChuZXdfYWRkciwgbmV3X2FkZHIgKyBsZW4pOwo+Pj4gIAkJaWYgKGV4dGVudCA+IG5l eHQgLSBuZXdfYWRkcikKPj4+ICAJCQlleHRlbnQgPSBuZXh0IC0gbmV3X2FkZHI7Cj4+PiAgCQlt b3ZlX3B0ZXModm1hLCBvbGRfcG1kLCBvbGRfYWRkciwgb2xkX2FkZHIgKyBleHRlbnQsIG5ld192 bWEsCj4+Pgo+Pgo+PiBIZWxsbyBXZWksCj4+Cj4+IFN0YXJ0aW5nIHdpdGggbmV4dC0yMDIwMDEy MiwgSSdtIHNlZWluZyB0aGUgZm9sbG93aW5nIGluIEtNU0cgb24gTlZJRElBCj4+IFRlZ3JhIChB Uk0zMik6Cj4+Cj4+ICBCVUc6IEJhZCByc3MtY291bnRlciBzdGF0ZSBtbToocHRydmFsKSB0eXBl Ok1NX0FOT05QQUdFUyB2YWw6MTkwCj4+Cj4gCj4gVGhhbmtzLgo+IAo+IFdvdWxkIHlvdSBtaW5k IGxldHRpbmcgbWUga25vdyB3aGljaCBjYXNlIHlvdSBhcmUgdGVzdGluZz8KCk5vdGhpbmcgc3Bl Y2lhbCwgc3lzdGVtZCBzdGFydHMgdG8gZmFsbCBhcGFydCBkdXJpbmcgYm9vdC4KCj4gT3IgdGhl IHNwZWNpYWwgdGhpbmcgaXMgMzItYml0IHBsYXRmb3JtPwpJIGhhdmUgYSBsaW1pdGVkIGtub3ds ZWRnZSBhYm91dCBtbS8sIHNvIGNhbid0IHByb3ZpZGUgZGV0YWlsZWQgZXhwbGFuYXRpb24uCgpQ bGVhc2UgdGFrZSBhIGxvb2sgYXQgdGhpczoKClsxXQpodHRwczovL2VsaXhpci5ib290bGluLmNv bS9saW51eC92NS41L3NvdXJjZS9hcmNoL2FybS9pbmNsdWRlL2FzbS9wZ3RhYmxlLTJsZXZlbC5o I0wyMTAKClsyXQpodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC92NS41L3NvdXJjZS9p bmNsdWRlL2FzbS1nZW5lcmljL3BndGFibGUuaCNMNTQ5CgpbM10KaHR0cHM6Ly9naXQua2VybmVs Lm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L2NvbW1pdC8/ aWQ9YzBiYTEwYjUxMmViMmUyYTM4ODhiNmU2Y2MwZTA4OWY1ZTdhMTkxYgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C509C33CB3 for ; Tue, 28 Jan 2020 15:59:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C259421739 for ; Tue, 28 Jan 2020 15:59:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lIAeCkFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C259421739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 561396B000C; Tue, 28 Jan 2020 10:59:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E9DD6B000D; Tue, 28 Jan 2020 10:59:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38BCB6B000E; Tue, 28 Jan 2020 10:59:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id 1FE886B000C for ; Tue, 28 Jan 2020 10:59:56 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id DBD342479 for ; Tue, 28 Jan 2020 15:59:55 +0000 (UTC) X-FDA: 76427503950.13.leaf11_1c735cb32c838 X-HE-Tag: leaf11_1c735cb32c838 X-Filterd-Recvd-Size: 5967 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Jan 2020 15:59:55 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id x2so7348335ila.9 for ; Tue, 28 Jan 2020 07:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w4ohonp6++tc7WV/sPZwKkfZN7aW1XO2ASROEv1nRiU=; b=lIAeCkFhXtKcaKTzDLsiXbW2Ul2ROk9tb5PwiMDl/qJCGJ+ZSMAIZoTnpN8/KjHmuX SxlWPSts47s3FdhN9qe/baojNFdM5XSVtWYqE36fQmaZ25sLCxCD3MZbBrRjSaI+iQWK PlR/1AkzKpzTO4qNV7w57wm3961oum3bDHlO5GyL25C09Ec+87//WpH+YDxd80rhkqXr 6I4Hm3J2nwoHXsQODKt+oEjzDYJJcVkKYNBeG/Q4nl/Qd/MFXh9ia5l6qmfIRqYWr/7s Q5SxKAzQ/giBRAgiB8iPG8CiaU57GF9fu98xJknuguPQs9aWZVc7+D6RGo7hieBAeDDH +LnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w4ohonp6++tc7WV/sPZwKkfZN7aW1XO2ASROEv1nRiU=; b=K+mza+sLzpVpRcH5F0JkoOFkKjh4i3ChBSCJvgGags3Yz0Eg1Thbg5CYA54RmpDP0Z 3t0q/slaeX1iUkSiygGgRkBRNWckqOvXt06WCPq5zaixbdBv+I5H3IeBxckMo9OQGfHB 4gDCtLkflS8tN2MupQWS54fGR24+FKbWSGsuLwpnbX2wV9TvR+ArMdbmHTH0CnE0/xHh VaUSx5YiKPENbHGD3NyT+wJgjOgfVr6EI47v09MsiJQpgi6E7QNFEWsS5zuDAQ3ZIl7M kM4CEocd+zyc0tcvTwxiaStwNgQhD+cBbnwBUq1zrXNZetuo/mCc2Asm3BLsGMrJ3WAT O7Mg== X-Gm-Message-State: APjAAAVzNBiL8x9E+XN54XbzTz9R4PLhLRbIQlP8k/MpCRyp9mg3ifb1 Zwn6yVXbBcNrlALfaOXTG04= X-Google-Smtp-Source: APXvYqwEH+xXx7KfDR76ROthSQWmNYsqJe8W5aR8XGWqgGAr0ee4xhb+Ck7XnHVGnn3Ly4TJztRBFg== X-Received: by 2002:a92:3cc3:: with SMTP id j64mr12118361ilf.160.1580227194744; Tue, 28 Jan 2020 07:59:54 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id e23sm1828838ild.37.2020.01.28.07.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 07:59:54 -0800 (PST) Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() To: Wei Yang , Russell King - ARM Linux Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, yang.shi@linux.alibaba.com, thellstrom@vmware.com, Thierry Reding , Jon Hunter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200128004301.GD20624@richard> From: Dmitry Osipenko Message-ID: Date: Tue, 28 Jan 2020 18:59:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200128004301.GD20624@richard> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 28.01.2020 03:43, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Sun, Jan 26, 2020 at 05:47:57PM +0300, Dmitry Osipenko wrote: >> 18.01.2020 02:22, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> Use the general helper instead of do it by hand. >>> >>> Signed-off-by: Wei Yang >>> --- >>> mm/mremap.c | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/mm/mremap.c b/mm/mremap.c >>> index c2af8ba4ba43..a258914f3ee1 100644 >>> --- a/mm/mremap.c >>> +++ b/mm/mremap.c >>> @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_area_st= ruct *vma, >>> =20 >>> for (; old_addr < old_end; old_addr +=3D extent, new_addr +=3D exte= nt) { >>> cond_resched(); >>> - next =3D (old_addr + PMD_SIZE) & PMD_MASK; >>> - /* even if next overflowed, extent below will be ok */ >>> + next =3D pmd_addr_end(old_addr, old_end); >>> extent =3D next - old_addr; >>> - if (extent > old_end - old_addr) >>> - extent =3D old_end - old_addr; >>> old_pmd =3D get_old_pmd(vma->vm_mm, old_addr); >>> if (!old_pmd) >>> continue; >>> @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area_str= uct *vma, >>> =20 >>> if (pte_alloc(new_vma->vm_mm, new_pmd)) >>> break; >>> - next =3D (new_addr + PMD_SIZE) & PMD_MASK; >>> + next =3D pmd_addr_end(new_addr, new_addr + len); >>> if (extent > next - new_addr) >>> extent =3D next - new_addr; >>> move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, >>> >> >> Hello Wei, >> >> Starting with next-20200122, I'm seeing the following in KMSG on NVIDI= A >> Tegra (ARM32): >> >> BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 >> >=20 > Thanks. >=20 > Would you mind letting me know which case you are testing? Nothing special, systemd starts to fall apart during boot. > Or the special thing is 32-bit platform? I have a limited knowledge about mm/, so can't provide detailed explanati= on. Please take a look at this: [1] https://elixir.bootlin.com/linux/v5.5/source/arch/arm/include/asm/pgtable= -2level.h#L210 [2] https://elixir.bootlin.com/linux/v5.5/source/include/asm-generic/pgtable.= h#L549 [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?id=3Dc0ba10b512eb2e2a3888b6e6cc0e089f5e7a191b