From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexandru Chimac <alex@chimac.ro>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes
Date: Wed, 23 Sep 2026 16:58:20 +0200 [thread overview]
Message-ID: <d679c0e9-febe-4069-9c2f-a2173a5218aa@kernel.org> (raw)
In-Reply-To: <20260922-exynos9610-pinctrl-patch-v1-1-f6d816696591@chimac.ro>
On 22/09/2026 14:15, Alexandru Chimac wrote:
> All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
> to them, so force the nodes to have clocks assigned to them.
>
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
> Most Samsung Exynos9610 pin controllers (except TOP) have clocks
> designated for them, so allow the device tree node to include clock
I don't understand above. It's contradictory to commit msg which says
ALL. Here you say most.
Why two commit msgs?
> information for the driver.
that's ABI break without reason.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-23 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 12:15 [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes Alexandru Chimac
2026-09-22 12:31 ` sashiko-bot
2026-09-22 14:24 ` Alexandru Chimac
2026-09-22 14:25 ` Alexandru Chimac
2026-09-23 14:58 ` Krzysztof Kozlowski [this message]
2026-09-23 16:14 ` Alexandru Chimac
2026-09-28 8:06 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2026-09-22 12:07 Alexandru Chimac
2026-09-22 12:33 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d679c0e9-febe-4069-9c2f-a2173a5218aa@kernel.org \
--to=krzk@kernel.org \
--cc=alex@chimac.ro \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.