From: Taehee Yoo <ap420073@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net 0/3] amt: fix several bugs
Date: Thu, 26 May 2022 16:48:29 +0900 [thread overview]
Message-ID: <d68b1960-768a-e3f2-c401-bf8a1945d293@gmail.com> (raw)
In-Reply-To: <20220525214748.35fd8cf6@kernel.org>
On 5/26/22 13:47, Jakub Kicinski wrote:
Hi Jakub,
Thanks a lot for your review!
> On Mon, 23 May 2022 16:17:05 +0000 Taehee Yoo wrote:
>> This patchset fixes several bugs in amt module
>>
>> First patch fixes typo.
>>
>> Second patch fixes wrong return value of amt_update_handler().
>> A relay finds a tunnel if it receives an update message from the
gateway.
>> If it can't find a tunnel, amt_update_handler() should return an error,
>> not success. But it always returns success.
>>
>> Third patch fixes a possible memory leak in amt_rcv().
>> A skb would not be freed if an amt interface doesn't have a socket.
>
> Please double check you're not missing pskb_may_pull() calls.
> E.g. in amt_update_handler()? There's more.
As you pointed, I found that I missed pskb_may_pull() calls in
amt_multicast_data_handler() and amt_update_handler().
So, I will do some more checks and then send a patch.
Thank you so much!
Taehee Yoo
next prev parent reply other threads:[~2022-05-26 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 16:17 [PATCH net 0/3] amt: fix several bugs Taehee Yoo
2022-05-23 16:17 ` [PATCH net 1/3] amt: fix typo in amt Taehee Yoo
2022-05-23 16:17 ` [PATCH net 2/3] amt: fix return value of amt_update_handler() Taehee Yoo
2022-05-23 16:17 ` [PATCH net 3/3] amt: fix possible memory leak in amt_rcv() Taehee Yoo
2022-05-26 4:47 ` [PATCH net 0/3] amt: fix several bugs Jakub Kicinski
2022-05-26 7:48 ` Taehee Yoo [this message]
2022-05-26 4:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68b1960-768a-e3f2-c401-bf8a1945d293@gmail.com \
--to=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.