From mboxrd@z Thu Jan 1 00:00:00 1970 From: bvanassche@acm.org (Bart Van Assche) Date: Fri, 14 Jun 2019 16:56:28 -0700 Subject: [PATCH v2 2/3] nvmet: Export NVMe namespace attributes In-Reply-To: References: <20190610210612.103952-1-bvanassche@acm.org> <20190610210612.103952-3-bvanassche@acm.org> <4a104091-5ef2-ee3b-9653-cbb816b39a2e@acm.org> Message-ID: On 6/14/19 10:18 AM, Chaitanya Kulkarni wrote: > Sorry for not being clear, what I meant is uintXXX_t vs uXX. e.g. > instead of uint16_t ->u16, uint32_t ->u32. My comment refereed to the > consistency of the data type and not changing the size of the variable. Hi Chaitanya, I think the rule is that uint32_t etc. must be used in uapi header files. I'm not sure whether there is a strict rule for other kernel code than uapi header files. But since the NVMe code uses u32 etc., I will make this patch consistent with the rest of the NVMe code. Bart.