Re: [bitbake-devel] [PATCH] fetch2/git: Check srcrev exists in checkstatus()

[Maia Xiao <t-maiaxiao@linux.microsoft.com>]

>> Actually never mind on this first point, assuming that this isn't run on
>> all fetch paths (I didn't check that).
>>
>> But my second comment about the depth is something to consider.
>
> Yes, I'm also remembering comments someone made to me recently that
> many git servers don't support limited depth clones because of the load
> they put on the server.
>
> I appreciate this was moved to a newcomer bug as I think we assumed
> there was a straightforward way to remotely ask "is revision X in the
> repo" but it is looking like that might not be that easy :(

Going off what Bruce said, a potentially "softer" way to do this is to
keep self._lsremote(..) as the True condition, but we additionally try
to fetch the specified srcrev and just log a warning if that didn't
work.

If we feel reluctant about the additional fetch, another thing that we
could still do is to log a warning if the srcrev isn't a tag / at the
top of some branch (i.e., not in the ls-remote). I'm not sure if it is
(un)common enough for that check to make sense, though.

Happy to offer a v2 patch if there is interest in either. Thanks for the
discussion, folks!

~maia